http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12467 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 29175 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29175&action=edit Bug 12467 - Lost items marked as not on loan even if they are! The cronjob longoverdue.pl does not require that an item marked as lost be returned automatically, but there is a line in ModItem that automatically marks the item's onloan as false if itemlost is set! Test Plan: 1) Mark an item as lost with longoverdue.pl, without --mark-returned 2) Inspect the db, note that items.onloan is now 0 3) Apply this patch 4) Mark repeat step 1 5) Inspect the db, noe that items.onloan is still 1 6) Test marking an item as lost from staff interface, ensure there are no regressions. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12467 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29175|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 30766 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30766&action=edit [SIGNED-OFF] Bug 12467 - Lost items marked as not on loan even if they are! The cronjob longoverdue.pl does not require that an item marked as lost be returned automatically, but there is a line in ModItem that automatically marks the item's onloan as false if itemlost is set! Test Plan: 1) Mark an item as lost with longoverdue.pl, without --mark-returned 2) Inspect the db, note that items.onloan is now 0 3) Apply this patch 4) Mark repeat step 1 5) Inspect the db, noe that items.onloan is still 1 6) Test marking an item as lost from staff interface, ensure there are no regressions. Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12467 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This does what it claims to do, but I am a bit confused. I wanted to do the opposite and prove that the onloan is removed when I use --mark-returned - but the item is only marked as lost and never returned. Is this another bug? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12467 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30766|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30897 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30897&action=edit [PASSED QA] Bug 12467 - Lost items marked as not on loan even if they are! The cronjob longoverdue.pl does not require that an item marked as lost be returned automatically, but there is a line in ModItem that automatically marks the item's onloan as false if itemlost is set! Test Plan: 1) Mark an item as lost with longoverdue.pl, without --mark-returned 2) Inspect the db, note that items.onloan is now 0 3) Apply this patch 4) Mark repeat step 1 5) Inspect the db, noe that items.onloan is still 1 6) Test marking an item as lost from staff interface, ensure there are no regressions. Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Patch works according to test plan and fixes a data loss bug. Some notes: - This patch would be nicer with a regression test. - Also checked that returning the item removes lost status and onloan still. - Tried to test with --mark-returned, but couldn't get it to return my item neither with nor without the patch. (see comment on bug report) -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12467 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Can we have some regression tests for this one? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12467 --- Comment #8 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31265 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31265&action=edit Bug 12467 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12467 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #31265|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 31266 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=31266&action=edit Bug 12467 [QA Followup] - Unit Tests -- You are receiving this mail because: You are watching all bug changes.