[Bug 35264] New: Update patron import to use protected column
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 Bug ID: 35264 Summary: Update patron import to use protected column Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: dcook@prosentient.com.au QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Bug 26170 adds a new "protected" patrons column. This broke the unit test t/db_dependent/Koha/Patrons/Import.t which reminds us that we need to also update /cgi-bin/koha/tools/import_borrowers.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26170 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 [Bug 26170] Add protected status for patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Created attachment 158486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158486&action=edit Bug 35264: Add "protected" column to patron import This change adds the "protected" column to patron import. Test plan: 0. Apply the patch and run "restart_all" 1. prove -v t/db_dependent/Koha/Patrons/Import.t 2. Go to http://localhost:8081/cgi-bin/koha/tools/import_borrowers.pl 3. Note "protected" is listed in the "fields you want to supply" on the right side of the screen 4. Note "protected" appears in file downloaded by clicking "Download a Starter CSV file with all the columns" 5. Note that "Protected" appears after clicking "Enter default values" and after clicking "Preserve existing values" 6. For bonus marks, use the "Starter CSV file" to import a test patron (remember surname, branchcode, and categorycode are the required fields) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 Magnus Enger <magnus@libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus@libriotech.no -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Thanks David.. I was just looking at this myself. I wasn't yet sure whether the fix was here as you've suggested or whether we should be deleting the key when not present.. or a mix of both. Digging a bit deeper now. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158486|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 158494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158494&action=edit Bug 35264: Add "protected" column to patron import This change adds the "protected" column to patron import. Test plan: 0. Apply the patch and run "restart_all" 1. prove -v t/db_dependent/Koha/Patrons/Import.t 2. Go to http://localhost:8081/cgi-bin/koha/tools/import_borrowers.pl 3. Note "protected" is listed in the "fields you want to supply" on the right side of the screen 4. Note "protected" appears in file downloaded by clicking "Download a Starter CSV file with all the columns" 5. Note that "Protected" appears after clicking "Enter default values" and after clicking "Preserve existing values" 6. For bonus marks, use the "Starter CSV file" to import a test patron (remember surname, branchcode, and categorycode are the required fields) Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Going straight for a QA here as it get tests passing again. All works as designed and resolves the issue. Thanks for jumping on it David. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 --- Comment #5 from Magnus Enger <magnus@libriotech.no> --- Thanks for jumping on this before I could get round to it. You guys are awesome! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |23.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m --- Comment #7 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26170 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35264 Bug 35264 depends on bug 26170, which changed state. Bug 26170 Summary: Add protected status for patrons https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26170 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org