[Bug 35273] New: When editing items on receive, aqorders_items is not updated correctly
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Bug ID: 35273 Summary: When editing items on receive, aqorders_items is not updated correctly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org Depends on: 8179 I see something strange there: * Create a basket with creating items on order * Create an order line with 3 items * Close basked * Receive shipment * Edit first item displayed, add barcode * Check checkbox and receive * Verify the order line has been split 2:1 * Receive again - notice all 3 items are showing. It should only be the remaining 2. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 [Bug 8179] Receiving multiple order lines at once -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Note: ordernumber in aqorders.items was not updated correctly to the new ordernumber. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com, | |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #2 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- I don't recreate this on master. MariaDB [koha_kohadev]> select * from aqorders_items; +-------------+------------+---------------------+ | ordernumber | itemnumber | timestamp | +-------------+------------+---------------------+ | 2 | 973 | 2023-11-07 09:41:56 | | 1 | 974 | 2023-11-07 09:41:07 | | 1 | 975 | 2023-11-07 09:41:07 | +-------------+------------+---------------------+ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I have tested it multiple times on master last night, with the same and a new order. I had tested bug 35244 and set up the preferences: * AcqItemSetSubfieldsWhenReceiptIsCancelled: 7=-1 * AcqItemSetSubfieldsWhenReceived: 7=1 Could this be the difference? Did you use the "Edit" link from the item table on the receive page? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I hope to have narrowed it down some more: * If you receive/mark an item for receive that you haven't edited, it works ok. * If you mark an item you have edited, it will fail to properly receive. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #5 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 158587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158587&action=edit Bug 35273: Fix item selection when receiving -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |michaela.sieber@kit.edu -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #6 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The problem is coming around this code: 468 var _build_item = function(item, tr) { 469 var chb = $('<input type="checkbox" name="items_to_receive" value="'+item.item_id+'" />') 470 .prop('checked', item._checked) 471 .change(function() { 472 item._checked = $(this).prop('checked'); 473 }); 496 function PopupEditPage(biblionumber, itemnumber) { 509 success: function(item) { 510 var tr = $("#item_"+itemnumber); 511 item._checked = $(tr).find('input[type="checkbox"]').prop('checked'); 512 tr.html(''); 513 _build_item(item, tr); When the popup page is opened we lost the on change trigger (because we recreate the tr). This is ugly but the least intrusive I have found to not introduce regressions... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |jonathan.druart+koha@gmail. |ity.org |com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158587|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158767&action=edit Bug 35273: Fix item selection when receiving For partial receives with items created on order, the aqorders_items table was not correctly updated when only some of the ordered items were received. To test: 1) Create a basket with creating items on order 2) Create an order line with 3 items 3) Close basked 4) Receive shipment and create invoice 5) Receive your created order line 6) Edit first item displayed, add barcode 7) Check checkbox and receive 8) Verify the order line has been split 2:1 9) Receive again - notice all 3 items are showing. We should only see the remaining 2 10) Undo receive 11) Apply patch 12) Repeat steps 5)-9) 13) Verify that in step 9) only the remaining 2 items display now. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy@rijksmuseum.nl --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Seeing this crash passing by: Can't call method "edi_order" on an undefined value at /usr/share/koha/acqui/basket.pl line 381 Seems unrelated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Just a keyboard thing: Hitting Enter on Add item does not work. Out of scope here. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158767|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 158796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158796&action=edit Bug 35273: Fix item selection when receiving For partial receives with items created on order, the aqorders_items table was not correctly updated when only some of the ordered items were received. To test: 1) Create a basket with creating items on order 2) Create an order line with 3 items 3) Close basked 4) Receive shipment and create invoice 5) Receive your created order line 6) Edit first item displayed, add barcode 7) Check checkbox and receive 8) Verify the order line has been split 2:1 9) Receive again - notice all 3 items are showing. We should only see the remaining 2 10) Undo receive 11) Apply patch 12) Repeat steps 5)-9) 13) Verify that in step 9) only the remaining 2 items display now. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #11 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Passing QA but noting that this code is kind of unreadable. Need to study a day to see whats going on there.. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #12 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.11.00 |23.11.00,23.05.06 released in| | CC| |fridolin.somers@biblibre.co | |m --- Comment #13 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.05.x for 23.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pedro.amorim@ptfs-europe.co | |m Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 Klas Blomberg <klas.blomberg@skovde.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |klas.blomberg@skovde.se --- Comment #14 from Klas Blomberg <klas.blomberg@skovde.se> --- *** Bug 35244 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #15 from Klas Blomberg <klas.blomberg@skovde.se> --- We have added this patch on our 23.05.04 It works as long as we choose English as language for the staff client, but not when we change to Swedish -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Klas Blomberg from comment #15)
We have added this patch on our 23.05.04
It works as long as we choose English as language for the staff client, but not when we change to Swedish
Hi Klas, did you update both the templates for en and Swedish? The patch only edits the English ones. Depending on how you installed and your customizations, you can koha-translate --update or make the changes in the second file manually. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35273 --- Comment #17 from Klas Blomberg <klas.blomberg@skovde.se> --- Tanks - now it's working in both languages -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org