https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 --- Comment #1 from Shi Yao Wang <shi-yao.wang@inLibro.com> --- Created attachment 133362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133362&action=edit Bug 30551: Make cash register report take branchcode from cash register This patch makes it so cash register reports puts branchcode from the cash register where the payment was made into "Transaction library" column instead of taking the branchcode of the manager. Test plan: 1- Use cash registers (administration > system preferences > UseCashRegisters) 2- Create another library if you only have one (administration > libraries > new library) 3- Create a cash register in each library if they don't already have one (administration > cash registers > new cash register) 4- Create a fee on your own account and pay it right after in both libraries. 5- Go to reports > cash register and generate the statistics. 6- Notice "transaction library" in both rows are the same even though the fees were paid in two different libraries and two different cash registers. 7- Apply the patch and click submit to re-generate statistics 8- Notice it now shows the correct library where the transactions were done -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Looking here... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #134448|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 134710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=134710&action=edit Bug 30551: Make cash register report take branchcode from cash register This patch makes it so cash register reports puts branchcode from the cash register where the payment was made into "Transaction library" column instead of taking the branchcode of the manager. Test plan: 1- Use cash registers (administration > system preferences > UseCashRegisters) 2- Create another library if you only have one (administration > libraries > new library) 3- Create a cash register in each library if they don't already have one (administration > cash registers > new cash register) 4- Create a fee on your own account and pay it right after in both libraries. 5- Go to reports > cash register and generate the statistics. 6- Notice "transaction library" in both rows are the same even though the fees were paid in two different libraries and two different cash registers. 7- Apply the patch and click submit to re-generate statistics 8- Notice it now shows the correct library where the transactions were done Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |shi-yao.wang@inLibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can this please be backported? The bug goes back until 20.11, I have backported and tested the patch there locally. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable --- Comment #9 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Note: was backported to 21.11 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=30551 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |RESOLVED Resolution|--- |FIXED Version(s)|22.05.00 |22.05.00,21.05.17 released in| | --- Comment #10 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 21.05.x branch for 21.05.17 Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.