[Bug 31005] New: Cannot edit patrons in other categories if an extended attribute is mandatory and limited to a category
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Bug ID: 31005 Summary: Cannot edit patrons in other categories if an extended attribute is mandatory and limited to a category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com To recreate: 1 - Create a new patron attribute - check boxes to make it mandatory and visible etc. 2 - Limit it to 'Patron' or other category 3 - Edit a patron not in that category 4 - Attempt to save 5 - 500 Error 6 - Missing mandatory extended attribute (type=MAND) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136454&action=edit Bug 31005: Unit test -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 136455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136455&action=edit Bug 31005: Don't inlcude attributes only required for other categories To test: 1 - Create a new patron attribute - check boxes to make it mandatory and visible etc. 2 - Limit it to 'Patron' or other category 3 - Edit a patron not in that category 4 - Attempt to save 5 - 500 Error 6 - Missing mandatory extended attribute (type=MAND) 7 - Apply patch 8 - Attempt aedit again 9 - It succeeds! 10 - Edit a patron in the category with MAND required 11 - on the edit page, right click teh attribute - click 'delete node' 12 - Submit the form 13 - 500 error, but this time that's good, the attribute check works -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | Severity|normal |critical -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |27857 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27857 [Bug 27857] Koha::Patron->extended_attributes skips checks -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136454|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 136499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136499&action=edit Bug 31005: Unit test Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136455|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 136500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136500&action=edit Bug 31005: Don't inlcude attributes only required for other categories To test: 1 - Create a new patron attribute - check boxes to make it mandatory and visible etc. 2 - Limit it to 'Patron' or other category 3 - Edit a patron not in that category 4 - Attempt to save 5 - 500 Error 6 - Missing mandatory extended attribute (type=MAND) 7 - Apply patch 8 - Attempt aedit again 9 - It succeeds! 10 - Edit a patron in the category with MAND required 11 - on the edit page, right click teh attribute - click 'delete node' 12 - Submit the form 13 - 500 error, but this time that's good, the attribute check works Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #5 from David Nind <david@davidnind.com> --- Testing notes (using koha-testing-docker): 1. Tests pass: prove t/db_dependent/Koha/Patron.t 2. For step 11: in Firefox enable the web developer tools, select the input field for the attribute, then right click the HTML for the input field in the inspector window and select delete node, -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136499|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136501&action=edit Bug 31005: Unit test Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #136500|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 136502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=136502&action=edit Bug 31005: Don't inlcude attributes only required for other categories To test: 1 - Create a new patron attribute - check boxes to make it mandatory and visible etc. 2 - Limit it to 'Patron' or other category 3 - Edit a patron not in that category 4 - Attempt to save 5 - 500 Error 6 - Missing mandatory extended attribute (type=MAND) 7 - Apply patch 8 - Attempt aedit again 9 - It succeeds! 10 - Edit a patron in the category with MAND required 11 - on the edit page, right click teh attribute - click 'delete node' 12 - Submit the form 13 - 500 error, but this time that's good, the attribute check works Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Good catch, simple fix. Unit tests included and passing Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Version(s)|22.11.00 |22.11.00, 22.05.01 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 22.05.x for 22.05.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes an error when a release notes| |mandatory patron attribute | |limited to a specific | |patron category was causing | |a '500 error' when editing | |a patron not in that | |category. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Arthur Suzuki <arthur.suzuki@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki@biblibre.com Status|Pushed to stable |Pushed to oldstable Version(s)|22.11.00, 22.05.01 |22.11.00, 22.05.01, released in| |21.11.10 --- Comment #11 from Arthur Suzuki <arthur.suzuki@biblibre.com> --- backported to 21.11.x for 21.11.10, thx! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31005 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor@tuxayo.net Resolution|--- |FIXED Status|Pushed to oldstable |RESOLVED Version(s)|22.11.00, 22.05.01, |22.11.00, 22.05.01, released in|21.11.10 |21.11.10, 21.05.17 --- Comment #12 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Backported: Pushed to 21.05.x branch for 21.05.17 Nothing to document, marking resolved. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org