[Bug 43325] New: Remove event attribute from point of sale receipt window
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43325 Bug ID: 43325 Summary: Remove event attribute from point of sale receipt window Initiative type: --- Sponsorship Sponsored status: Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Point of Sale Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: martin.renvoize@openfifth.co.uk CC: testopia@bugs.koha-community.org Blocks: 38407 Target Milestone: --- When you print a receipt from the point of sale system, there are buttons in the template which use event attributes to trigger the closing of the window. We have a globally-defined event handler for the "close_window" class which already handles this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38407 [Bug 38407] Eliminate event handler attributes in the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43325 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff Comma delimited| |Athens County Public list of Sponsors| |Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=43325 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 203733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=203733&action=edit Bug 43325: Remove event attribute from point of sale receipt window This patch removes event attributes from the point of sale receipt template in favor of adding the "close_window" class to the links. The class has a globally-defined event handler for the close window operation To test, apply the patch and enable the EnablePointOfSale system preference if necessary. - If necessary, got to Administration -> Debit types and create at least one debit type which has the "Can be sold" checkbox checked. - Go to the point of sale page and add at least one item to purchase. - Fill out the "Collect payment" form and confirm. - When the payment is received, click the "Print receipt button" in the dialog. - On the receipt window which opens, click the "Close" button. The window should close. - Open the receipt window again and change the "accountlines_id" parameter in the URL to an accountlines ID which doesn't exist - The page should show an error message instead of a receipt. Test the "Close" button in this view. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org