[Bug 37762] New: Expand ILL to allow for Supplying Agency/Lending Library workflows
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Bug ID: 37762 Summary: Expand ILL to allow for Supplying Agency/Lending Library workflows Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: lisette@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: pedro.amorim@ptfs-europe.com, tomascohen@gmail.com Currently Koha's ILL module allows for the Koha library to be a borrowing library/institution but does not currently allow for the Koha library to be a supplying agency/lending library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Chip Halvorsen <Chip.Halvorsen@WestlakeLibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |Chip.Halvorsen@WestlakeLibr | |ary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Interested! I still need to have a conversation with a library about this, but I think they're interested in using Koha to manually track ILLs which they process via other external systems/processes. I'm going to look for confirmation on that though... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Adding the phrase "ISO 18626" to this bug, so that it's searchable. While the ISO standard wouldn't be a requirement to move ahead with this work, it would be a very useful addition here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |olli-antti.kivilahti@hypern | |ova.fi --- Comment #3 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- I started replying to David's comment on bug 19605 but I think it's better placed here because of ISO 18626. (In reply to David Cook from comment #45)
I'm intrigued by the idea of an ISO 18626 ILL Koha plugin, although not sure if it would be that straightforward or if backends like Rapido and ReShare would need their own plugins. Waiting to hear back libraries about workflows...
As I understand it: 1) Services like Rapido or ReShare would require their own plugins, yes. 2) ISO 18626 would ideally be implemented in core Koha in bug 37762. To start with, ISO 18626 defines 6 messages: https://illtransactions.org/schemas/ISO-18626-2021-2.xsd <xs:element ref="request"/> <xs:element ref="requestConfirmation"/> <xs:element ref="supplyingAgencyMessage"/> <xs:element ref="supplyingAgencyMessageConfirmation"/> <xs:element ref="requestingAgencyMessage"/> <xs:element ref="requestingAgencyMessageConfirmation"/> Some thoughts: We already have a POST /ill/requests endpoint in Koha. We would need to make it ISO 18626 compliant. And add everything else. I'm aware that https://wiki.koha-community.org/wiki/ISO18626_RFC describes a plugin, not core. But that RFC defines the plugin as a whole module, not a 'backend' plugin. We could have backends optionally have a new 'ILL_supplier' capability. If the backend has this capability, it tells Koha it is able to act as a supplier and the logic may follow that. These are just some ideas, happy to discuss, happy to be proven wrong. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Can you explain your thoughts a bit more on a core ISO18626 API and the relationship to the backend? Right now the backends implement the "connection" to the ILL system and how things get "translated" for Koha. How would a native ISO API fit? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com | |, | |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #5 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175323&action=edit Simple use case Had a chat with Martin, trying to come up with a light spec to get some work started here at some point. What I'm currently thinking would be core ISO18626 API to allow Koha to act as a supplying agency using the ISO18626 standard. The picture is a minimalist use case to start with. I don't know yet how backends fit here. Dev plan: - New illrequests database column `category` enum('send','received'). - All existing ILL requests become "Sent Requests". - New requests coming in from the ISO18626 interface are created as 'received'. Prerequisites: - The requesting agency needs to already exist on the supplying Koha as an ILL partner (as the request will be linked to that ILL partner). - New 'borrower' database columns to store required requesting agency details (credentials, URLs). Only shown if ILLModule enabled. This is just brainstorming and open to discussion / input. I'd love to hear back from you. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #6 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 175324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=175324&action=edit UI ILL requests table with tabs mock-up -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- This is sounding pretty good although that UI is having that common Koha problem of being way too wide I think... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Hackfest -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Jeremy Evans <jeremy.evans@ukhsa.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jeremy.evans@ukhsa.gov.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39520 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39520 [Bug 39520] Add lending status graph -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39521 [Bug 39521] Add column to ill_requests table to flag for lending requests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |39523 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39523 [Bug 39523] Add method for defining lending backend for ILL backends -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Hans Pålsson <hans.palsson@hkr.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hans.palsson@hkr.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |pedro.amorim@openfifth.co.u |ity.org |k URL| |https://github.com/openfift | |h/koha/commits/supplying_il | |l/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #175324|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #8 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Added the branch info here to the bug and updated it to be known that we're working on this. I've dropped the PoC UI screenshot as that is no longer relevant. We've decided to build a new vuejs module for supplying side ILL specifically, while keeping the current 'ILL requests' as is. All the ISO18626 specification is added to the swagger schemas, which allows for validation of all inbound/outbound ISO18626 messages. This is still a work in progress but the plan is to have it in a 'ready to test' stage in the near future. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |41001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41001 [Bug 41001] Dismissing the "Run now" modal breaks functionality -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Jason Robb <jrobb@sekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb@sekls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |41091 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41091 [Bug 41091] Add ISO18626 to ILL for borrowing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Andrew Fuerste-Henry <andrew@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aude.charillon@openfifth.co | |.uk -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature URL|https://github.com/openfift |https://github.com/openfift |h/koha/commits/supplying_il |h/koha/commits/bug_37762/ |l/ | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Rebecca Coert <rcoert@arlingtonva.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rcoert@arlingtonva.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tadeusz@sosnierz.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |richard.bridgen@nhs.net -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|41091 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41091 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41091 [Bug 41091] Add ISO18626 to ILL for borrowing -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|41001 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41001 [Bug 41001] Dismissing the "Run now" modal breaks functionality -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- This is now ready for testing: Preparation (ktd required, pick one): A) (New install) Checkout to openfifth/bug_37762 and reset_all B) (Upgrade) From main, checkout to openfifth/bug_37762 and run the following: updatedatabase yarn js:build yarn api:bundle sudo cp /kohadevbox/koha/debian/templates/apache-shared*.conf /etc/koha/ sudo rm -f /etc/koha/apache-shared-opac-git.conf /etc/koha/apache-shared-intranet-git.conf cd /kohadevbox/gitify && sudo ./koha-gitify kohadev /kohadevbox/koha && cd /kohadevbox/koha restart_all Test plan (KTD required): 1) Enable ILLModule 2) Run the following script to simulate an ISO18626_REQUEST coming in: $ sh POST_ISO18626_REQUEST.sh 3) Notice you get an authentication error 4) Create a new requesting agency, visit: <staff_url>/cgi-bin/koha/ill/iso18626_requesting_agencies 5) Click 'New requesting agency' and add 'Walker' to the ILL Partner. Pick the only patron that is suggested. 6) Pick any Name and any Type, add 'kohaid' to Account ID and 'kohacode' to Security Code 7) Repeat step 2). Confirm you know get a success message (messageStatus: OK). 8) Visit the ILLs to Supply: <staff_url>/cgi-bin/koha/ill/iso18626_requests 9) Click 'Manage request'. Notice the request status is 'RequestReceived' and the message containing the ISO18626 request is visible by clicking 'View message'. 10) Notice the top 'Expect to supply' button. Click that. 11) Perform a search (presumably using the metadata that came in, let's search 'test' for now). 12) Pick the 'Gairm.' search result and click that. On the detail page, click the toolbar button 'Place hold' and pick 'Place supply ILL hold for Walker. 13) Notice a 'ISO18626 ILL request details' box is shown. You may optionally add information here. 14) Place a regular hold, biblio-level for now. Click 'Place hold'. 15) You should now see the holds for 'Gairm.'. Notice the 'Supply ILL#' link on the hold details column. Click that. 16) You are now on the Supply ILL again. Notice the status is now ExpectToSupply and a message was sent to the requesting agency, under ISO18626 messages. This message should contain reasonforMessage: statusChange and the new status under statusInfo. 17) Notice a 'Will supply' button now shows. This is because in order to progress this Supply ILL an item needs to be assigned to the respective hold. 18) Let's check-in item '39999000001310'. This can be done by clicking the 'Will supply' button and picking 'Check-in' or by checking in '39999000001310' directly from the circulation check-in page. Visit the check-in page: <staff_url>/cgi-bin/koha/circ/returns.pl 19) Enter '39999000001310' (no single quotes) and click 'Confirm hold'. 20) Visit the supply ILL again: <staff_url>/cgi-bin/koha/ill/iso18626_requests/1 21) Notice the status is now WillSupply and another message was sent to the requesting agency. Notice a 'Mark as loaned' button now shows. Click on it. 22) You are now on the check-out page. You may optionally add some ISO18626 message details (which will be sent to the requesting agency) and click 'Yes, check out'. 23) Still on the 'Check out' page for Walker, click 'Show checkouts' to render the checkouts table. 24) Notice a (Supply ILL#) link under the check out title. Click on it. 25) We are back on our Supply ILL. The status is now 'Loaned' and a 'Complete loan' button is now shown. Clicking this button will check-in the item currently checked out ('39999000001310'). The check-in may also be performed from the circulation module directly, it'll reflect back to this respective Supply ILL. Click 'Complete loan'. 26) The checkin was successful, visit the Supply ILL again: <staff_url>/cgi-bin/koha/ill/iso18626_requests/1 27) Notice the Supply ILL is now 'LoanCompleted' with no available action buttons. The full lifecycle of this Supply ILL is retrievable from the ISO18626 messages section of the scren. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Hackfest |rel_26_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Lisette Scheer <lisette@bywatersolutions.com> --- Very exciting and lots of great stuff. Notes: http://main-intra.localhost/cgi-bin/koha/ill/iso18626_requests - table shows "Supplying Agency ID" but links to http://main-intra.localhost/cgi-bin/koha/ill/iso18626_requests/1 in that column Under step 12, if we click "place hold" from this screen can there be an option to mark it as for the ill from the results place hold link (not the button, but the link by the bib) When I save the hold, it just says processing and doesn't load the table. Same thing if I refresh or go to another record with non ill holds. In console: Uncaught ReferenceError: create_iso18626_request_link is not defined Same thing after checking it out for loading the checkout table -Failing SO for this, If you go to the ill, it does show the bib link and active hold on biblio. There is a supplyingAgencyMessage If you place an item level hold it will immediately go to "mark as loaned" and skips activating the hold and sending the "will supply" message. If you fill the hold it will change to will supply. If you go to check out the hold it properly recognize it's for the ill. Retry possible works, though pending requesting agency action should probably be updated from N/A to Retry or similar? Unfilled works (eventually being able to set policy would be nice, then maybe unmediated requests with z39.50 info to place holds specifically?) Other notes: - ILL home should have a widget for supplying ILLs - Should ILL partners have a link to ill requests like with borrowing requests? - Should be able to hide statuses, similar to ILLHiddenRequestStatuses (doesn't currently work it looks like) - Similarly tabs would be nice - Showing pending requests on the home page (like with purchase suggestions) would be great. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #11 from Lisette Scheer <lisette@bywatersolutions.com> --- Okay, not I'm not getting that problem but on a record with other holds they aren't loading on /request.pl and I'm seeing: Uncaught TypeError: can't access property "iso18626_request_id", row.iso18626_request is null If you override another hold to check the item out it doesn't do the correct status update. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #12 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hi Lisette, thank you so much for your testing and detailed feedback. (In reply to Lisette Scheer from comment #10)
http://main-intra.localhost/cgi-bin/koha/ill/iso18626_requests - table shows "Supplying Agency ID" but links to http://main-intra.localhost/cgi-bin/koha/ill/iso18626_requests/1 in that column
This is by design. The ISO18626 request ID is the ID of the request in the Supplying Agency (i.e. Supplying Agency ID). If this is confusing I'm open to ideas on how to improve it of course.
Under step 12, if we click "place hold" from this screen can there be an option to mark it as for the ill from the results place hold link (not the button, but the link by the bib)
Sorry I don't fully understand this one please clarify if possible.
When I save the hold, it just says processing and doesn't load the table. Same thing if I refresh or go to another record with non ill holds. In console: Uncaught ReferenceError: create_iso18626_request_link is not defined Same thing after checking it out for loading the checkout table -Failing SO for this,
Follow-up pushed to address this: https://github.com/openfifth/koha/commit/45ac09bb72008507877e794ad56e33372a6... Can you please retest? Thanks!
If you place an item level hold it will immediately go to "mark as loaned" and skips activating the hold and sending the "will supply" message. If you fill the hold it will change to will supply.
If we place an item level hold the ISO18626 request's status becomes 'ExpectToSupply'. The 'Mark as loaned' is an available action at this stage, yes. At this point, one of the following may happen: 1) 'Mark as loaned' is clicked from the ISO18626 request, a check-out will be facilitated. 2) The eligible barcode is checked-in through the circulation module, the hold confirmed, and the ISO18626 request updated to 'Will supply', as well as the corresponding message sent to the requesting agency. The above is working as designed, but of course any suggestion of improvement or making it clearer is welcome.
Retry possible works, though pending requesting agency action should probably be updated from N/A to Retry or similar?
This is a valid point, but I think 'Pending requesting agency action' is ambiguous and causing confusion here, understandably. 'Pending requesting agency action' is an action performed by the Requesting Agency that then requires an action by the Supplying Agency e.g. 'Cancel' or 'Renew'. In other words, it's the opposite of what RetryPossible is. RetryPossible is triggered by the Supplying Agency and then it's the Requesting agency that must act. Maybe a better way to word 'Pending requesting agency action' would be 'Requesting agency has requested'. Better alternative suggestions here are of course appreciated.
If you override another hold to check the item out it doesn't do the correct status update.
I was able to reproduce this issue: 1. Place an item-level hold for Henry 2. Check-in that item e.g. 39999000003130 (make it waiting) 3. Create a new ISO18626 request and 'Search to hold', place a bib-level hold on the same bib as above (for patron Walker) 4. Check-out the item from 2. 39999000003130 to Walker 5. Confirm an ISO18626 message input is shown and that the respective ISO18626 request is updated to 'Loaned' once the check-out happens (i.e. override Henry's hold). Submitted follow-up to address this: https://github.com/openfifth/koha/commit/9d971b9c1c3c06248a55becbc19e55a2192... Can you please retest when convenient? Thank you. I'm considering the rest of the comments as future enhancements not within immediate scope, happy to discuss further. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #13 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Pedro Amorim from comment #12)
Hi Lisette, thank you so much for your testing and detailed feedback.
(In reply to Lisette Scheer from comment #10)
http://main-intra.localhost/cgi-bin/koha/ill/iso18626_requests - table shows "Supplying Agency ID" but links to http://main-intra.localhost/cgi-bin/koha/ill/iso18626_requests/1 in that column
This is by design. The ISO18626 request ID is the ID of the request in the Supplying Agency (i.e. Supplying Agency ID). If this is confusing I'm open to ideas on how to improve it of course.
Maybe Supplying Agency Request ID, that makes it clear its the request ID not the id of the supplying agency? In the details page the "Requesting Agency Request ID:" does specify request ID and I think that makes it clearer (should probably change both in column and details screen)
Under step 12, if we click "place hold" from this screen can there be an option to mark it as for the ill from the results place hold link (not the button, but the link by the bib)
Sorry I don't fully understand this one please clarify if possible.
When I save the hold, it just says processing and doesn't load the table. Same thing if I refresh or go to another record with non ill holds. In console: Uncaught ReferenceError: create_iso18626_request_link is not defined Same thing after checking it out for loading the checkout table -Failing SO for this,
Follow-up pushed to address this: https://github.com/openfifth/koha/commit/ 45ac09bb72008507877e794ad56e33372a61fd72 Can you please retest? Thanks!
This is working now
If you place an item level hold it will immediately go to "mark as loaned" and skips activating the hold and sending the "will supply" message. If you fill the hold it will change to will supply.
If we place an item level hold the ISO18626 request's status becomes 'ExpectToSupply'. The 'Mark as loaned' is an available action at this stage, yes. At this point, one of the following may happen: 1) 'Mark as loaned' is clicked from the ISO18626 request, a check-out will be facilitated. 2) The eligible barcode is checked-in through the circulation module, the hold confirmed, and the ISO18626 request updated to 'Will supply', as well as the corresponding message sent to the requesting agency.
The above is working as designed, but of course any suggestion of improvement or making it clearer is welcome.
Great, I just wasn't sure if that was expected and put it in since it wasn't in the test plan (I went off plan looking at other stuff)
Retry possible works, though pending requesting agency action should probably be updated from N/A to Retry or similar?
This is a valid point, but I think 'Pending requesting agency action' is ambiguous and causing confusion here, understandably. 'Pending requesting agency action' is an action performed by the Requesting Agency that then requires an action by the Supplying Agency e.g. 'Cancel' or 'Renew'. In other words, it's the opposite of what RetryPossible is. RetryPossible is triggered by the Supplying Agency and then it's the Requesting agency that must act. Maybe a better way to word 'Pending requesting agency action' would be 'Requesting agency has requested'. Better alternative suggestions here are of course appreciated.
I like "Requesting agency has requested" I think it's more clear
If you override another hold to check the item out it doesn't do the correct status update.
I was able to reproduce this issue: 1. Place an item-level hold for Henry 2. Check-in that item e.g. 39999000003130 (make it waiting) 3. Create a new ISO18626 request and 'Search to hold', place a bib-level hold on the same bib as above (for patron Walker) 4. Check-out the item from 2. 39999000003130 to Walker 5. Confirm an ISO18626 message input is shown and that the respective ISO18626 request is updated to 'Loaned' once the check-out happens (i.e. override Henry's hold).
Submitted follow-up to address this: https://github.com/openfifth/koha/commit/ 9d971b9c1c3c06248a55becbc19e55a2192c1bbd
Works great now, thanks!
Can you please retest when convenient? Thank you. I'm considering the rest of the comments as future enhancements not within immediate scope, happy to discuss further.
Agreed, I just wanted the notes somewhere folks could see until I can go file followups once this is pushed. Going to do a little more testing to confirm nothing broke from those updates, but so far it's all been good. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #14 from Lisette Scheer <lisette@bywatersolutions.com> --- Some tests failed: [FAIL] t/db_dependent/Koha/ILL/ISO18626/Request.t FAIL file_permissions File must have the exec flag [FAIL] t/db_dependent/api/v1/iso18626/request.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 149) forbidden pattern: Use https:// instead of http:// for URLs (line 344) Otherwise it looks great. -Cancellation is still missing but we had discussed that's on your to do. -Cannot delete a requesting agency with iso requests --I think that should wait until 41178 is pushed so we can build on top of it/use or extend the vue components being introduced there. -Capitalization on some UI components --Should Widget Picker on /cgi-bin/koha/ill/home be capitalized like that? --/cgi-bin/koha/ill/iso18626_requests should Agency in the table headers be capitalized? --On the details of the request, should 'ISO18626 Messages' have messages capitalized? -- You are receiving this mail because: You are watching all bug changes.
From a librarian workflow standpoint, the table of requests and the request management page seem to lack the key bibliographic info I would need to know what item actually needs pulled. "View message" seems to be the only place
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #15 from Jason Robb <jrobb@sekls.org> --- Exciting to see this progressing! Overall everything seems to be working as described for me. that's visible? The table of requests would benefit from having a "title" column. It is much easier to reference a request by title than request number. The first block on the manage request page should be the bibliographic info as well. That's what I care about and what I need to know if I'm going to pull and fill the request. The rest of the info listed there is extraneous for me. I agree with Lisette that the "Supplying Agency ID" column in the requests table is confusing -- it reads like it is the ID of an organization rather than the ID of a request. I like "Supplying agency request ID" or maybe just "Supplying request ID". Other possible future considerations: I see the request metadata includes a biblionumber. It would be nice if the "Expect to supply" button had the option to go directly to that record if its supplied. I also agree with Lisette that tabbing the table out by status with a count on each tab would be beneficial. If the title were listed and the table were tabbed, I could use the "RequestReceived" tab as my pull list to make sure the items are on the shelf before committing to filling the request. It would also be nice if the statuses were more human-readable (i.e. RequestReceived = Pending, LoanCompleted = Complete, etc.). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #16 from Jason Robb <jrobb@sekls.org> --- This is looking good to me. I'm happy to sign off if the lack of visible bib info I mentioned in comment 15 can be addressed in future work. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #17 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- New test plan utilizing sandboxes and the ISO18626 client backend plugin: Supplying Koha: https://staff-supplyill.sandboxes.ptfs-europe.co.uk/ Requestsing Koha: https://staff-requestill.sandboxes.ptfs-europe.co.uk/ ILLModule is already enabled on both systems. ISO18626 client backend plugin is already installed and configured on the requesting Koha: https://staff-requestill.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/plugins/plugins-home.pl Requesting agency is already configured on the Supplying Koha: https://staff-supplyill.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/ill/iso18626_requesting_agencies Test plan: 1) On the requesting Koha, place a new ILL request, visit: https://staff-requestill.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/ill/ill-requests.pl?method=create&backend=Standard 2) Pick type 'book' and add an ISBN which exists in the supplying Koha e.g. '0786667478' 3) Add '42' for cardnumber, any library. 4) Notice ISO18626 backend comes back as available on the Auto backend stage. Click 'Confirm'. 5) On the next screen, you're given a list of available items and respective libraries, public notes are also shown if any exist. Pick item from Fairview. 6) Confirm request is created successfully. Click the 'Confirm request' button at the top. 7) Notice the request status is now 'Requested'. An ISO18626 message is displayed at the bottom showing what was sent to the supplying agency. You may click 'View message' to expand. 8) Notice the message contains a supplierUniqueRecordId, this corresponds to the supplying agency's biblionumber. Notice the rest of the metadata on the message, as well as the note containing barcode and library information for the specific item. Now, on to the supplying side: 1) Visit the supply ILLs: https://staff-supplyill.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/ill/iso18626_requests 2) (This is a live test system so other requests may already exist) Identify the corresponding request you just created or sort by id DESC and click 'Manage request'. 3) Open the message. Notice it's the same payload that was sent by the requesting Koha. 4) Take note of the barcode e.g. '39999000012859' and notice the supplierUniqueRecordId also exists. 5) Because a supplierUniqueRecordId exists, we don't need to perform a search to find the record for this request. Click 'Expect to supply (Place hold)' goes straight to the correct record. Pick 'Hold a specific item' and select an item (corresponding barcode if exists). Click 'Place hold'. 6) Now, on the patron holds screen, you should see a "Supply ILL#" under the hold details. Click that. 7) Confirm the status is now 'ExpectToSupply'. Confirm a supplyingAgencyMessage was sent to the requesting Koha. Confirm also that a supplyingAgencyMessageConfirmation was sent back from the requesting Koha. >From here you may do one of the following: Scenario A: 1) Go back to the requesting Koha side, verify that the status of the request is now 'Supplier expects to supply': https://staff-requestill.sandboxes.ptfs-europe.co.uk/cgi-bin/koha/ill/ill-requests.pl?op=illview&illrequest_id=2 2) You may now click 'Request cancellation'. Confirm a new message exists and status is now 'Cancellation requested'. 3) Visit the corresponding request on the supplying Koha. Verify that 'Requesting agency has requested' is 'Cancel' and that a 'Action: Cancel' message exists. 4) Click 'Cancel' from the top actions toolbar. Pick 'Yes'. Notice the screen shows a loading and toolbar actions are disabled. 5) Visit the request on the requesting Koha again. Notice it's now in 'Cancelled' status. The corresponding CancelResponse from the supplying Koha is stored and displayed. Scenario B: 1) On the supplying Koha, click the 'Mark as loaned (Check out)' top actions toolbar button. 2) Perform the checkout and click "Yes, check out". The supply ILL request on the supplying Koha should now be in status 'Loaned'. 3) On the requesting Koha, verify the corresponding request status is now 'In transit' and the supplying agency message is there. 4) Still on the requesting Koha, notice a 'Mark as received' button now exists. Click that button. 5) Confirm a new requesting message was sent to the supplying Koha with 'Action:Received'. 6) Notice that a 'Ship return' button now exists. Click that. Confirm the status is now 'Return shipped'. 7) Go back to the supplying Koha and find the corresponding supply ILL request, it should be 'Loaned' with a 'Action: ShippedReturn' message at the top. 8) Click the 'Complete loan (Check in)' button. 9) The request on the requesting Koha should now be 'Loan completed'. 10) The request on the supplying Koha should now be 'LoanCompleted'. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #18 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- The original test plan is still relevant but this new test plan contains the following new things: 1) Usage of a Koha system as requesting agency (utilzing the koha-ill-iso18626 plugin) 2) A use case utilizing supplierUniqueRecordId. This means the requesting agency has specified a bib record on the supply side, and supply side does not need to perform a search to find the relevant bib record. 3) Cancellation use case. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42428 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42428 [Bug 42428] Supply ILL - Biblio metadata is only visible in ISO18626 messages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #19 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Thank you Lisette and Jason for your time and feedback here.
Maybe Supplying Agency Request ID Addressed in: https://github.com/openfifth/koha/commit/1b8a6160e82da4c914bb771b913ddb81a07...
I like "Requesting agency has requested" I think it's more clear Addressed in: https://github.com/openfifth/koha/commit/81a4b2b8430e3cc261c5bd73d28b877bb7b...
Some tests failed: [FAIL] t/db_dependent/Koha/ILL/ISO18626/Request.t FAIL file_permissions File must have the exec flag [FAIL] t/db_dependent/api/v1/iso18626/request.t FAIL forbidden_patterns forbidden pattern: Use https:// instead of http:// for URLs (line 149) forbidden pattern: Use https:// instead of http:// for URLs (line 344) Addressed in: https://github.com/openfifth/koha/commit/cfa17d601f2aaacd3fafa695548e5fd77ed...
Otherwise it looks great. -Cancellation is still missing but we had discussed that's on your to do. -Cannot delete a requesting agency with iso requests --I think that should wait until 41178 is pushed so we can build on top of it/use or extend the vue components being introduced there. -Capitalization on some UI components --Should Widget Picker on /cgi-bin/koha/ill/home be capitalized like that? --/cgi-bin/koha/ill/iso18626_requests should Agency in the table headers be capitalized? --On the details of the request, should 'ISO18626 Messages' have messages capitalized? Not followed up with these. Please let me know if any are blockers. Cancellation works but it's not yet circulation authoritative i.e. cancelling a hold does not cancel the supply ILL request. This is tricky as the requesting agency must first request cancellation and only then the supplying agency cancels. That use case is covered.
I also agree with Lisette that tabbing the table out by status with a count on each tab would be beneficial. Addressed by: https://github.com/openfifth/koha/commit/453e7a974ba706ae105529d52c6a2def874... This does not add tabs, but adds a filter to the status column which allows the same effect e.g. filter by status. It does not behave like a facet for now but that can be followed-up after.
It would also be nice if the statuses were more human-readable (i.e. RequestReceived = Pending, LoanCompleted = Complete, etc.). I agree. For now I've gone with the ISO18626 status names exactly for transparency but we can revisit this in future work.
This is looking good to me. I'm happy to sign off if the lack of visible bib info I mentioned in comment 15 can be addressed in future work. Agreed. Thank you. Opened bug 42428.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lisette@bywatersolutions.co |y.org |m -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #20 from Lisette Scheer <lisette@bywatersolutions.com> --- Looking pretty good so far. I do notice the requesting side has you pick a specific item, that barcode is sent in the message, but it goes to a record level hold when you click "expect to supply" in the lending side. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #21 from Jason Robb <jrobb@sekls.org> --- This is great! I tried some deviations like using a bib-level hold rather than an item-level hold, requesting something that's not for loan, sending a retry, marking something unfilled. Everything seems to work as expected. There are things that would help with workflow (mentioned in earlier comments) but I don't think those are stoppers. The functionality as described in the test plan is working well. The only other thing I ran into was some noticeable slowness after the various operations that trigger messages back and forth but I'm guessing that's to be expected given the mechanics in play. Sidenotes on requesting (I know it is outside the scope of this bug but may be useful for later work on that end): - It would be nice to generate a temporary record + check out of the item in the requesting system - If there are two records with the same title, the ISO search says "found" but the next page lists no results - I was able to place a request for a record where none of the items were available for loan (it would be nice to prevent this on the requesting side) - I was able to place a request for a record with no items (it would also be nice to prevent this on the requesting side) I didn't run into anything that seemed broken or wasn't working as described within the scope of this bug. I'm happy to add my sign off on this in its current state. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #22 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Lisette Scheer from comment #20)
Looking pretty good so far. I do notice the requesting side has you pick a specific item, that barcode is sent in the message, but it goes to a record level hold when you click "expect to supply" in the lending side.
It should go to Koha's Circulation place hold page, where then the decision for bib-level or item-level is made. Unfortunately, I don't believe ISO18626 has a field which could be used to specify the item on the first request payload (though I'd love to be proven wrong) only the bib record (supplierUniqueRecordId), this is why I've decided to add that information in the notes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Pedro Amorim <pedro.amorim@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42431 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42431 [Bug 42431] ILL supply: Circulation slowness -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #23 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- (In reply to Jason Robb from comment #21)
This is great! I tried some deviations like using a bib-level hold rather than an item-level hold, requesting something that's not for loan, sending a retry, marking something unfilled. Everything seems to work as expected.
There are things that would help with workflow (mentioned in earlier comments) but I don't think those are stoppers. The functionality as described in the test plan is working well.
The only other thing I ran into was some noticeable slowness after the various operations that trigger messages back and forth but I'm guessing that's to be expected given the mechanics in play.
The slowness is expected for now, I think one possible solution for this would be to have the request back to the requesting agency be delegated to a background job, this would fix the slowness and maintain the same functionality. I've opened bug 42431.
Sidenotes on requesting (I know it is outside the scope of this bug but may be useful for later work on that end): - It would be nice to generate a temporary record + check out of the item in the requesting system - If there are two records with the same title, the ISO search says "found" but the next page lists no results - I was able to place a request for a record where none of the items were available for loan (it would be nice to prevent this on the requesting side) - I was able to place a request for a record with no items (it would also be nice to prevent this on the requesting side)
I didn't run into anything that seemed broken or wasn't working as described within the scope of this bug. I'm happy to add my sign off on this in its current state.
This is great, thank you Jason. Yes, the requesting side is very recent (as fresh as today) so there is still definitely a lot of work to do there. My main focus for now was to get it working well for the basic use cases to help testing this bug (since we're closing in on the window for a 26.05 push) and provide a glimpse on how it might work in the near future. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #24 from Lisette Scheer <lisette@bywatersolutions.com> --- (In reply to Jason Robb from comment #21)
I didn't run into anything that seemed broken or wasn't working as described within the scope of this bug. I'm happy to add my sign off on this in its current state.
Thanks Jason! Setting at signed-off for now. There's a commit on the branch labeled b0f896b5780847f3ca07fd4171d2b67ba0db5118 [Stolen from mblenk] Allow FormElement to accept hidden inputs Can you please rename to have a Koha allowed commit message if it needs to be included? Other than that I'm ready to PQA, though I'm going to try applying to main since your main that the branch is based off is a few commits behind main now once I know about the above commit. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #25 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Renamed the commit in question and rebased on current main. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #26 from Lisette Scheer <lisette@bywatersolutions.com> --- I don't have permission to push back into your repo, but I pass QA! Thanks for all the hard work. I'll file some more follow ups soon for the various things Jason and I brought up, but none of those are blockers to getting this pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #27 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Thank you both. I've added the following to all 44 commits: Signed-off-by: Jason Robb <jrobb@sekls.org> Signed-off-by: Lisette Scheer <lisette@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #28 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- xt/api.t: xt/api.t ........................................ 1/8 # Failed test at xt/api.t line 93. # got: '1' # expected: '0' # $VAR1 = [ # { # 'route' => '/public/ill/iso18626', # 'type' => 'parameter', # 'verb' => 'post', # 'name' => 'message' # } # ]; xt/api.t ........................................ 3/8 # Failed test 'No tag errors in the spec' # at xt/api.t line 130. # Structures begin differing at: # $got->[0] = 'get /ill/iso18626_requests -> uses tag 'iso18626_requests' not present in top level list' # $expected->[0] = Does not exist get /ill/iso18626_requests -> uses tag 'iso18626_requests' not present in top level list get /ill/iso18626_requests/{iso18626_request_id} -> uses tag 'iso18626_requests' not present in top level list patch /ill/iso18626_requests/{iso18626_request_id} -> uses tag 'iso18626_requests' not present in top level list delete /ill/iso18626_requesting_agencies/{iso18626_requesting_agency_id} -> uses tag 'iso18626_requesting_agencies' not present in top level list get /ill/iso18626_requesting_agencies/{iso18626_requesting_agency_id} -> uses tag 'iso18626_requesting_agencies' not present in top level list put /ill/iso18626_requesting_agencies/{iso18626_requesting_agency_id} -> uses tag 'iso18626_requesting_agencies' not present in top level list get /ill/iso18626_requesting_agencies -> uses tag 'iso18626_requesting_agencies' not present in top level list post /ill/iso18626_requesting_agencies -> uses tag 'iso18626_requesting_agencies' not present in top level list post /public/ill/iso18626 -> uses tag 'iso18626' not present in top level list # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #29 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- prove xt/find-missing-auth_checks.t: xt/find-missing-auth_checks.t .. 1/2 # Failed test at xt/find-missing-auth_checks.t line 42. # got: '7' # expected: '0' # No auth check in the following files: # catalogue/ISBDdetail.pl # catalogue/MARCdetail.pl # catalogue/detail.pl # catalogue/imageviewer.pl # catalogue/labeledMARCdetail.pl # catalogue/moredetail.pl # catalogue/search.pl # Looks like you failed 1 test of 2. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #30 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 198800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198800&action=edit Bug 37762: (RM follow-up) Fix swagger defs Patch from commit 07ffdc1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #31 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Created attachment 198801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198801&action=edit Bug 37762: (RM follow-up) Update auth check for new Koha::Controller::Catalogue Patch from commit 2740df5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_26_05_candidate | Text to go in the| |26.05.00 release notes| | --- Comment #32 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- pushed to main for 26.05.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main --- Comment #33 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Please add release notes ASAP! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #34 from David Cook <dcook@prosentient.com.au> --- Ohh this sounds exciting I think -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed CC| |jonathan.druart@gmail.com --- Comment #35 from Jonathan Druart <jonathan.druart@gmail.com> --- Crazy to see huge stuff like that pushed in a month, right before the release... 155 files changed, 10184 insertions(+), 241 deletions(-) The number of tests is terribly low regarding the diff. There are new concepts introduced without discussion (Koha::Controller, Vue's Patron autocomplete), that should have been on separate bug reports. Some comments in the code should have been resolved before push. * //Write handling of supply ILL params here ? before submit? * TODOs * This one seems blocker: + get: () => { + ILLModule: 1; + }, // TODO: Fetch from API Commented JS code in request.tt Strings in .vue files not translatable (not using $__()) Vue's v-html is being removed on another bug, because of potential XSS The new occurrence added to components/LinkWrapper.vue should be investigated. Syspref's getAll should have used the new endpoint. What is actually done on bug 41995 (trivial patch waiting for QA for 2 months now). Several tests on Jenkins are failing, adding additional_work_needed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #36 from Jonathan Druart <jonathan.druart@gmail.com> --- + + if (@errors) { + + #TODO: Throw exception + use Data::Dumper; + $Data::Dumper::Maxdepth = 4; + warn Dumper( '##### 2 #######################################################line: ' . __LINE__ ); + warn Dumper( \@errors ); + warn Dumper('##### end2 #######################################################'); + } -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #37 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #35)
Crazy to see huge stuff like that pushed in a month, right before the release...
155 files changed, 10184 insertions(+), 241 deletions(-)
The number of tests is terribly low regarding the diff.
There are new concepts introduced without discussion (Koha::Controller, Vue's Patron autocomplete), that should have been on separate bug reports.
Some comments in the code should have been resolved before push. * //Write handling of supply ILL params here ? before submit? * TODOs * This one seems blocker: + get: () => { + ILLModule: 1; + }, // TODO: Fetch from API
Commented JS code in request.tt
Strings in .vue files not translatable (not using $__())
Vue's v-html is being removed on another bug, because of potential XSS The new occurrence added to components/LinkWrapper.vue should be investigated.
Syspref's getAll should have used the new endpoint. What is actually done on bug 41995 (trivial patch waiting for QA for 2 months now).
Several tests on Jenkins are failing, adding additional_work_needed.
Pedro is working on follow-ups and addressing these issues. For some of this, we should file new follow-up bugs. I would like the remaining issues and necessary follow-up before the end of the week. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #38 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #35)
Crazy to see huge stuff like that pushed in a month, right before the release...
155 files changed, 10184 insertions(+), 241 deletions(-)
Yeah, when you put it that way, this is a bit scary to see. I'm excited for the functionality, but that seems like a really big change right before a release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #39 from David Cook <dcook@prosentient.com.au> --- Looks like this code accidentally re-introduced visual_hold_group_id back into svc/holds which has broken the grouping of holds. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=41956 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #40 from David Cook <dcook@prosentient.com.au> --- Created attachment 198979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198979&action=edit Bug 37762: (QA follow-up) remove reintroduced visual_hold_group_id Patch from commit 9eb7fec -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #41 from David Cook <dcook@prosentient.com.au> --- I've added a patch here rather than opening a new bug just because I figure it's such a big dev that a patch in a separate bug might get lost? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #42 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 198989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198989&action=edit Bug 37762: (QA follow-up): Remove obsolete code This was leftover from a previous approach at implementing it, before hooking into holds/circulation was entirely holds authoritative. As it currently stands, the note and expectedDeliveryData form inputs are rendered and handled by the request.tt form when placing a hold, if a supplyill param exists. The params are then sent to AddReserve by placerequest.pl which in turn sends it to progress_iso18626_request. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #43 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 198990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198990&action=edit Bug 37762: (QA follow-up): Remove obsolete code This is leftover from original implementation. It since moved to js/vue/stores/ill.js and is managed by ILL/Main.vue To test: 1) Access (with ILLModule enabled and disabled): http://localhost:8081/cgi-bin/koha/ill/ill.pl 2) Confirm you get the module if ILLModule is enabled, or a message if it's disabled -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #44 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 198991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198991&action=edit Bug 37762: (QA follow-up): Remove obsolete code This is leftover from original implementation of progressRequest when it was it's own component. All functionality is now in SupplyingResourve.vue instead -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #45 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 198992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198992&action=edit Bug 37762: (QA follow-up): Fix cypress ILL tests cypress run --spec t/cypress/integration/ILL/* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #46 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 198993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198993&action=edit Bug 37762: (QA follow-up): Revert LinkWrapper template v-else v-html The v-html directive was unintentionally left on the fallback <template> in LinkWrapper during the introduction of the ILL module. It has no effect and should not have been committed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #47 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 198994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198994&action=edit Bug 37762: (QA follow-up): Remove v-html directive from ShowElement.vue This reimplements how patronAutoComplete behaves on ShowElement, keeping the same functionality but dropping v-html -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #48 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 198995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=198995&action=edit Bug 37762: (QA follow-up): Add translatability to missing strings Patch from commit 3ad90a5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #49 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Hi all, thanks for the fair feedback and criticism. Follow-ups attached. Still on my list to follow-up: #TODO: Throw exception (In reply to David Cook from comment #41)
I've added a patch here rather than opening a new bug just because I figure it's such a big dev that a patch in a separate bug might get lost?
Thank you, David. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #50 from Jonathan Druart <jonathan.druart@gmail.com> --- components/ILL/ISO18626MessageDisplay.vue 38 {{ new Date(message.timestamp).toLocaleString() }} Should certainly use format_date/$date (like everywhere else in .vue file) Regarding the translatability patch, there are more to fix: components/ILL/ProgressRequest.vue 7 This request's status is 11 <p>Below are the possible actions in order to progress it.</p> 54 <p>This request has been completed. Nothing to do here.</p> components/ILL/ISO18626MessageDisplay.vue 13 <th>Type</th> 14 <th>Information</th> 15 <th>Timestamp</th> 16 <th>Content</th> 46 View message components/ILL/SupplyingResource.vue 932 { name: "Request details", pane: 1 }, 933 { name: "ISO18626 Messages", pane: 1 }, 934 { name: "Circulation information", pane: 2 }, 935 { name: "Specified by the requesting agency", pane: 2 }, Not even talking about those ones that feel wrong: 32 {{ message.type }} 35 {{ getMessageData(message.content) }} 96 message_data = "Reason: " + message_data; 99 message_data = "Action: " + message_data; Also caught this: 122 placeholder: $__( 123 "http://localhost:8081/api/v1/contrib/iso18626/supplying_agency_message" 124 ), components/ModuleDashboard/Widgets/ILLRequests.vue (script part not needed) 16 {{ visitOldILLModuleText }} 45 const visitOldILLModuleText = $__( 46 "Visit ILL requests (previously ILL Module)" 47 ); 195 visitOldILLModuleText, import statements use rel paths, should have used '@koha-vue' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #51 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Jonathan Druart from comment #50)
components/ILL/ISO18626MessageDisplay.vue 13 <th>Type</th> 14 <th>Information</th> 15 <th>Timestamp</th> 16 <th>Content</th> 46 View message
components/ILL/SupplyingResource.vue 932 { name: "Request details", pane: 1 }, 933 { name: "ISO18626 Messages", pane: 1 }, 934 { name: "Circulation information", pane: 2 }, 935 { name: "Specified by the requesting agency", pane: 2 },
You fixed those 2 ones already! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42580 [Bug 42580] 500 error for patron holds table when using group holds (DisplayAddHoldGroups) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #52 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #51)
(In reply to Jonathan Druart from comment #50)
components/ILL/ISO18626MessageDisplay.vue 13 <th>Type</th> 14 <th>Information</th> 15 <th>Timestamp</th> 16 <th>Content</th> 46 View message
components/ILL/SupplyingResource.vue 932 { name: "Request details", pane: 1 }, 933 { name: "ISO18626 Messages", pane: 1 }, 934 { name: "Circulation information", pane: 2 }, 935 { name: "Specified by the requesting agency", pane: 2 },
You fixed those 2 ones already!
Are these translatable? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #53 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956#c14 Over on Bug 41956, David notes that one now gets an error when attempting to group pre-existing holds from the patron's record. He traces the issue back to this code. I can confirm the error. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #54 from Andrew Fuerste-Henry <andrew@bywatersolutions.com> --- (In reply to Andrew Fuerste-Henry from comment #53)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=41956#c14
Over on Bug 41956, David notes that one now gets an error when attempting to group pre-existing holds from the patron's record. He traces the issue back to this code. I can confirm the error.
Oop, he's already said that above. Sorry! Need to read all the emails and drink all the coffee before commenting. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #55 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 199035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199035&action=edit Bug 37762: (QA follow-up): Warn and return 500 on schema validation failure in progress_request An exception is not implemented as progress_request is called in different circulation contexts (hold is placed, checkout happens, etc) and those actions should not be dependent on the outcome of progress_request, i.e. if progress_request fails due to schema validation failure, the circulation action should happen as before. prove t/db_dependent/Koha/ILL/ISO18626/Request.t prove t/db_dependent/api/v1/iso18626/request.t cypress run --spec t/cypress/integration/ILL/SupplyingRequests.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #56 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 199036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199036&action=edit Bug 37762: (QA follow-up) Utilize format_datetime Patch from commit bd2ca51 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #57 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Created attachment 199037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199037&action=edit Bug 37762: (QA follow-up): Display translatable string directly on template No script. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #58 from Pedro Amorim <pedro.amorim@openfifth.co.uk> --- Thanks Joubu for the time dedicated here. (In reply to Jonathan Druart from comment #50)
components/ILL/ISO18626MessageDisplay.vue 38 {{ new Date(message.timestamp).toLocaleString() }} Should certainly use format_date/$date (like everywhere else in .vue file)
Followed up.
Regarding the translatability patch, there are more to fix: components/ILL/ProgressRequest.vue 7 This request's status is 11 <p>Below are the possible actions in order to progress it.</p> 54 <p>This request has been completed. Nothing to do here.</p>
ProgressRequest.vue no longer exists.
components/ILL/ISO18626MessageDisplay.vue 13 <th>Type</th> 14 <th>Information</th> 15 <th>Timestamp</th> 16 <th>Content</th> 46 View message
components/ILL/SupplyingResource.vue 932 { name: "Request details", pane: 1 }, 933 { name: "ISO18626 Messages", pane: 1 }, 934 { name: "Circulation information", pane: 2 }, 935 { name: "Specified by the requesting agency", pane: 2 },
Not even talking about those ones that feel wrong: 32 {{ message.type }} 35 {{ getMessageData(message.content) }}
96 message_data = "Reason: " + message_data; 99 message_data = "Action: " + message_data;
I believe these are all fixed by prior follow-up(s).
Also caught this: 122 placeholder: $__( 123 "http://localhost:8081/api/v1/contrib/iso18626/supplying_agency_message" 124 ),
This is a visual placeholder illustrating how a requesting Koha URL would look like. It has no functional implications (i.e. 'localhost' here is not used for anything).
components/ModuleDashboard/Widgets/ILLRequests.vue (script part not needed) 16 {{ visitOldILLModuleText }} 45 const visitOldILLModuleText = $__( 46 "Visit ILL requests (previously ILL Module)" 47 ); 195 visitOldILLModuleText,
Followed up.
import statements use rel paths, should have used '@koha-vue'
This is being used: import { $__ } from "@koha-vue/i18n"; Where else do we need to add it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #59 from Jonathan Druart <jonathan.druart@gmail.com> --- (In reply to Pedro Amorim from comment #58)
Also caught this: 122 placeholder: $__( 123 "http://localhost:8081/api/v1/contrib/iso18626/supplying_agency_message" 124 ),
This is a visual placeholder illustrating how a requesting Koha URL would look like. It has no functional implications (i.e. 'localhost' here is not used for anything).
Does it need to be translatable?
import statements use rel paths, should have used '@koha-vue'
This is being used: import { $__ } from "@koha-vue/i18n";
Where else do we need to add it?
Everywhere we import from a Koha component. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #60 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- follow-ups here pushed to main, thanks everyone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #61 from David Nind <david@davidnind.com> --- *** Bug 42580 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #62 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- cypress run --spec t/cypress/integration/t/insertData.ts DevTools listening on ws://127.0.0.1:41949/devtools/browser/7e46bec0-7e2d-40be-ab3a-121cf470919d [145570:0521/154157.932684:ERROR:gpu_memory_buffer_support_x11.cc(44)] dri3 extension not supported. Missing baseUrl in compilerOptions. tsconfig-paths will be skipped ==================================================================================================== (Run Starting) ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ Cypress: 12.17.4 │ │ Browser: Electron 106 (headless) │ │ Node Version: v20.20.1 (/usr/bin/node) │ │ Specs: 1 found (insertData.ts) │ │ Searched: t/cypress/integration/t/insertData.ts │ │ Experiments: experimentalStudio=true │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ──────────────────────────────────────────────────────────────────────────────────────────────────── Running: insertData.ts (1 of 1) insertData deleteSampleObjects ✓ should delete everything from Object (689ms) ✓ should delete everything from Array (430ms) insertSampleBiblio ✓ should generate library and item type (579ms) ✓ insertSampleBiblio - options.different_libraries (569ms) insertSampleHold Error: Properties not allowed: iso18626_request. at /kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:307:55 at processTicksAndRejections (node:internal/process/task_queues:95:5) 1) insertSampleHold - item/biblio 2) "after each" hook for "insertSampleHold - item/biblio" 4 passing (4s) 2 failing 1) insertData insertSampleHold insertSampleHold - item/biblio: CypressError: `cy.task('insertSampleHold')` failed with the following error:
Error: Properties not allowed: iso18626_request.
https://on.cypress.io/api/task at <unknown> (http://koha:8081/__cypress/runner/cypress_runner.js:134597:70) at tryCatcher (http://koha:8081/__cypress/runner/cypress_runner.js:1807:23) at Promise._settlePromiseFromHandler (http://koha:8081/__cypress/runner/cypress_runner.js:1519:31) at Promise._settlePromise (http://koha:8081/__cypress/runner/cypress_runner.js:1576:18) at Promise._settlePromise0 (http://koha:8081/__cypress/runner/cypress_runner.js:1621:10) at Promise._settlePromises (http://koha:8081/__cypress/runner/cypress_runner.js:1697:18) at _drainQueueStep (http://koha:8081/__cypress/runner/cypress_runner.js:2407:12) at _drainQueue (http://koha:8081/__cypress/runner/cypress_runner.js:2400:9) at Async._drainQueues (http://koha:8081/__cypress/runner/cypress_runner.js:2416:5) at Async.drainQueues (http://koha:8081/__cypress/runner/cypress_runner.js:2286:14) From Your Spec Code: at Context.eval (webpack://koha/./t/cypress/integration/t/insertData.ts:146:23) From Node.js Internals: Error: Error: Properties not allowed: iso18626_request. at HttpClient.<anonymous> (/kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:323:50) at step (/kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:191:23) at Object.<anonymous> (/kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:132:20) at asyncGeneratorStep (/kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:11:28) at _next (/kohadevbox/koha/t/cypress/plugins/dist/api-client.cjs.js:29:17) at processTicksAndRejections (node:internal/process/task_queues:95:5) 2) insertData insertSampleHold "after each" hook for "insertSampleHold - item/biblio": Row count for borrowers should match + expected - actual -54 +53 at Context.eval (webpack://koha/./t/cypress/integration/t/insertData.ts:268:29) (Results) ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ Tests: 8 │ │ Passing: 4 │ │ Failing: 1 │ │ Pending: 0 │ │ Skipped: 3 │ │ Screenshots: 2 │ │ Video: true │ │ Duration: 3 seconds │ │ Spec Ran: insertData.ts │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ (Screenshots) - /kohadevbox/koha/t/cypress/screenshots/insertData.ts/insertData -- insertSampleH (1280x720) old -- insertSampleHold - itembiblio (failed).png - /kohadevbox/koha/t/cypress/screenshots/insertData.ts/insertData -- insertSampleH (1280x720) old - itembiblio -- after each hook (failed).png (Video) - Started compressing: Compressing to 32 CRF - Finished compressing: 0 seconds - Video output: /kohadevbox/koha/t/cypress/videos/insertData.ts.mp4 ==================================================================================================== (Run Finished) Spec Tests Passing Failing Pending Skipped ┌────────────────────────────────────────────────────────────────────────────────────────────────┐ │ ✖ insertData.ts 00:03 8 4 1 - 3 │ └────────────────────────────────────────────────────────────────────────────────────────────────┘ ✖ 1 of 1 failed (100%) 00:0 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #63 from Pedro Amorim (ammopt) <pedro.amorim@openfifth.co.uk> --- Created attachment 199389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=199389&action=edit Bug 37762: (QA follow-up): Fix insertData.js cypress run --spec t/cypress/integration/t/insertData.ts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #64 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Thank you for the quick follow-up Pedro! Follow-up pushed to main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Version(s)| |26.05.00 released in| | Text to go in the|26.05.00 | release notes| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Jacob O'Mara <jacob.omara@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting --- Comment #65 from Jacob O'Mara <jacob.omara@openfifth.co.uk> --- This will not be backported to 25.11.x due to it being deemed an enhancement or a dependancy not being met -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main Summary|Expand ILL to allow for |Expand ILL to allow for |Supplying Agency/Lending |supplying agency/lending |Library workflows |library workflows -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42630 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42630 [Bug 42630] Terminology: Supply ILL #%s: %s -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42686 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42686 [Bug 42686] Terminology: Active hold on biblio -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42687 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42687 [Bug 42687] Capitalization: ILL Requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42688 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42688 [Bug 42688] Capitalization: ILL Module -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42685 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42685 [Bug 42685] Capitalization: 'Supplying Agency Request ID' and others -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |42689 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=42689 [Bug 42689] How to handle English ILL status names in translation? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Amber Hoskins <ahoskins@nckls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ahoskins@nckls.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 --- Comment #66 from Lisette Scheer <lisette@bywatersolutions.com> --- *** Bug 39520 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37762 Bug 37762 depends on bug 39520, which changed state. Bug 39520 Summary: Add lending status graph https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39520 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org