http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | Status|NEW |Needs Signoff Patch complexity|--- |String patch See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45616|Bug 15363 - |Bug 15363 - description|Translatability: Fix issue |Translatability: Fix issue |with ambiguous 'all' on |with ambiguous 'all' on |Administration › Set |Administration > Set |library checkin and |library checkin and |transfer policy |transfer policy -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363 --- Comment #4 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #3)

With this patch, we get msgid "%sFor all collection codes: %sFor all item types: %s" Dont you think it's better to have 2 different entries?

You just need to move the strong tag into the IF statement.

Hi Jonathan, do you mean the following? <fieldset>[% IF ( limitType == 'ccode' ) %]For <strong>all</strong> collection codes: [% ELSE %]For <strong>all</strong> item types: [% END %]<a id="CheckAll" href="#">Check all</a> | <a id="UncheckAll" href="#">Uncheck all</a></fieldset> If yes, we have the string splitting again, no? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363 --- Comment #6 from Marc Véron <veron@veron.ch> --- Created attachment 45819 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45819&action=edit Bug 15363: (followup) Move tags inside if statements Followup for comment #3 -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45671|0 |1 is obsolete| | Attachment #45819|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45827 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45827&action=edit Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into a translatable context. To test: Apply patch - Go to Home > Administration > Set library checkin and transfer policy - Verify that the word 'all' is no longer separated by tags in "For all collection codes: " rsp. "For all item types: " (Switch with syspref 'BranchTransfersLimitsType') Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works well for translation purpose Bug 15363: (followup) Move tags inside if statements Followup for comment #3 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45827|0 |1 is obsolete| | --- Comment #8 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46032&action=edit Bug 15363: Translatability: Fix issue with ambiguous 'all' on Administration > Set library checkin and transfer policy In branch_transfer_limits.tt, set ambiguous word 'all' (separated by tags) into a translatable context. To test: Apply patch - Go to Home > Administration > Set library checkin and transfer policy - Verify that the word 'all' is no longer separated by tags in "For all collection codes: " rsp. "For all item types: " (Switch with syspref 'BranchTransfersLimitsType') Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> Works well for translation purpose Bug 15363: (followup) Move tags inside if statements Followup for comment #3 Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15363 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #10 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed in 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.