[Bug 15365] New: Translatability: Fix issue on Administration > Circulation and fine rules
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Bug ID: 15365 Summary: Translatability: Fix issue on Administration > Circulation and fine rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs@lists.koha-community.org Reporter: veron@veron.ch QA Contact: testopia@bugs.koha-community.org CC: frederic@tamil.fr Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 --- Comment #1 from Marc Véron <veron@veron.ch> --- Created attachment 45619 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45619&action=edit Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines). To test: - Apply patch - Go to Administration > Circulation and fine rules - Verify that the lines "Note: " and "Important: " below "Default holds policx by item type" make sense and are not splitted by tags and (in html) by newlines. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=14459 Assignee|koha-bugs@lists.koha-commun |veron@veron.ch |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45619|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 45620 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45620&action=edit Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines). To test: - Apply patch - Go to Administration > Circulation and fine rules - Verify that the lines "Note: " and "Important: " below "Default holds policy by item type" make sense and are not splitted by tags and (in html) by newlines. (Amended to fix commit message) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45620|0 |1 is obsolete| | --- Comment #3 from Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> --- Created attachment 45664 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45664&action=edit [SIGNED-OFF]Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines). To test: - Apply patch - Go to Administration > Circulation and fine rules - Verify that the lines "Note: " and "Important: " below "Default holds policy by item type" make sense and are not splitted by tags and (in html) by newlines. (Amended to fix commit message) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> strong Note and Important displayed Ok for translation purpose -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Héctor Eduardo Castro Avalos <hector.hecaxmmx@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hector.hecaxmmx@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- This is a bug in the translation process, em and string tags should not be isolated, IMO. I have tried to fix it, but no luck. Frédéric, do you think this could be done easily? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45664|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 45806 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45806&action=edit Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines). To test: - Apply patch - Go to Administration > Circulation and fine rules - Verify that the lines "Note: " and "Important: " below "Default holds policy by item type" make sense and are not splitted by tags and (in html) by newlines. (Amended to fix commit message) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> strong Note and Important displayed Ok for translation purpose Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #45806|0 |1 is obsolete| | --- Comment #6 from Brendan Gallagher <brendan@bywatersolutions.com> --- Created attachment 46033 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46033&action=edit Bug 15365: Translatability: Fix issue on Administration > Circulation and fine rules Fix translatability issue on smart-rules.tt to prevent odd translations (Sentences splitted by tags and newlines). To test: - Apply patch - Go to Administration > Circulation and fine rules - Verify that the lines "Note: " and "Important: " below "Default holds policy by item type" make sense and are not splitted by tags and (in html) by newlines. (Amended to fix commit message) Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com> strong Note and Important displayed Ok for translation purpose Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Brendan A Gallagher <brendan@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendan@bywatersolutions.co | |m --- Comment #7 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to master - thanks! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed in 3.22.x, will be in 3.22.2 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15365 --- Comment #9 from Frédéric Demians <frederic@tamil.fr> --- This patch has been pushed to 3.20.x, will be in 3.20.8. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org