https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|SIP2 |Staff Client CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 --- Comment #3 from Phil Ringnalda <phil.ccpl@gmail.com> --- Still present in master. How about the example from bug 5844, which fixed the copy of jquery.highlight-3.js in koha-tmpl/opac-tmpl/ but not the copy in koha-tmpl/intranet-tmpl/, "mag ma m"? All that's actually needed is to patch the intranet-tmpl copy the same way. I don't quite see how an example can actually work, unless there's some standard set of bib records everyone has that I haven't yet run across documentation of, though. Before I realized why it only happens in the staff client, I was drafting a set of steps to reproduce that were going to start with "Create a bib record with the title A is for apple and another with the title A my name is Anna" since reproducing requires only that you have a search which in your database will return two or more records and will have matches in things which are displayed in the staff client search results list. "a a" is actually a pretty good example since as long as you have two (or more) records in your database which contain the letter "a" in any indexed field, you will have highlights that will show the letter being removed from the DOM in the words "Material" and "Format" and "Literary" in the line "Material type: Book Format: print Literary form: Not fiction" even if you don't have highlights in the author or title. Might still fail for a non-English install, but otherwise it seems like the most likely to work in any install with any bib records. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 --- Comment #5 from Phil Ringnalda <phil@chetcolibrary.org> --- Created attachment 103210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103210&action=edit Bug 20501: Don't cut strings when unhighlighting in intranet search results When you click Unhighlight on the search results of a search in the staff client when the search terms contain the same word twice, like "ma ma", the highlighted words disappear, and don't reappear if you click Highlight. This patch makes the same change to the intranet copy of jquery.highlight-3.js that bug 5844 made to the OPAC copy. Test plan: 1) Without this patch, search in the intranet for ma ma and verify you have at least two matching records. 2) Notice that the Ma in Material type: Book is highlighted. 3) Click Unhighlight, and notice that it has become terial type: Book 4) Apply this patch, repeat the search with a shift+reload to reload the .js 5) Click Unhighlight, and verify that Material type: Book remains Material -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #103210|0 |1 is obsolete| | --- Comment #6 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 103319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103319&action=edit Bug 20501: Don't cut strings when unhighlighting in intranet search results When you click Unhighlight on the search results of a search in the staff client when the search terms contain the same word twice, like "ma ma", the highlighted words disappear, and don't reappear if you click Highlight. This patch makes the same change to the intranet copy of jquery.highlight-3.js that bug 5844 made to the OPAC copy. Test plan: 1) Without this patch, search in the intranet for ma ma and verify you have at least two matching records. 2) Notice that the Ma in Material type: Book is highlighted. 3) Click Unhighlight, and notice that it has become terial type: Book 4) Apply this patch, repeat the search with a shift+reload to reload the .js 5) Click Unhighlight, and verify that Material type: Book remains Material Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> Work as described, no errors. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com QA Contact|testopia@bugs.koha-communit |josef.moravec@gmail.com |y.org | Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20501 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable Version(s)|20.05.00, 19.11.06 |20.05.00, 19.11.06, released in| |19.05.11 CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 19.05.x for 19.05.11 -- You are receiving this mail because: You are watching all bug changes.