[Bug 22534] New: Add ability to choose which fields are copied from guarantor to guarantee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Bug ID: 22534 Summary: Add ability to choose which fields are copied from guarantor to guarantee Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: genevieve.beaudry@inlibro.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Target Milestone: --- When linking a guarantee to a guarantor, some fields are automatically copied, such as the address, the phone number, etc. I suggest that a system preference be added so that the system administration can choose which fields they want to be copied. By default, it can stay address and phone number, but they would have the possibility to remove those. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Oops, I reported this. I just forgot to log out of Geneviève's bz account first. Sorry! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |alexbuckley@catalyst.net.nz |ity.org | CC| |alexbuckley@catalyst.net.nz Status|NEW |ASSIGNED --- Comment #2 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Caroline, This sounds like a really great enhancement. I'd love to work on this. Thanks, Alex -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #3 from Alex Buckley <alexbuckley@catalyst.net.nz> --- *** Bug 24942 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #4 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 101499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101499&action=edit Bug 22534: Added syspref for defining what guarantee fields are pre filled Librarians should be able to define what fields in 'Main address', 'Contact' and 'Alternate contact' in member entry form for guarantee's are pre-filled from guarantor's record The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields in the 'Contact' section should not be filled from guarantor patron record as those fields are intended for guarantor's without patron records in Koha. Test plan: 1. On an adult patron's record (which has all fields filled out in the 'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor first name', and 'relationship')) select 'Add guarantee' 2. Observe: * Fields in 'Main address' are all automatically pre-filled from guarantor record * Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname' and 'relationship') are all automatically pre-filled from guarantor record * None of the fields in 'Alternate contact' are pre-filled from guarantor 4. Apply patch 5. Run database updates cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 6. Go to Administration > Global system preferences and search for the new PrefillGuaranteeField system preference 7. Observe this syspref is empty 8. Repeat step 1 and observe none of the fields in 'Main address' , 'Contact' or 'Alternate address' are prefilled from guarantor 9. Add the following content into PrefillGuaranteeField syspref and save: phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone 10. Repeat step 1 and observe all fields in 'Main address', 'Alternate contact', and (except 'Guarantor surname', 'Guarantor first name', and 'relationship') in 'Contact' are pre-filled from guarantor 11. Change a few of the prefilled field values and 'Save' and observe your changes have been saved as have the values you haven't altered 12. Amend PrefillGuaranteeField syspref to be: phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|drfregfre|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone (Note: Have added a invalid column field 'drfregfre') 13. Repeat step 1 and observe no internal server errors and all fields listed in step 10 are still pre-filled 14. Amend PrefillGuarantee field syspref to be: phone|phonepro|mobile|email|contactfirstname|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone (Note: Have added contactfirstname which is what the 'Guarantor first name' field in 'Contact' section of member entry form is) 15. Repeat step 1 and observe all fields defined in step 10 are filled and 'Guarantor first name' is not filled even though it was listed in PrefillGuarantorField because contactfirstname (along with contactsurname and relationship are meant for non Koha patrons and so should not pre-fill from a Koha patron) 16. Run tests: sudo koha-shell <instancename> prove xt prove t Sponsored-by: Waitaki Distict Council, NZ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Change sponsored?|--- |Sponsored See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23808 --- Comment #5 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi all, Patch finished. Please test when you are able to and let me know what you think :) Cheers, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101499|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #6 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 101501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101501&action=edit Bug 22534: Added syspref for defining what guarantee fields are pre filled Librarians should be able to define what fields in 'Main address', 'Contact' and 'Alternate contact' in member entry form for guarantee's are pre-filled from guarantor's record The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields in the 'Contact' section should not be filled from guarantor patron record as those fields are intended for guarantor's without patron records in Koha. Test plan: 1. On an adult patron's record (which has all fields filled out in the 'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor first name', and 'relationship')) select 'Add guarantee' 2. Observe: * Fields in 'Main address' are all automatically pre-filled from guarantor record * Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname' and 'relationship') are all automatically pre-filled from guarantor record * None of the fields in 'Alternate contact' are pre-filled from guarantor 4. Apply patch 5. Run database updates cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 6. Go to Administration > Global system preferences and search for the new PrefillGuaranteeField system preference 7. Observe this syspref containing the following: phone|email|streetnumber|address|city|state|zipcode|country 8. Repeat step 1 and observe the following fields are prefilled from guarantor: streetnumber address city state zipcode/postal code country Primary phone Primary email 9. Add the following content into PrefillGuaranteeField syspref and save: phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone 10. Repeat step 1 and observe all fields in 'Main address', 'Alternate contact', and (except 'Guarantor surname', 'Guarantor first name', and 'relationship') in 'Contact' are pre-filled from guarantor 11. Change a few of the prefilled field values and 'Save' and observe your changes have been saved as have the values you haven't altered 12. Amend PrefillGuaranteeField syspref to be: phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|drfregfre|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone (Note: Have added a invalid column field 'drfregfre') 13. Repeat step 1 and observe no internal server errors and all fields listed in step 10 are still pre-filled 14. Amend PrefillGuarantee field syspref to be: phone|phonepro|mobile|email|contactfirstname|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone (Note: Have added contactfirstname which is what the 'Guarantor first name' field in 'Contact' section of member entry form is) 15. Repeat step 1 and observe all fields defined in step 10 are filled and 'Guarantor first name' is not filled even though it was listed in PrefillGuarantorField because contactfirstname (along with contactsurname and relationship are meant for non Koha patrons and so should not pre-fill from a Koha patron) 16. Run tests: sudo koha-shell <instancename> prove xt prove t Sponsored-by: Waitaki Distict Council, NZ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #7 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Sorry I had missed in my test plan that the new PrefillGuaranteeField syspref has the default value of phone|email|streetnumber|address|city|state|zipcode|country Which was suggested as defaults in the description of this bug report. All ready to test :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101501|0 |1 is obsolete| | --- Comment #8 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 101563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101563&action=edit Bug 22534: Added syspref for defining what guarantee fields are pre filled Librarians should be able to define what fields in 'Main address', 'Contact' and 'Alternate contact' in member entry form for guarantee's are pre-filled from guarantor's record The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields in the 'Contact' section should not be filled from guarantor patron record as those fields are intended for guarantor's without patron records in Koha. Test plan: 1. On an adult patron's record (which has all fields filled out in the 'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor first name', and 'relationship')) select 'Add guarantee' 2. Observe: * Fields in 'Main address' are all automatically pre-filled from guarantor record * Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname' and 'relationship') are all automatically pre-filled from guarantor record * None of the fields in 'Alternate contact' are pre-filled from guarantor 4. Apply patch 5. Run database updates cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 6. Go to Administration > Global system preferences and search for the new PrefillGuaranteeField system preference 7. Observe this syspref containing the following: phone|email|streetnumber|address|city|state|zipcode|country 8. Repeat step 1 and observe the following fields are prefilled from guarantor: streetnumber address city state zipcode/postal code country Primary phone Primary email 9. Add the following content into PrefillGuaranteeField syspref and save: phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone 10. Repeat step 1 and observe all fields in 'Main address', 'Alternate contact', and (except 'Guarantor surname', 'Guarantor first name', and 'relationship') in 'Contact' are pre-filled from guarantor 11. Change a few of the prefilled field values and 'Save' and observe your changes have been saved as have the values you haven't altered 12. Amend PrefillGuaranteeField syspref to be: phone|phonepro|mobile|email|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|drfregfre|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone (Note: Have added a invalid column field 'drfregfre') 13. Repeat step 1 and observe no internal server errors and all fields listed in step 10 are still pre-filled 14. Amend PrefillGuarantee field syspref to be: phone|phonepro|mobile|email|contactfirstname|emailpro|fax|streetnumber|address|address2|city|state|zipcode|country|altcontactfirstname|altcontactsurname|altcontactaddress1|altcontactaddress2|altcontactaddress3|altcontactstate|altcontactzipcode|altcontactcountry|altcontactphone (Note: Have added contactfirstname which is what the 'Guarantor first name' field in 'Contact' section of member entry form is) 15. Repeat step 1 and observe all fields defined in step 10 are filled and 'Guarantor first name' is not filled even though it was listed in PrefillGuarantorField because contactfirstname (along with contactsurname and relationship are meant for non Koha patrons and so should not pre-fill from a Koha patron) 16. Run tests: sudo koha-shell <instancename> prove xt prove t Sponsored-by: Waitaki Distict Council, NZ Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey@cheshireshared | |services.gov.uk --- Comment #9 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- I've tested 1-15 on a sandbox and it works well. If someone else could test 16, then I'm happy to add my sign off line to the patch: 16. Run tests: sudo koha-shell <instancename> prove xt prove t -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Sally from comment #9)
I've tested 1-15 on a sandbox and it works well.
If someone else could test 16, then I'm happy to add my sign off line to the patch:
16. Run tests: sudo koha-shell <instancename> prove xt prove t
Hi Sally, don't worry about those, we will cover tests during QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Sally <sally.healey@cheshiresharedservices.gov.uk> --- Ah brilliant, thanks for letting me know, Katrin! :) I've updated the status to Signed Off. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Alex, I do not understand the test plan, why do you suggest having both altcontactphone and phone in the pref? You should use the multiple options, like for CollapseFieldsPatronAddForm. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #13 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi Jonathan, Thanks for your question/suggestion. I added both altcontactphone and phone simply to illustrate that all fields (in Main address, contact, alternate address, and alternate contact) could be filled. So if a librarian wanted the main phone field to be filled from guarantor record they could but they could equally choose to fill altcontactphone instead - both of those fields will be filled if entered into the syspref. I'll make the changes you mentioned now Thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #14 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Hi all, I've amended my patch. I realised I was incorrectly assigning guatantors main address and guarantor contact fields directly into guarantee alternate address and alternate contact. In my new patch the pre-filling mapping is: guarantor:main address = guarantee:main address guarantor:contact = guarantee:contact guarantor:Alternate address = guarantee:Alternate address guarantor:Alternate contact = guarantee:Alternate contact I've also changed the syspref to be 'multiple' like you requested Jonathan. I've listed individual fields (ordered alphabetically based on the displayed text) in the PrefillGuaranteeField rather than sections of the member entry form like in CollapseFieldsPatronAddForm this is to give librarians more granulated control if they want to pre-fill some but not all fields in 'contact' section of member entry form for example. As I have changed the syspref quite significantly I'll need to obsolete the patch on this ticket already tested otherwise I'd have to make another atomicupdate to UPDATE the syspref. Could you please re-test Sally (or anyone else interested to do so)? Many thanks, Alex -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #101563|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #15 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Created attachment 102097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102097&action=edit Bug 22534: Added syspref for defining what guarantee fields are pre filled Librarians should be able to define what sections in member entryfields in 'Main address', 'Contact' and 'Alternate contact' in member entry form for guarantee's are pre-filled from guarantor's record The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields in the 'Contact' section should not be filled from guarantor patron record as those fields are intended for guarantor's without patron records in Koha. Test plan: 1. On an adult patron's record (which has all fields filled out in the 'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor first name', and 'relationship'), 'Alternate address', and 'Alternate contact') select 'Add guarantee' 2. Observe: * Fields in 'Main address' are all automatically pre-filled from guarantor record * Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname' and 'relationship') are all automatically pre-filled from guarantor record * Fields in 'Alternate address' (except for Contact note) are pre-filled from guarantor record * None of the fields in 'Alternate contact' are pre-filled from guarantor 4. Apply patch 5. Run database updates cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 6. Restart plack: sudo koha-plack --restart <instancename> 7. Go to Administration > Global system preferences and search for the new PrefillGuaranteeField system preference 8. Observe this syspref contains checkboxes and the following are selected by default: Contact - Primary email Contact - Primary phone Main address - Address Main address - City Main address - Country Main address - State Main address - ZIP/Postal code Main address - street number Please note: 'Contact - Guarantor surname', 'Contact - Guarantor first name', Contact - relationship' are not in PrefillGuaranteeField syspref as they are for non Koha patrons and so should not be pre-filled from a Koha patron. 9. Repeat step 1 and observe the following fields are prefilled from guarantor: In Main address section - streetnumber address city state zipcode/postal code country In Contact section - Primary phone Primary email 10. In the PrefillGuaranteeField syspref click '[Select all]' checkboxes 11. Repeat step 1 and observe all fields in 'Main address', 'Contact' (except Guarantor surname, Guarantor first name, and relationship), Alternate address and Alterate contact are filled from guarantor record. i.e. The values in guarantor's 'Alternate address' fields fill the guarantee's 'Alternate address' fields 12. Change a few of the prefilled field values and 'Save' and observe your changes have been saved in addition to the unaltered pre-filled values in other fields 13. Amend PrefillGuarantee field syspref to have no checkboxes selected 14. Repeat step 1 and observe none of the fields in Main address, Contact, Alternate address and Alternate contact are pre-filled 15. Run tests: sudo koha-shell <instancename> prove xt prove t Sponsored-by: Waitaki Distict Council, NZ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Alex Buckley <alexbuckley@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102097|0 |1 is obsolete| | --- Comment #16 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 102124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102124&action=edit Bug 22534: Added syspref for defining what guarantee fields are pre filled Librarians should be able to define what sections in member entryfields in 'Main address', 'Contact' and 'Alternate contact' in member entry form for guarantee's are pre-filled from guarantor's record The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields in the 'Contact' section should not be filled from guarantor patron record as those fields are intended for guarantor's without patron records in Koha. Test plan: 1. On an adult patron's record (which has all fields filled out in the 'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor first name', and 'relationship'), 'Alternate address', and 'Alternate contact') select 'Add guarantee' 2. Observe: * Fields in 'Main address' are all automatically pre-filled from guarantor record * Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname' and 'relationship') are all automatically pre-filled from guarantor record * Fields in 'Alternate address' (except for Contact note) are pre-filled from guarantor record * None of the fields in 'Alternate contact' are pre-filled from guarantor 4. Apply patch 5. Run database updates cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 6. Restart plack: sudo koha-plack --restart <instancename> 7. Go to Administration > Global system preferences and search for the new PrefillGuaranteeField system preference 8. Observe this syspref contains checkboxes and the following are selected by default: Contact - Primary email Contact - Primary phone Main address - Address Main address - City Main address - Country Main address - State Main address - ZIP/Postal code Main address - street number Please note: 'Contact - Guarantor surname', 'Contact - Guarantor first name', Contact - relationship' are not in PrefillGuaranteeField syspref as they are for non Koha patrons and so should not be pre-filled from a Koha patron. 9. Repeat step 1 and observe the following fields are prefilled from guarantor: In Main address section - streetnumber address city state zipcode/postal code country In Contact section - Primary phone Primary email 10. In the PrefillGuaranteeField syspref click '[Select all]' checkboxes 11. Repeat step 1 and observe all fields in 'Main address', 'Contact' (except Guarantor surname, Guarantor first name, and relationship), Alternate address and Alterate contact are filled from guarantor record. i.e. The values in guarantor's 'Alternate address' fields fill the guarantee's 'Alternate address' fields 12. Change a few of the prefilled field values and 'Save' and observe your changes have been saved in addition to the unaltered pre-filled values in other fields 13. Amend PrefillGuarantee field syspref to have no checkboxes selected 14. Repeat step 1 and observe none of the fields in Main address, Contact, Alternate address and Alternate contact are pre-filled 15. Run tests: sudo koha-shell <instancename> prove xt prove t Sponsored-by: Waitaki Distict Council, NZ Signed-off-by: Sally <sally.healey@cheshiresharedservices.go.uk> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Sally <sally.healey@cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #102124|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102126&action=edit Bug 22534: Added syspref for defining what guarantee fields are pre filled Librarians should be able to define what sections in member entryfields in 'Main address', 'Contact' and 'Alternate contact' in member entry form for guarantee's are pre-filled from guarantor's record The 'Guarantor surname, 'Guarantor first name' and 'relationship' fields in the 'Contact' section should not be filled from guarantor patron record as those fields are intended for guarantor's without patron records in Koha. Test plan: 1. On an adult patron's record (which has all fields filled out in the 'Main address', 'Contact' (Except for 'Guarantor surname', 'Guarantor first name', and 'relationship'), 'Alternate address', and 'Alternate contact') select 'Add guarantee' 2. Observe: * Fields in 'Main address' are all automatically pre-filled from guarantor record * Fields in 'Contact' (except 'Guarantor surname', 'Guarantor firstname' and 'relationship') are all automatically pre-filled from guarantor record * Fields in 'Alternate address' (except for Contact note) are pre-filled from guarantor record * None of the fields in 'Alternate contact' are pre-filled from guarantor 4. Apply patch 5. Run database updates cd installer/data/mysql sudo koha-shell <instancename> ./updatedatabase.pl 6. Restart plack: sudo koha-plack --restart <instancename> 7. Go to Administration > Global system preferences and search for the new PrefillGuaranteeField system preference 8. Observe this syspref contains checkboxes and the following are selected by default: Contact - Primary email Contact - Primary phone Main address - Address Main address - City Main address - Country Main address - State Main address - ZIP/Postal code Main address - street number Please note: 'Contact - Guarantor surname', 'Contact - Guarantor first name', Contact - relationship' are not in PrefillGuaranteeField syspref as they are for non Koha patrons and so should not be pre-filled from a Koha patron. 9. Repeat step 1 and observe the following fields are prefilled from guarantor: In Main address section - streetnumber address city state zipcode/postal code country In Contact section - Primary phone Primary email 10. In the PrefillGuaranteeField syspref click '[Select all]' checkboxes 11. Repeat step 1 and observe all fields in 'Main address', 'Contact' (except Guarantor surname, Guarantor first name, and relationship), Alternate address and Alterate contact are filled from guarantor record. i.e. The values in guarantor's 'Alternate address' fields fill the guarantee's 'Alternate address' fields 12. Change a few of the prefilled field values and 'Save' and observe your changes have been saved in addition to the unaltered pre-filled values in other fields 13. Amend PrefillGuarantee field syspref to have no checkboxes selected 14. Repeat step 1 and observe none of the fields in Main address, Contact, Alternate address and Alternate contact are pre-filled 15. Run tests: sudo koha-shell <instancename> prove xt prove t Sponsored-by: Waitaki Distict Council, NZ Signed-off-by: Sally <sally.healey@cheshiresharedservices.go.uk> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #18 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work everyone! Pushed to master for 20.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #19 from Alex Buckley <alexbuckley@catalyst.net.nz> --- Many thanks everyone! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 --- Comment #20 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 102919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=102919&action=edit Bug 22534: (RM follow-up) Remove errant hidden file An nfs share file got commited by mistake :( Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Joy Nelson <joy@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy@bywatersolutions.com --- Comment #21 from Joy Nelson <joy@bywatersolutions.com> --- enhancement not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |A new system preference release notes| |PrefillGuaranteeField | |allows to configure which | |fields from the guarantor's | |patron record will be | |copied to the guarantees | |record when the link | |between the accounts is | |created. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|A new system preference |This enhancement allows release notes|PrefillGuaranteeField |administrators to configure |allows to configure which |which fields from the |fields from the guarantor's |guarantor's patron record |patron record will be |will be copied to the |copied to the guarantees |guarantees record when the |record when the link |link between the accounts |between the accounts is |is created. |created. | | |**New system | |preference**: | |`PrefillGuaranteeField` | |defaults to | |`phone,email,streetnumber,a | |ddress,city,state,zipcode,c | |ountry`. CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |23808 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23808 [Bug 23808] Creating Child Guarantee doesn't populate Guarantor Information -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Didier Gautheron <didier.gautheron@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29576 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29576 [Bug 29576] Add streetype to fields which can be copied from guarantor to guarantee -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org