[Bug 16484] New: Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Bug ID: 16484 Summary: Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Lists Assignee: gmcharlt@gmail.com Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Similar to bug 16296 but on the staff side -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16296 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 51354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51354&action=edit Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet To test: 1 - Create a list in staff client 2 - Set XSLTResultsDisplay to blank 3 - View list, titles don't display 4 - Apply patch 5 - View list, titles display 6 - Set XSLTResultsDisplay to default 7 - View list, titles display as before patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51354|0 |1 is obsolete| | --- Comment #2 from Marc Véron <veron@veron.ch> --- Created attachment 51375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51375&action=edit Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet To test: 1 - Create a list in staff client 2 - Set XSLTResultsDisplay to blank 3 - View list, titles don't display 4 - Apply patch 5 - View list, titles display 6 - Set XSLTResultsDisplay to default 7 - View list, titles display as before patch Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Virtualshelves: Using no |Virtualshelves: Using no |XSLTResultsDisplay breaks |XSLTResultsDisplay breaks |content display in intranet |content display in intranet | |(titles not showing in | |lists) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- opac-shelves.pl and virtualshelves/shelves.pl have diverged in this area. The OPAC script calls GetBiblioData, which populated title and other infos. It would make sense to add the call to the staff script to avoid different behaviors between these 2 scripts. The eternal question is: should we continue to fix non-XSLT views? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #51375|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 51634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51634&action=edit Bug 16484 - Virtualshelves: Using no XSLTResultsDisplay breaks content display in intranet To test: 1 - Create a list in staff client 2 - Set XSLTResultsDisplay to blank 3 - View list, titles don't display 4 - Apply patch 5 - View list, titles display 6 - Set XSLTResultsDisplay to default 7 - View list, titles display as before patch Signed-off-by: Marc Veron <veron@veron.ch> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |m.de.rooy@rijksmuseum.nl |y.org | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3)
The eternal question is: should we continue to fix non-XSLT views? :)
If we deprecate something, we should make more definitive plans to remove the functionality too imo. Since this is just a one-line fix restoring something very fundamental as the title of a book, I would recommend to push it. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Did you see my other concern about the divergence of the 2 files? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 --- Comment #7 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6)
Did you see my other concern about the divergence of the 2 files? Yes. These scripts should not contain so much logic.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #6)
Did you see my other concern about the divergence of the 2 files?
I know it was not introduced by this patch, but it would be good to fix it (even on another bug report). But... it would be easiest to remove the code than to fix it... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 --- Comment #9 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8)
(In reply to Jonathan Druart from comment #6)
Did you see my other concern about the divergence of the 2 files?
I know it was not introduced by this patch, but it would be good to fix it (even on another bug report). But... it would be easiest to remove the code than to fix it...
I would recommend now to build on top of this one liner (tested etc.) New adjustments will not reach 16.05 anymore. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |kyle@bywatersolutions.com --- Comment #10 from Kyle M Hall <kyle@bywatersolutions.com> --- Pushed to master for 16.05, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16484 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |julian.maurice@biblibre.com --- Comment #11 from Julian Maurice <julian.maurice@biblibre.com> --- Patch pushed to 3.22.x, will be in 3.22.7 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org