https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|CSS regression |CSS regression: white gap | |on the top of the staff | |pages -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #1 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Comes from staff-global.css : .main { margin-top: 1em; } main class is on body in intranet-main.tt. It is usually in : <div class="main container-fluid"> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 72310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72310&action=edit Bug 20268: CSS regression: white gap on the top of the staff pages This patch makes template and CSS changes so that the staff client main page doesn't get an unwanted top margin from the Bootstrap-grid conversion. - The unused "main" class is removed from the login page - The "main" class on the staff client home page is changed to "intranet-main." - The CSS for the staff client home page has been modified accordingly. To test, apply the patch and clear your browser cache if necessary. - Open the staff client login page. It should look as it always does. - Log in and check the style of the main page. There should be no white margin at the top of the page. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72310|0 |1 is obsolete| | --- Comment #4 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 72339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72339&action=edit Bug 20268: CSS regression: white gap on the top of the staff pages This patch makes template and CSS changes so that the staff client main page doesn't get an unwanted top margin from the Bootstrap-grid conversion. - The unused "main" class is removed from the login page - The "main" class on the staff client home page is changed to "intranet-main." - The CSS for the staff client home page has been modified accordingly. To test, apply the patch and clear your browser cache if necessary. - Open the staff client login page. It should look as it always does. - Log in and check the style of the main page. There should be no white margin at the top of the page. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72339|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 72344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72344&action=edit Bug 20268: CSS regression: white gap on the top of the staff pages This patch makes template and CSS changes so that the staff client main page doesn't get an unwanted top margin from the Bootstrap-grid conversion. - The unused "main" class is removed from the login page - The "main" class on the staff client home page is changed to "intranet-main." - The CSS for the staff client home page has been modified accordingly. To test, apply the patch and clear your browser cache if necessary. - Open the staff client login page. It should look as it always does. - Log in and check the style of the main page. There should be no white margin at the top of the page. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley@catalyst.net.nz --- Comment #6 from Claire Gravely <claire_gravely@hotmail.com> --- *** Bug 20328 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- A test is failing, please fix ASAP: xt/tt_valid.t .. 1/3 # Failed test '<body> tag with id and class attributes' # at xt/tt_valid.t line 91. # Files list: # intranet-tmpl/prog/en/modules/auth.tt: 15 https://jenkins.koha-community.org/job/Koha_Master_D8/398/ -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19981 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19981 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 [Bug 19981] Switch single-column templates to Bootstrap grid: Course reserves -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.