[Bug 19981] New: Switch single-column templates to Bootstrap grid: Course reserves
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Bug ID: 19981 Summary: Switch single-column templates to Bootstrap grid: Course reserves Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: dcook@prosentient.com.au, josef.moravec@gmail.com, misilot@fit.edu, nengard@gmail.com, testopia@bugs.koha-community.org Blocks: 14546, 19980 There are three single-column templates in the Course Reserves module which can be updated to use Bootstrap: course-details.tt course-reserves.tt invalid-course.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client templates responsive https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70557&action=edit Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves This patch updates three single-column course reserves templates to use the Bootstrap grid: - course-reserves.tt - The main Course Reserves page - course-details.tt - The detail view of an individual course - invalid-course.tt - The error page shown if you try to view course_reserves/course-details.pl directly without passing a course id in the URL - Also changed in this template: Error message has been wrapped in the standard "dialog alert" <div>. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Missed: course.tt add_items-step1.tt add_items-step2.tt -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70557|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 70559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70559&action=edit Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves This patch updates three single-column course reserves templates to use the Bootstrap grid: - course-reserves.tt - The main Course Reserves page - course-details.tt - The detail view of an individual course - course.tt - Editing a course - add_items-step1.tt - Adding items to a course, step 1 (scan barcode) - add_items-step2.tt - Adding items to a course, step 2 - invalid-course.tt - The error page shown if you try to view course_reserves/course-details.pl directly without passing a course id in the URL - Also changed in this template: Error message has been wrapped in the standard "dialog alert" <div>. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- *** Bug 19848 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Claire Gravely <claire_gravely@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #70559|0 |1 is obsolete| | --- Comment #5 from Claire Gravely <claire_gravely@hotmail.com> --- Created attachment 71711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71711&action=edit Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves This patch updates three single-column course reserves templates to use the Bootstrap grid: - course-reserves.tt - The main Course Reserves page - course-details.tt - The detail view of an individual course - course.tt - Editing a course - add_items-step1.tt - Adding items to a course, step 1 (scan barcode) - add_items-step2.tt - Adding items to a course, step 2 - invalid-course.tt - The error page shown if you try to view course_reserves/course-details.pl directly without passing a course id in the URL - Also changed in this template: Error message has been wrapped in the standard "dialog alert" <div>. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #71711|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 71907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71907&action=edit Bug 19981: Switch single-column templates to Bootstrap grid: Course reserves This patch updates three single-column course reserves templates to use the Bootstrap grid: - course-reserves.tt - The main Course Reserves page - course-details.tt - The detail view of an individual course - course.tt - Editing a course - add_items-step1.tt - Adding items to a course, step 1 (scan barcode) - add_items-step2.tt - Adding items to a course, step 2 - invalid-course.tt - The error page shown if you try to view course_reserves/course-details.pl directly without passing a course id in the URL - Also changed in this template: Error message has been wrapped in the standard "dialog alert" <div>. Each of these pages should look correct, with a single centered column with wide margins on either side. At lower browser widths the margins should disappear. Signed-off-by: Claire Gravely <claire.gravely@bsz-bw.de> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Victor Grousset/tuxayo <victor.grousset@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20268 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Nick Clemens <nick@bywatersolutions.com> --- Enhancement, not backported for 17.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19981 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20268 See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20268 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20268 [Bug 20268] CSS regression: white gap on the top of the staff pages -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org