[Bug 15883] New: Upgrade jQuery from v1.7.2 in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Bug ID: 15883 Summary: Upgrade jQuery from v1.7.2 in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Blocks: 14546 In order to upgrade Bootstrap in the staff client we first need to upgrade jQuery. After discussing it some in IRC (http://irc.koha-community.org/koha/2016-02-22#i_1791968), this is the plan I'm working on right now: An initial patch will start by adding the basis for upgrades: 1. Add a new version of doc-head-close.inc which includes new version of jQuery and jQueryUI. That include file will be named doc-head-close-jquery.1.12.0.inc to reflect the version of jQuery it uses. 2. Add the 1.12.0 version of jQuery, naming the file jquery-1.12.0.min.js 3. Add the latest version of jQueryUI, 1.11.4, naming the files jquery-ui-1.11.4.js and jquery-ui-1.11.4.min.css. Subsequent patches can take a page-by-page approach to the upgrade, dropping in the new include file and making any upgrades necessary to Javascript on that page. As compatibility issues are discovered, affected JS files can be re-created with updated file names to reflect the jQuery version, as in "basket-jquery-1.12.0.js" Disadvantages to this method: 1. It's possible some patches will have to touch both doc-head-close.inc and doc-head-close-jquery.1.12.0.inc. However that file changes fairly seldom. 2. git history getting lost between files. Can it be done so that the new include file keeps the history of doc-head-close.inc and doc-head-close.inc is created as if it is the new file? Eventually it could be removed. I would like to hear opinions and suggestions about this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 [Bug 14546] Make staff client use Bootstrap -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Chris Nighswonger <cnighswonger@foundations.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |cnighswonger@foundations.ed | |u --- Comment #1 from Chris Nighswonger <cnighswonger@foundations.edu> --- (In reply to Owen Leonard from comment #0)
An initial patch will start by adding the basis for upgrades:
1. Add a new version of doc-head-close.inc which includes new version of jQuery and jQueryUI. That include file will be named doc-head-close-jquery.1.12.0.inc to reflect the version of jQuery it uses.
Just for clarification: Is this nomenclature intended to be permanent or is this just temporary until everything is upgraded?
2. git history getting lost between files. Can it be done so that the new include file keeps the history of doc-head-close.inc and doc-head-close.inc is created as if it is the new file? Eventually it could be removed.
Assuming we will eventually return to the doc-head-close.inc nomenclature, why wouldn't we just overwrite the original doc-head-close.inc with the new doc-head-close-jquery.1.12.0.inc at the appropriate time and let git handle is as one big diff? This would preserve the history and it should be obvious in the log and patch what was done. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #2 from Chris Nighswonger <cnighswonger@foundations.edu> --- By overwrite, I mean contents, of course. The name would remain doc-head-close.inc which should preserve the git history I think. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Chris Nighswonger from comment #1)
Just for clarification: Is this nomenclature intended to be permanent or is this just temporary until everything is upgraded?
Theoretically temporary I guess. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 48457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48457&action=edit Bug 15883 - Upgrade jQuery from v1.7.2 in the staff client This patch adds jQuery 1.12.0 and jQueryUI 1.11.4 to the staff client. It adds a new version of doc-head-close.inc, doc-head-close-jquery-1.12.0.inc, to be included on pages which have been tested with the new versions of jQuery and jQueryUI. This patch changes only one template to use the new include file, intranet-main.tt, as a proof of concept. To test, apply the patch and view the staff client home page. Any feature on the page which uses JavaScript should be tested: - Dropdown menus like "More" and the user menu. - Header search form tabs, and the preservation of search form text during tab switching. - The "Help" link popup. - Cart functionality -- Confirm that an clicking the "Cart" link when empty shows you the correct message. -- After adding titles to the Cart, return to the home page and confirm that the count of items in the Cart is correct. -- Confirm that clicking the "Cart" link triggers the Cart popup. -- In the Cart popup, click "Empty and close" and confirm that the "Cart" link now shows "(0)" as the count. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- (In reply to Owen Leonard from comment #3)
(In reply to Chris Nighswonger from comment #1)
Just for clarification: Is this nomenclature intended to be permanent or is this just temporary until everything is upgraded?
Theoretically temporary I guess.
I'd prefer the contrary: update all existing occurrences of [% INCLUDE 'doc-head-close.inc' %] with [% INCLUDE 'doc-head-close.old.inc' %] # s/old/whatever I can provide a follow-up if you agree. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #6 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)
I'd prefer the contrary: update all existing occurrences of [% INCLUDE 'doc-head-close.inc' %] with [% INCLUDE 'doc-head-close.old.inc' %] # s/old/whatever
That's fine with me. I wonder if the name of the "old" include should reflect the version? I'm concerned that we are going to end up with doc-head-close.old.inc, doc-head-close.older.inc, and doc-head-close.even-older.inc if newer jQuery upgrades start getting added before the last upgrade is complete! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com Status|Needs Signoff |Failed QA --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- There is a small conflict Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt Failed to merge in the changes. Solving that we got: Software error: Template process failed: file error - searchbox-keep-text.inc: not found at /home/bgkriegel/kohaclone/C4/Templates.pm line 119 Where is 'searchbox-keep-text.inc'? BTW, have you an agreement on file names, i.e. jquery-ver vs. old/older? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Jonathan Druart from comment #5)
I'd prefer the contrary: update all existing occurrences of [% INCLUDE 'doc-head-close.inc' %] with [% INCLUDE 'doc-head-close.old.inc' %] # s/old/whatever
Looking at this again... Part of the intention of my original plan was to not have to modify hundreds of files at once. That's going to create lots of problems for pending patches isn't it? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #9 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- I'd prefer to keep the jquery.js pointing on the newest version. Do you know how big is the work to move to jQuery v1.12? What if we brutally update all the templates to use the new version and fix them when we find bugs? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #10 from Owen Leonard <oleonard@myacpl.org> --- I think there is no benefit to having a file called "jquery.js" which is of unknown (or at least non-obvious) version. History has shown that we are bad at keeping jQuery updated, so it would not be long before it wasn't the newest version. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #11 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 50087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50087&action=edit Bug 15883 - Upgrade jQuery from v1.7.2 in the staff client This patch updates the staff client version of jQuery to 2.2.3. In order to maintain compatibility with existing scripts, the jQuery migrate plugin has also been added. Included is the development version of the jQuery migrate plugin. Developers could modify doc-head-close.inc to use this version if they wanted to take advantage of its upgrade warning log. To test, apply the patch and test JavaScript interactions everywhere in the staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #48457|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #12 from Owen Leonard <oleonard@myacpl.org> --- Note that jQuery 2.2.3 does not support Internet Explorer 6, 7, or 8. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice@biblibre.com --- Comment #13 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Owen Leonard from comment #12)
Note that jQuery 2.2.3 does not support Internet Explorer 6, 7, or 8.
As well as Microsoft: https://www.microsoft.com/en-us/WindowsForBusiness/End-of-IE-support, so not a big issue I think. In fact, only IE 11 is supported by Microsoft -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 jdemuth@roseville.ca.us <jdemuth@roseville.ca.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jdemuth@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #14 from Julian Maurice <julian.maurice@biblibre.com> --- I applied the patch and went to several places in the staff client (search, circulation, patrons, serials, admin, reports, tools, ...). No issues so far, not even a warning from jQuery Migrate. I'll try to do more testing when I have time -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #15 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Julian Maurice from comment #14)
No issues so far, not even a warning from jQuery Migrate.
Thanks for testing. I would expect you to get console log warnings from jQuery Migrate on every page if only from Bootstrap's js. Did you switch from using the production (minified) to the development (unminified) version? I'd love to be able to build in an easy switch for doing that but I don't know how. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #16 from Julian Maurice <julian.maurice@biblibre.com> --- Okay, when using development version of jQuery Migrate I can see some warnings. Maybe we should use that by default, it's only 4K more than the production version, and will force us to fix errors as we see them -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #17 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 50098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50098&action=edit Bug 15883: Use .prop() instead of .attr() for 'checked' According to https://jquery.com/upgrade-guide/1.9/#attr-versus-prop- .attr() is no longer correct to access the checked state of a checkbox. This patch do the following replacements: .attr('checked') => .prop('checked') .attr('checked, '') => .prop('checked', false) .attr('checked, 'checked') => .prop('checked', true) .attr('checked', boolValue) => .prop('checked', boolValue) .removeAttr('checked') => .prop('checked', false) .attr('checked') == 'checked' => .is(':checked') -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #18 from Julian Maurice <julian.maurice@biblibre.com> --- Note that there is still a call to .attr('checked', false) in jquery.dataTables.columnFilter.js I am not sure how we should handle that. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #19 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Julian Maurice from comment #16)
Okay, when using development version of jQuery Migrate I can see some warnings. Maybe we should use that by default
My concern is that the large quantity of warnings might make it difficult for those who are working on their own JavaScript code to debug their work. If my patch seems to work, with the migrate plugin working to prevent compatibility errors, I suggest we work to get that pushed and submit separate follow-up bugs which depend on this one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #20 from Julian Maurice <julian.maurice@biblibre.com> --- (In reply to Owen Leonard from comment #19)
My concern is that the large quantity of warnings might make it difficult for those who are working on their own JavaScript code to debug their work. Yes, this will be annoying, thus forcing us to fix the errors :)
If my patch seems to work, with the migrate plugin working to prevent compatibility errors, I suggest we work to get that pushed and submit separate follow-up bugs which depend on this one. Okay I'll create a separate bug for my patch
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16238 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16238 [Bug 16238] Upgrade jQuery : use .prop() instead of .attr() for 'checked' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50098|0 |1 is obsolete| | --- Comment #21 from Julian Maurice <julian.maurice@biblibre.com> --- Comment on attachment 50098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50098 Bug 15883: Use .prop() instead of .attr() for 'checked' Patch moved to bug 16238 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16239 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16239 [Bug 16239] Upgrade Bootstrap in the staff client -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16241 [Bug 16241] Move staff client CSS out of language directory -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50087|0 |1 is obsolete| | --- Comment #22 from Marc Véron <veron@veron.ch> --- Created attachment 50151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50151&action=edit Bug 15883 - Upgrade jQuery from v1.7.2 in the staff client This patch updates the staff client version of jQuery to 2.2.3. In order to maintain compatibility with existing scripts, the jQuery migrate plugin has also been added. Included is the development version of the jQuery migrate plugin. Developers could modify doc-head-close.inc to use this version if they wanted to take advantage of its upgrade warning log. To test, apply the patch and test JavaScript interactions everywhere in the staff client. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16218 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #23 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Marc, could you detail what you have tested? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Mason James <mtj@kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj@kohaaloha.com --- Comment #24 from Mason James <mtj@kohaaloha.com> --- (In reply to Julian Maurice from comment #18)
Note that there is still a call to .attr('checked', false) in jquery.dataTables.columnFilter.js I am not sure how we should handle that.
Datatables looks to have a version that is built for jQuery 2.x Perhaps upgrading DT will fix this problem https://datatables.net/download/index -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #25 from Marc Véron <veron@veron.ch> --- (In reply to Jonathan Druart from comment #23)
Marc, could you detail what you have tested?
First I used the test plan in comment #4 to verify that the new jQuery version works. Then I went through staff client for ca. 45 min., with JavaScript error console open (in FF). I focused on pages where jQuery is involved, especially pages with tables / column settings etc. After that I added some code to IntranetUserJS (similar to Bug 16218) to display the jQuery version, because I wanted to verify that the new version was included on all pages I opened, and I went again through staff client. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #26 from Mason James <mtj@kohaaloha.com> --- (In reply to Mason James from comment #24)
(In reply to Julian Maurice from comment #18)
Note that there is still a call to .attr('checked', false) in jquery.dataTables.columnFilter.js I am not sure how we should handle that.
Datatables looks to have a version that is built for jQuery 2.x Perhaps upgrading DT will fix this problem
oops, ignore my suggestion. i see 'jquery.dataTables.columnFilter.js' is a plugin https://code.google.com/archive/p/jquery-datatables-column-filter/ -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50151|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50196&action=edit Bug 15883 - Upgrade jQuery from v1.7.2 in the staff client This patch updates the staff client version of jQuery to 2.2.3. In order to maintain compatibility with existing scripts, the jQuery migrate plugin has also been added. Included is the development version of the jQuery migrate plugin. Developers could modify doc-head-close.inc to use this version if they wanted to take advantage of its upgrade warning log. To test, apply the patch and test JavaScript interactions everywhere in the staff client. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50196|0 |1 is obsolete| | --- Comment #28 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50197&action=edit Bug 15883 - Upgrade jQuery from v1.7.2 in the staff client This patch updates the staff client version of jQuery to 2.2.3. In order to maintain compatibility with existing scripts, the jQuery migrate plugin has also been added. Included is the development version of the jQuery migrate plugin. Developers could modify doc-head-close.inc to use this version if they wanted to take advantage of its upgrade warning log. To test, apply the patch and test JavaScript interactions everywhere in the staff client. Signed-off-by: Marc Véron <veron@veron.ch> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #50197|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Created attachment 50198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50198&action=edit Bug 15883 - Upgrade jQuery from v1.7.2 in the staff client This patch updates the staff client version of jQuery to 2.2.3. In order to maintain compatibility with existing scripts, the jQuery migrate plugin has also been added. Included is the development version of the jQuery migrate plugin. Developers could modify doc-head-close.inc to use this version if they wanted to take advantage of its upgrade warning log. To test, apply the patch and test JavaScript interactions everywhere in the staff client. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 --- Comment #30 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Just forgot twice to add my signoff... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Brendan Gallagher <brendan@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |brendan@bywatersolutions.co | |m --- Comment #31 from Brendan Gallagher <brendan@bywatersolutions.com> --- Pushed to Master - Should be in the May 2016 Release. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16321 [Bug 16321] 'Show all details' checkbox triggers JS error after jQuery upgrade -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16328 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16328 | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |16553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16553 [Bug 16553] Incorrect path to jQueryUI file in help template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15883 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |29155 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29155 [Bug 29155] Upgrade jquery version -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org