[Bug 40547] New: Unable to view background job if enable_plugins is 0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Bug ID: 40547 Summary: Unable to view background job if enable_plugins is 0 Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: aleisha@catalyst.net.nz QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To reproduce 1. Set <enable_plugins> in koha-conf.xml to 0 2. Do a batch record modification, or some task that would set off a background job 3. Click to view the job 4. Internal server error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |40033, 39772 --- Comment #1 from David Cook <dcook@prosentient.com.au> --- Oops! This is one of the reasons I don't love method chaining. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 [Bug 39772] Background jobs page lists unknown job types for jobs implemented by plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40033 [Bug 40033] The background jobs page calls GetPlugins incorrectly, resulting in a 500 error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |dcook@prosentient.com.au |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 --- Comment #2 from David Cook <dcook@prosentient.com.au> --- Created attachment 184854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184854&action=edit Bug 40547: Background jobs should appear even when plugins disabled This change fixes the background jobs so that the list page loads even when plugins are disabled. Test plan: 0. Apply the patch 1. Download https://github.com/HKS3/koha-normalize-marc2db/releases/download/v0.91/Koha.... 2. Upload plugin into KTD 3. Click "Run tool" for plugin 4. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 5. Note that you see a pretty "Type" 6. Go to /etc/koha/sites/kohadev/koha-conf.xml and turn enable_plugins to 0 7. sudo koha-plack --restart kohadev 8. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 9. Note it now says "Unknown job type 'plugin_marc2db_normalizeall' 10. Celebrate as this is preferable to a 500 error -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184854|0 |1 is obsolete| | --- Comment #3 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 184918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184918&action=edit Bug 40547: Background jobs should appear even when plugins disabled This change fixes the background jobs so that the list page loads even when plugins are disabled. Test plan: 0. Apply the patch 1. Download https://github.com/HKS3/koha-normalize-marc2db/releases/download/v0.91/Koha.... 2. Upload plugin into KTD 3. Click "Run tool" for plugin 4. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 5. Note that you see a pretty "Type" 6. Go to /etc/koha/sites/kohadev/koha-conf.xml and turn enable_plugins to 0 7. sudo koha-plack --restart kohadev 8. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 9. Note it now says "Unknown job type 'plugin_marc2db_normalizeall' 10. Celebrate as this is preferable to a 500 error Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #184918|0 |1 is obsolete| | --- Comment #4 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 184931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=184931&action=edit Bug 40547: Background jobs should appear even when plugins disabled This change fixes the background jobs so that the list page loads even when plugins are disabled. Test plan: 0. Apply the patch 1. Download https://github.com/HKS3/koha-normalize-marc2db/releases/download/v0.91/Koha.... 2. Upload plugin into KTD 3. Click "Run tool" for plugin 4. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 5. Note that you see a pretty "Type" 6. Go to /etc/koha/sites/kohadev/koha-conf.xml and turn enable_plugins to 0 7. sudo koha-plack --restart kohadev 8. Go to http://localhost:8081/cgi-bin/koha/admin/background_jobs.pl 9. Note it now says "Unknown job type 'plugin_marc2db_normalizeall' 10. Celebrate as this is preferable to a 500 error Signed-off-by: Aleisha Amohia <aleishaamohia@hotmail.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 --- Comment #5 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Keywords| |rel_24_11_candidate, | |rel_25_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00 |25.11.00,25.05.03 released in| | Status|Pushed to main |Pushed to stable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_25_05_candidate | CC| |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 --- Comment #7 from David Cook <dcook@prosentient.com.au> --- A report on Mattermost makes it sound like this needs to be pushed to 24.11.x as well. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 --- Comment #8 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #7)
A report on Mattermost makes it sound like this needs to be pushed to 24.11.x as well.
Oh man I just bumped into this myself again. Going to backport it to my own local branch... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 --- Comment #9 from David Cook <dcook@prosentient.com.au> --- Note this applies cleanly onto 24.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.03 |25.11.00,25.05.03,24.11.09 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.09 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Bug 40547 depends on bug 39772, which changed state. Bug 39772 Summary: Background jobs page lists unknown job types for jobs implemented by plugins https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39772 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Bug 40547 depends on bug 40033, which changed state. Bug 40033 Summary: The background jobs page calls GetPlugins incorrectly, resulting in a 500 error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40033 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40547 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org