[Bug 40651] New: Item search custom field selection is not populated in shareable link
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Bug ID: 40651 Summary: Item search custom field selection is not populated in shareable link Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com To recreate: 1 - Browse to Administration - Item search fields 2 - Add a new search field pointing to a marc field with some known value on a record with items 3 - Browse to Item search 4 - Construct a search using your new field and search 5 - From results click 'Copy shareable link' 6 - Go to the link 7 - No results or wrong results! 8 - Edit the search 9 - Note your custom field is not selected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 --- Comment #1 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185391&action=edit Bug 40651: Select custom search field if passed in via link This patch checks for a custom field value and preselects it in the dropdown if present To test: 1 - Browse to Administration - Item search fields 2 - Add a new search field pointing to a marc field with some known value on a record with items 3 - Browse to Item search 4 - Construct a search using your new field and search 5 - From results click 'Copy shareable link' 6 - Go to the link 7 - No results or wrong results! 8 - Edit the search 9 - Note your custom field is not selected 10 - Apply patch 11 - Visit the link again 12 - Correct results! 13 - Edit search 14 - Custom field is correctly selected! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 --- Comment #2 from Nick Clemens (kidclamp) <nick@bywatersolutions.com> --- Created attachment 185392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185392&action=edit Bug 40651: Add a link to manage item search fields When debugging this reported issue, I didn't know where to add these fields, let's make it more obvious for users who can manage those To test: 1 - Be a user who can manage item search fields i.e. have manage_item_search_fields permission 2 - Go to item search 3 - Note a link to Manage item search fields 4 - Confirm it works 5 - Be a user without the permission 6 - Go to item search 7 - There is no link! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Nick Clemens (kidclamp) <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=39072 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Lisette Scheer <lisette@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | CC| |lisette@bywatersolutions.co | |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 karie.straube@yavapaiaz.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karie.straube@yavapaiaz.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185391|0 |1 is obsolete| | Attachment #185392|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185400&action=edit Bug 40651: Select custom search field if passed in via link This patch checks for a custom field value and preselects it in the dropdown if present To test: 1 - Browse to Administration - Item search fields 2 - Add a new search field pointing to a marc field with some known value on a record with items 3 - Browse to Item search 4 - Construct a search using your new field and search 5 - From results click 'Copy shareable link' 6 - Go to the link 7 - No results or wrong results! 8 - Edit the search 9 - Note your custom field is not selected 10 - Apply patch 11 - Visit the link again 12 - Correct results! 13 - Edit search 14 - Custom field is correctly selected! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 185401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185401&action=edit Bug 40651: Add a link to manage item search fields When debugging this reported issue, I didn't know where to add these fields, let's make it more obvious for users who can manage those To test: 1 - Be a user who can manage item search fields i.e. have manage_item_search_fields permission 2 - Go to item search 3 - Note a link to Manage item search fields 4 - Confirm it works 5 - Be a user without the permission 6 - Go to item search 7 - There is no link! Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185400|0 |1 is obsolete| | --- Comment #5 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 185591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185591&action=edit Bug 40651: Select custom search field if passed in via link This patch checks for a custom field value and preselects it in the dropdown if present To test: 1 - Browse to Administration - Item search fields 2 - Add a new search field pointing to a marc field with some known value on a record with items 3 - Browse to Item search 4 - Construct a search using your new field and search 5 - From results click 'Copy shareable link' 6 - Go to the link 7 - No results or wrong results! 8 - Edit the search 9 - Note your custom field is not selected 10 - Apply patch 11 - Visit the link again 12 - Correct results! 13 - Edit search 14 - Custom field is correctly selected! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> Depends: bug xxxx 14322 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #185401|0 |1 is obsolete| | --- Comment #6 from Brendan Lawlor <blawlor@clamsnet.org> --- Created attachment 185592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=185592&action=edit Bug 40651: Add a link to manage item search fields When debugging this reported issue, I didn't know where to add these fields, let's make it more obvious for users who can manage those To test: 1 - Be a user who can manage item search fields i.e. have manage_item_search_fields permission 2 - Go to item search 3 - Note a link to Manage item search fields 4 - Confirm it works 5 - Be a user without the permission 6 - Go to item search 7 - There is no link! Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Brendan Lawlor <blawlor@clamsnet.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Brendan Lawlor <blawlor@clamsnet.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14322 CC| |blawlor@clamsnet.org QA Contact|testopia@bugs.koha-communit |blawlor@clamsnet.org |y.org | --- Comment #7 from Brendan Lawlor <blawlor@clamsnet.org> --- This makes sense that we need to select the custom field options that are passed in the shareable link. That was not included in bug 14322 originally so I'm really happy to see this fix. The link to manage custom fields is also a nice addition for admins. Thanks everyone! Passing QA. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14322 [Bug 14322] Add option to create a shareable link for item searches -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |25.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.04 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|25.11.00,25.05.04 |25.11.00,25.05.04,24.11.10 released in| | CC| |fridolin.somers@biblibre.co | |m Status|Pushed to stable |Pushed to oldstable --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 24.11.x for 24.11.10 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=40651 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting --- Comment #11 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- Not backporting to 22.11.x as it wasn't backported to 24.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org