[Bug 36187] New: Cannot set suggestedby when adding/editing a suggestion from the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Bug ID: 36187 Summary: Cannot set suggestedby when adding/editing a suggestion from the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs@lists.koha-community.org Reporter: lucas@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Make a new suggestion in the staff interface and attempt to set the "Created by" patron to someone other than the logged in user. 2. Submit the suggestion. 3. select suggestedby from suggestions where suggestionid = X; ( Where X is the suggestionid ) 4. The value is NULL 5. On suggestion/suggestion.pl the "Suggested by" column is blank. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- In the select_suggester() function data.borrowernumber is incorrect. It should be data.patron_id -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 --- Comment #2 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162520&action=edit Bug 36187: Corrected set data.patron_id in select_suggestor() To test: 1. Make a new suggestion in the staff interface and attempt to set the "Created by" patron to someone other than the logged in user. 2. Submit the suggestion. 3. select suggestedby from suggestions where suggestionid = X; ( Where X is the suggestionid ) 4. The value is NULL 5. On suggestion/suggestion.pl the "Suggested by" column is blank. 6. APPLY PATCH 7. Try 1 - 3 again. This time the suggestedby should be correctly set. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |35597 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35597 [Bug 35597] Purchase Suggestion changes aren't logged -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |lucas@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162520|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 162675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162675&action=edit Bug 36187: Corrected set data.patron_id in select_suggestor() To test: 1. Make a new suggestion in the staff interface and attempt to set the "Created by" patron to someone other than the logged in user. 2. Submit the suggestion. 3. select suggestedby from suggestions where suggestionid = X; ( Where X is the suggestionid ) 4. The value is NULL 5. On suggestion/suggestion.pl the "Suggested by" column is blank. 6. APPLY PATCH 7. Try 1 - 3 again. This time the suggestedby should be correctly set. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Andrew Fuerste-Henry <andrewfh@dubcolib.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162675|0 |1 is obsolete| | --- Comment #4 from Andrew Fuerste-Henry <andrewfh@dubcolib.org> --- Created attachment 162683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=162683&action=edit Bug 36187: Corrected set data.patron_id in select_suggestor() To test: 1. Make a new suggestion in the staff interface and attempt to set the "Created by" patron to someone other than the logged in user. 2. Submit the suggestion. 3. select suggestedby from suggestions where suggestionid = X; ( Where X is the suggestionid ) 4. The value is NULL 5. On suggestion/suggestion.pl the "Suggested by" column is blank. 6. APPLY PATCH 7. Try 1 - 3 again. This time the suggestedby should be correctly set. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot set suggestedby when |Cannot set suggestedby when |adding/editing a suggestion |adding/editing a suggestion |from the staff client |from the staff interface -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #162683|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 163972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=163972&action=edit Bug 36187: Corrected set data.patron_id in select_suggestor() To test: 1. Make a new suggestion in the staff interface and attempt to set the "Created by" patron to someone other than the logged in user. 2. Submit the suggestion. 3. select suggestedby from suggestions where suggestionid = X; ( Where X is the suggestionid ) 4. The value is NULL 5. On suggestion/suggestion.pl the "Suggested by" column is blank. 6. APPLY PATCH 7. Try 1 - 3 again. This time the suggestedby should be correctly set. Signed-off-by: Andrew Fuerste Henry <andrewfh@dubcolib.org> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | CC| |victor@tuxayo.net Status|Signed Off |Passed QA --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.05.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 --- Comment #7 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like it depends on Bug 35329 not in 23.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |Pushed to stable Version(s)|24.05.00 |24.05.00,23.11.08 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- (In reply to Fridolin Somers from comment #8)
Looks like it depends on Bug 35329 not in 23.11.x.
Ah nope, I reproduce in 23.11.x Since this is Ajax with REST API the data contains API-named fields. See https://git.koha-community.org/Koha-community/Koha/src/branch/23.11.x/Koha/P... Pushed to 23.11.x for 23.11.08 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 wainuiwitikapark@catalyst.net.nz changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #10 from wainuiwitikapark@catalyst.net.nz --- Not backporting to 23.05.x unless requested -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to oldstable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36187 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com Status|Needs documenting |RESOLVED --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix. Nothing to add or edit in the manual. Please reopen with more details if that is not the case! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org