[Bug 37758] New: Accessibility: "translControl1" field is missing a descriptive label
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Bug ID: 37758 Summary: Accessibility: "translControl1" field is missing a descriptive label Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Keywords: accessibility Severity: minor Priority: P5 - low Component: Accessibility Assignee: Laura.escamilla@bywatersolutions.com Reporter: Laura.escamilla@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: martin.renvoize@ptfs-europe.com, matt.blenkinsop@ptfs-europe.com, oleonard@myacpl.org For accessibility purposes every form element should have a descriptive text label. To recreate: 1. Go to your OPAC 2. Inspect the traslControl1 field - this is the catalog search bar. 3. Note that the field has an input type, class, id, name, and a value placeholder but not a label. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 --- Comment #1 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 170834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170834&action=edit Bug 37758: Hide the new labels but keep them accessible To test: 1. Go to your OPAC 2. Inspect the translControl1 field - this is the catalog search bar. 3. Note that the field has an input type, class, id, name, and a value placeholder but not a label. 4. Apply this patch, restart_all, do a yarn build and clear your browser's cache. 5. Repeat step 2. 6. Note that the field now includes a descriptive label in addition to the other fields that were already visible. 7. Sign off and have an incredible day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 --- Comment #2 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 170835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170835&action=edit Bug 37758: Add descriptive label to opac search bar Same test :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170834|0 |1 is obsolete| | --- Comment #3 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 170836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170836&action=edit Bug 37758: Hide the new labels but keep them accessible -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170835|0 |1 is obsolete| | --- Comment #4 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 170844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170844&action=edit Bug 37758: Add descriptive labels for accessibility To test: 1. Go to your OPAC 2. Inspect the translControl1 field - this is the catalog search bar. Note that the field has an input type, class, id, name, and a value placeholder but not a label. 3. Then inspect the masthead_search drop down, to the left of the catalog search bar. Note that it has a select name, id, and class but no descriptive label. 4. Apply this patch, restart_all, do a yarn build and clear your browser's cache. 5. Repeat step 2 and 3. 6. Note that the fields now include a descriptive label in addition to the other fields that were already visible. 7. Sign off and have an incredible day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170844|0 |1 is obsolete| | --- Comment #5 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 170845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170845&action=edit Bug 37758: Add descriptive labels for accessibility -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Laura Escamilla <Laura.escamilla@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170845|0 |1 is obsolete| | --- Comment #6 from Laura Escamilla <Laura.escamilla@bywatersolutions.com> --- Created attachment 170846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170846&action=edit Bug 37758: Add descriptive labels for accessibility To test: 1. Go to your OPAC 2. Inspect the translControl1 field - this is the catalog search bar. Note that the field has an input type, class, id, name, and a value placeholder but not a label. 3. Then inspect the masthead_search drop down, to the left of the catalog search bar. Note that it has a select name, id, and class but no descriptive label. 4. Apply this patch, restart_all, do a yarn build and clear your browser's cache. 5. Repeat step 2 and 3. 6. Note that the fields now include a descriptive label in addition to the other fields that were already visible. 7. Sign off and have an incredible day! :D -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170836|0 |1 is obsolete| | Attachment #170846|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170878&action=edit Bug 37758: Add descriptive labels for accessibility Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 --- Comment #8 from Owen Leonard <oleonard@myacpl.org> --- I obsoleted the CSS patch because a similar "visually-hidden" class is in Bootstrap 5. Please correct me if that's wrong! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Good fix, improves accessibility, passing QA. Thank you, Laura! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170878|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 170880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170880&action=edit Bug 37758: Add descriptive labels for accessibility Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |Main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | --- Comment #12 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 24.05.x. Happy to include if it is rebased for 24.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37758 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to main |RESOLVED --- Comment #13 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Merge conflicts with 24.05.x, no backport. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org