http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris@bigballofwax.co.nz |mtompset@hotmail.com -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 34371 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34371&action=edit Bug 13456: Serials/Claims.t expects no subscriptions However, this is an unreasonable assumption for a system which is in use (either lots of testing or production). TEST PLAN --------- 1) Have a supplier with a late subscription. 2) prove t/db_dependent/Serials/Claims.t -- will fail 3) apply patch 4) prove t/db_dependent/Serials/Claims.t -- success 5) run koha qa test tools -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Paola Rossi <paola.rossi@cineca.it> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34371|0 |1 is obsolete| | --- Comment #2 from Paola Rossi <paola.rossi@cineca.it> --- Created attachment 34480 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34480&action=edit Bug 13456: Serials/Claims.t expects no subscriptions I've applied the patch against master 3.19.00.000 Everything is ok. So I pass the patch to "Signed Off" status. At my tests a "late subscription" is an open subscription with 1 (whichever) issue in LATE/3 state. About step 5/: koha-qa.pl -v 2 -c 1 testing 1 commit(s) (applied to 5bdf460 'Bug 13425 - XSS in opac facets - Patc') Processing files before patches |========================>| 1 / 1 (100.00%) Processing files after patches |========================>| 1 / 1 (100.00%) OK t/db_dependent/Serials/Claims.t OK critic OK forbidden patterns OK pod OK valid -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #34480|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@biblibre.com> --- Created attachment 34525 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34525&action=edit Bug 13456: Serials/Claims.t expects no subscriptions However, this is an unreasonable assumption for a system which is in use (either lots of testing or production). TEST PLAN --------- 1) Have a supplier with a late subscription. 2) prove t/db_dependent/Serials/Claims.t -- will fail 3) apply patch 4) prove t/db_dependent/Serials/Claims.t -- success 5) run koha qa test tools Signed-off-by: Paola Rossi <paola.rossi@cineca.it> Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13456 --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Paola Rossi from comment #2) [SNIP]

Processing files before patches |========================>| 1 / 1 (100.00%) Processing files after patches |========================>| 1 / 1 (100.00%) [SNIP]

Thanks to Paola Possi for making me check if there were updates to the QA test tool! -- You are receiving this mail because: You are watching all bug changes.