[Bug 12295] New: Javascript error when merging authorities
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Bug ID: 12295 Summary: Javascript error when merging authorities Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: gmcharlt@gmail.com Reporter: kyle@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: m.de.rooy@rijksmuseum.nl Attempting to merge authorities results in the following error: Uncaught SyntaxError: Unexpected token u authorities-home.pl:284 showMergingInProgress authorities-home.pl:284 (anonymous function) authorities-home.pl:297 o jquery.js:2 p.fireWith jquery.js:2 e.extend.ready jquery.js:2 c.addEventListener.B -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 --- Comment #1 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 28376 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28376&action=edit Bug 12295 - Javascript error when merging authorities Attempting to merge authorities results in the following error: Uncaught SyntaxError: Unexpected token u authorities-home.pl:284 showMergingInProgress authorities-home.pl:284 (anonymous function) authorities-home.pl:297 o jquery.js:2 p.fireWith jquery.js:2 e.extend.ready jquery.js:2 c.addEventListener.B This appears to be an improper use of Javascript null vs undefined. A variable can be null and defined at the same time. We should be checking to see if the variable is defined, rather than null. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt@gmail.com |kyle@bywatersolutions.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Upgrading importance to major considering that this breaks authorities merging. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28376|0 |1 is obsolete| | --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Created attachment 28498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28498&action=edit [SIGNED-OFF] Bug 12295 - Javascript error when merging authorities Attempting to merge authorities results in the following error: Uncaught SyntaxError: Unexpected token u authorities-home.pl:284 showMergingInProgress authorities-home.pl:284 (anonymous function) authorities-home.pl:297 o jquery.js:2 p.fireWith jquery.js:2 e.extend.ready jquery.js:2 c.addEventListener.B This appears to be an improper use of Javascript null vs undefined. A variable can be null and defined at the same time. We should be checking to see if the variable is defined, rather than null. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No test plan, no errors. Test 1. search some authorities 2. clic merge, on browser dev console pops reported error message 'Unexpected token u authorities-home.pl...' No way to marge auths 3. with pach applied, merging works again -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bgkriegel@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 --- Comment #4 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 28500 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28500&action=edit Bug 12295: fix Javascript error when merging authorities Attempting to merge authorities results in the following error: Uncaught SyntaxError: Unexpected token u authorities-home.pl:284 showMergingInProgress authorities-home.pl:284 (anonymous function) authorities-home.pl:297 o jquery.js:2 p.fireWith jquery.js:2 e.extend.ready jquery.js:2 c.addEventListener.B This appears to be an improper use of Javascript null vs undefined. A variable can be null and defined at the same time. We should be checking to see if the variable is defined, rather than null. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No test plan, no errors. Test 1. search some authorities 2. click merge, on browser dev console pops reported error message 'Unexpected token u authorities-home.pl...' No way to marge auths 3. with pach applied, merging works again Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |gmcharlt@gmail.com -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28498|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 28501 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28501&action=edit Bug 12295: fix Javascript error when merging authorities Attempting to merge authorities results in the following error: Uncaught SyntaxError: Unexpected token u authorities-home.pl:284 showMergingInProgress authorities-home.pl:284 (anonymous function) authorities-home.pl:297 o jquery.js:2 p.fireWith jquery.js:2 e.extend.ready jquery.js:2 c.addEventListener.B This was the result of the upgrade of jquery-cookie by the patch for bug 11369; newer versions of jquery-cookie changed the return of $.cookie('foo') from null to undefined when the cookie is not present. Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> No test plan, no errors. Test 1. search some authorities 2. click merge, on browser dev console pops reported error message 'Unexpected token u authorities-home.pl...' No way to marge auths 3. with pach applied, merging works again Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #28500|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master. Thanks Kyle! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to 3.16.x for inclusion in 3.16.1. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12266 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Janusz Kaczmarek <januszop@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |francois.charbonnier@inlibr | |o.com --- Comment #8 from Janusz Kaczmarek <januszop@gmail.com> --- *** Bug 12579 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 Fridolin SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolyn.somers@biblibre.co | |m --- Comment #9 from Fridolin SOMERS <fridolyn.somers@biblibre.com> --- Pushed to 3.14.x, will be in 3.14.09 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12295 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=11369 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org