[Bug 26551] New: When importing a framework, the modal heading is too long and runs outside of the dialog
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 Bug ID: 26551 Summary: When importing a framework, the modal heading is too long and runs outside of the dialog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org When importing a framework, the modal dialog is too small for the heading... or the heading too long for the modal? Example: Import CF framework structure (fields and subfields) from a spreadsheet file (.csv or .ods) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #1 from David Nind <david@davidnind.com> --- Created attachment 110847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110847&action=edit Bug 26551 - Issue with text display in modal window I also noticed this - have added a screenshot as an example. The text in the modal window does not wrap around. Instead, it continues outside the modal window in a straight line. To replicate: 1. Go to Koha administration > Catalog > MARC bibliographic framework. 2. For any framework select Actions > Import. 3. Note that the text in modal window is not wrapped around and instead continues in a straight line. Evident on master on Ubuntu 18.04 desktop on the latest Firefox, Chromium and Google Chrome browsers. Also on 20.05.x. The text/modal window displays correctly in 19.11.x. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 110850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110850&action=edit Bug 26551: Correct modal markup to prevent long heading from overflowing This patch modifies the markup of the MARC framework import and export modals so that CSS intended only for Bootstrap buttons isn't applied to content in the modal. The modal dialog markup was nested inside a ".btn-group" <div>, which carries with it CSS that prevents text wrapping. Moving the modal markup out of the button group while keeping it inside the <td> corrects the problem. Lines have only been shifted and reindented. To test, apply the patch and go to Administration -> MARC bibliographic framework. - In the table of frameworks, from the "Actions" menu, test both the "Import" and "Export" links. Both should work as expected. - Confirm that the text of the heading on the "Import" modal wraps correctly. - Test the same operations for a framework other than the default one. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110850|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 110885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110885&action=edit Bug 26551: Correct modal markup to prevent long heading from overflowing This patch modifies the markup of the MARC framework import and export modals so that CSS intended only for Bootstrap buttons isn't applied to content in the modal. The modal dialog markup was nested inside a ".btn-group" <div>, which carries with it CSS that prevents text wrapping. Moving the modal markup out of the button group while keeping it inside the <td> corrects the problem. Lines have only been shifted and reindented. To test, apply the patch and go to Administration -> MARC bibliographic framework. - In the table of frameworks, from the "Actions" menu, test both the "Import" and "Export" links. Both should work as expected. - Confirm that the text of the heading on the "Import" modal wraps correctly. - Test the same operations for a framework other than the default one. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #110885|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 111244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111244&action=edit Bug 26551: Correct modal markup to prevent long heading from overflowing This patch modifies the markup of the MARC framework import and export modals so that CSS intended only for Bootstrap buttons isn't applied to content in the modal. The modal dialog markup was nested inside a ".btn-group" <div>, which carries with it CSS that prevents text wrapping. Moving the modal markup out of the button group while keeping it inside the <td> corrects the problem. Lines have only been shifted and reindented. To test, apply the patch and go to Administration -> MARC bibliographic framework. - In the table of frameworks, from the "Actions" menu, test both the "Import" and "Export" links. Both should work as expected. - Confirm that the text of the heading on the "Import" modal wraps correctly. - Test the same operations for a framework other than the default one. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize@ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Wrapping now works as expected and no regressions were found. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |20.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |lucas@bywatersolutions.com Version(s)|20.11.00 |20.11.00, 20.05.06 released in| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- backported to 20.05.x for 20.05.06 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz --- Comment #8 from Aleisha Amohia <aleisha@catalyst.net.nz> --- enhancement, not backported to 19.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26551 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to stable |RESOLVED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org