[Bug 26666] New: Display issue with adress information
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 Bug ID: 26666 Summary: Display issue with adress information Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: severine.queune@bulac.fr QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Created attachment 111539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111539&action=edit Line break tag visible on master 20.06 There is a display issue with the adress informations on patron's account : city and country are separated by an unexpected line break tag visible on patronbriefinfo and /moremember.pl page. See screenshot attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 --- Comment #1 from Séverine Queune <severine.queune@bulac.fr> --- Seen also on return page when there is a hold. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This also happens for master for AddressFormat French and German, but not for US. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 111819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111819&action=edit Bug 26666: Fix line breaks in addresses displayed with AddressFormat French or German When Addressformat is set to French or German the addresses on the Details tab will display <br /> in plain text. This is because a TT variable is used for adding line breaks that is either set to <br /> or "". Then this variable is escaped with the html filter... so we see the HTML tag uninterpreted. Switching to $raw for this specific case. To test: - Go to any patron account, - Fill in the various address fields - Switch the AddressFormat system preference to different settings - Verify the false display for French and German on the Details tab and in the brief info on the left side in the patron account - Apply patch - Repeat testing - All AddressFormats should now display correctly -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 Séverine Queune <severine.queune@bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111819|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune@bulac.fr> --- Created attachment 111827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111827&action=edit Bug 26666: Fix line breaks in addresses displayed with AddressFormat French or German When Addressformat is set to French or German the addresses on the Details tab will display <br /> in plain text. This is because a TT variable is used for adding line breaks that is either set to <br /> or "". Then this variable is escaped with the html filter... so we see the HTML tag uninterpreted. Switching to $raw for this specific case. To test: - Go to any patron account, - Fill in the various address fields - Switch the AddressFormat system preference to different settings - Verify the false display for French and German on the Details tab and in the brief info on the left side in the patron account - Apply patch - Repeat testing - All AddressFormats should now display correctly Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 --- Comment #5 from Séverine Queune <severine.queune@bulac.fr> --- Thanks Katrin for the quick patch ! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #111827|0 |1 is obsolete| | --- Comment #6 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 111830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111830&action=edit Bug 26666: Fix line breaks in addresses displayed with AddressFormat French or German When Addressformat is set to French or German the addresses on the Details tab will display <br /> in plain text. This is because a TT variable is used for adding line breaks that is either set to <br /> or "". Then this variable is escaped with the html filter... so we see the HTML tag uninterpreted. Switching to $raw for this specific case. To test: - Go to any patron account, - Fill in the various address fields - Switch the AddressFormat system preference to different settings - Verify the false display for French and German on the Details tab and in the brief info on the left side in the patron account - Apply patch - Repeat testing - All AddressFormats should now display correctly Signed-off-by: Séverine QUEUNE <severine.queune@bulac.fr> Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 --- Comment #7 from Julian Maurice <julian.maurice@biblibre.com> --- Created attachment 111831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111831&action=edit Bug 26666: (QA follow-up) Add 'USE raw' in template Signed-off-by: Julian Maurice <julian.maurice@biblibre.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 Julian Maurice <julian.maurice@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |julian.maurice@biblibre.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |20.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 --- Comment #8 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- doesn't apply cleanly to 20.05.x, no backport -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26666 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Display issue with adress |Display issue with address |information |information -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org