[Bug 14520] New: Prevent to override the existing currency code.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Bug ID: 14520 Summary: Prevent to override the existing currency code. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: amitddng135@gmail.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com While creating a new currency, if currency already exists then it will override the existing currency without warning any error message to the user. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |amitddng135@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135@gmail.com --- Comment #1 from Amit Gupta <amitddng135@gmail.com> --- Created attachment 40951 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40951&action=edit Bug 14520 - Prevent to override the existing currency code. On creating a currency, if it already exists, it will replace the existing one. This patch prevent that and display a message to the user interface. Test case 1. Create a currency new 'INR' with a symbol 'INR' and rate '1'. 2. Click on Edit and update the symbol with 'RS'. 3. Create a currency 'INR' with a symbol 'RUP' and rate '1' you should get a warning message "This currency already exists". -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12965 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12965 | CC| |mtompset@hotmail.com --- Comment #2 from M. Tompsett <mtompset@hotmail.com> --- Currency is not item type. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12146 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7571 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 --- Comment #3 from M. Tompsett <mtompset@hotmail.com> --- You need to keep bug 7571 in perspective when writing your patch. This patch is attempting to put a bandage on a larger problem: currency is poorly handled in Koha. If you fix 7571, this bug should become unnecessary. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|mtompset@hotmail.com | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=7571 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=12146 | -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 --- Comment #4 from Amit Gupta <amitddng135@gmail.com> --- It's giving only warning message to user. If currency code is already exists. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset@hotmail.com --- Comment #5 from M. Tompsett <mtompset@hotmail.com> --- What is the point of giving a warning message if you already did the update? If you wish to give some kind of warning, I think it should be similar in style to the delete_confirm. This will allow them to click 'Update this currency' and update it, or 'Leave unchanged' and leave it unchanged. Exact phrases are left as an exercise for the reader. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 --- Comment #6 from Amit Gupta <amitddng135@gmail.com> ---
What is the point of giving a warning message if you already did the update? If you wish to give some kind of warning, I think it should be similar in style to the delete_confirm. This will allow them to click 'Update this currency' and update it, or 'Leave unchanged' and leave it unchanged. Exact phrases are left as an exercise for the reader.
Hi Mark, You mean to say at the time of saving the currency it will check whether currency already exists or not if exists give the alert message. I am right? -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from M. Tompsett <mtompset@hotmail.com> --- (In reply to Amit Gupta from comment #6)
You mean to say at the time of saving the currency it will check whether currency already exists or not if exists give the alert message. I am right?
Edit -> Save --> Update Delete -> Confirm -- YES --> Delete -- NO --> No change New -> Save -- IF EXIST --> Confirm Update -- YES --> Update -- NO --> No change -- ELSE --> Add Hopefully formatting isn't ruined by a proportional font. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 --- Comment #8 from Amit Gupta <amitddng135@gmail.com> --- Sure will do. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14520 Amit Gupta <amitddng135@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org