[Bug 10555] New: overdue_notices -h does not list all options
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10555 Bug ID: 10555 Summary: overdue_notices -h does not list all options Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Command-line Utilities Assignee: gmcharlt@gmail.com Reporter: mathieu.saby@univ-rennes2.fr perl overdue_notices -h does not list all options. The following options are not listed : -v -list-all -t -date M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10555 --- Comment #1 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Created attachment 21108 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21108&action=edit [PATCH]Bug 10555: Update list of options displayed by overdue_notices.pl --help Very cosmetic patch... overdue_notices.pl --help display - an "usage" line - a first list of options, with short descriptions - a long list of options, with long descriptions 4 options are only in the 3rd, long list. They should also be in the "usage" line and in the short list. To test : run perl overdue_notice.pl --help and check all the options are displayed M. Saby -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10555 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10555 mathieu saby <mathieu.saby@univ-rennes2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10555 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Mathieu: Two code snippets: 1: GetOptions( 'date' => \$date, 2: if ($date){ $date=$dbh->quote($date); } else { $date="NOW()"; } It seems like the date parameter gets not correctly passed in. If you specify -date 23-09-2013, it will have value 1 since no value is defined in GetOptions. Since you document it, could you please verify or correct? Thanks. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10555 --- Comment #3 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- Well, this patch was very cosmetic and did not touch code itself. If something is broken, it must be broken in master. So, we should check on master, and fill a new bug if the issue is confirmed. Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10555 --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to mathieu saby from comment #3)
Well, this patch was very cosmetic and did not touch code itself.
I was just thinking: If you advertize an option that does not work, probably you should better not advertize it yet. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10555 --- Comment #5 from mathieu saby <mathieu.saby@univ-rennes2.fr> --- ok, understood. But I would prefer fixing the option ;-) I will take a look Mathieu -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10555 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Just a note: now the --date parameter works as expected. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org