[Bug 39939] New: Cancel selected holds button on waitingreserves.pl is the same color as the background
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Bug ID: 39939 Summary: Cancel selected holds button on waitingreserves.pl is the same color as the background Change sponsored?: --- Product: Koha Version: 24.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: bdaeuber@cityoffargo.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com It's hard to tell "Cancel Selected" on the Holds Awaiting Pickup screen is a button at all. It should have a different color than the background. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Cheryl <clackman@fargolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clackman@fargolibrary.org -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Version|24.11 |Main Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182929&action=edit Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background This patch makes some minor changes to the "Holds awaiting pickup" page so that the cancel buttons are clear and usable. The patch also wraps the reference to the TransferWhenCancelAllWaitingHolds system preference in a permission check so that it can be linked to the preference when appropriate. To test you should have some waiting holds in three categories: 1. Holds which have not been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. 2. Holds which have been waiting longer. I belive the only way to test this is to manually update the expiration date of an already waiting hold so that it is in the past. 3. Waiting holds which a patron has requested be cancelled. (Requires that the patron and hold are allowed according to the "Cancellation allowed" setting under Administration -> Circulation and fine rules -> Default waiting hold cancellation policy. - Log in to the OPAC as a patron who has a waiting hold. On the "Your summary" page, under the "Holds" tab, click the "Request to cancel" button for at least one of the waiting holds. - In the staff interface, go to Circulation -> Holds awaiting pickup. - Under each tab, check the appearance of the "Cancel selected" buttons (and the "Cancel and transfer all" button under "Holds awaiting past..." tab). - When testing as a user with system preference privileges, and the TransferWhenCancelAllWaitingHolds preference set to "Don't transfer," the hint shown under the "Holds awaiting past..." tab should be linked to system preferences. A user without system preference privileges should not see a link. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182929|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 182956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182956&action=edit Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background This patch makes some minor changes to the "Holds awaiting pickup" page so that the cancel buttons are clear and usable. The patch also wraps the reference to the TransferWhenCancelAllWaitingHolds system preference in a permission check so that it can be linked to the preference when appropriate. To test you should have some waiting holds in three categories: 1. Holds which have not been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. 2. Holds which have been waiting longer. I belive the only way to test this is to manually update the expiration date of an already waiting hold so that it is in the past. 3. Waiting holds which a patron has requested be cancelled. (Requires that the patron and hold are allowed according to the "Cancellation allowed" setting under Administration -> Circulation and fine rules -> Default waiting hold cancellation policy. - Log in to the OPAC as a patron who has a waiting hold. On the "Your summary" page, under the "Holds" tab, click the "Request to cancel" button for at least one of the waiting holds. - In the staff interface, go to Circulation -> Holds awaiting pickup. - Under each tab, check the appearance of the "Cancel selected" buttons (and the "Cancel and transfer all" button under "Holds awaiting past..." tab). - When testing as a user with system preference privileges, and the TransferWhenCancelAllWaitingHolds preference set to "Don't transfer," the hint shown under the "Holds awaiting past..." tab should be linked to system preferences. A user without system preference privileges should not see a link. Sponsored-by: Athens County Public Libraries -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182956|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 182961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182961&action=edit Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background This patch makes some minor changes to the "Holds awaiting pickup" page so that the cancel buttons are clear and usable. The patch also wraps the reference to the TransferWhenCancelAllWaitingHolds system preference in a permission check so that it can be linked to the preference when appropriate. To test you should have some waiting holds in three categories: 1. Holds which have not been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. 2. Holds which have been waiting longer. I belive the only way to test this is to manually update the expiration date of an already waiting hold so that it is in the past. 3. Waiting holds which a patron has requested be cancelled. (Requires that the patron and hold are allowed according to the "Cancellation allowed" setting under Administration -> Circulation and fine rules -> Default waiting hold cancellation policy. - Log in to the OPAC as a patron who has a waiting hold. On the "Your summary" page, under the "Holds" tab, click the "Request to cancel" button for at least one of the waiting holds. - In the staff interface, go to Circulation -> Holds awaiting pickup. - Under each tab, check the appearance of the "Cancel selected" buttons (and the "Cancel and transfer all" button under "Holds awaiting past..." tab). - When testing as a user with system preference privileges, and the TransferWhenCancelAllWaitingHolds preference set to "Don't transfer," the hint shown under the "Holds awaiting past..." tab should be linked to system preferences. A user without system preference privileges should not see a link. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 182962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=182962&action=edit Bug 39939: (follow-up) Fix terminology - syspref to system preference Spell system preference in full, instead of syspref. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com Text to go in the| |This fixes the cancel release notes| |selected holds buttons on | |the holds awaiting pickup | |page (under the tabs) | |(Circulation > Holds > | |Holds awaiting pickup). The | |light grey background was | |removed, and you can now | |see the cancel selected | |holds buttons. | | | |It also | |links the | |TransferWhenCancelAllWaitin | |gHolds system preference | |under the "Holds waiting | |past their expiration | |date", if the staff patron | |has permission to change | |system preferences. Summary|Cancel selected holds |Cancel selected holds |button on |button on the holds |waitingreserves.pl is the |awaiting pickup page is the |same color as the |same color as the |background |background -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 mteal@greenvillelibrary.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mteal@greenvillelibrary.org --- Comment #5 from mteal@greenvillelibrary.org --- It'd be great if the color of the button fix could get ported back to 24.11 It's confusing to staff to not have any indication of the button until you hover over the "Cancel selected" words. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182961|0 |1 is obsolete| | --- Comment #6 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 183495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183495&action=edit Bug 39939: Cancel selected holds button on waitingreserves.pl is the same color as the background This patch makes some minor changes to the "Holds awaiting pickup" page so that the cancel buttons are clear and usable. The patch also wraps the reference to the TransferWhenCancelAllWaitingHolds system preference in a permission check so that it can be linked to the preference when appropriate. To test you should have some waiting holds in three categories: 1. Holds which have not been waiting longer than the number of days specified in the ReservesMaxPickUpDelay system preference. 2. Holds which have been waiting longer. I belive the only way to test this is to manually update the expiration date of an already waiting hold so that it is in the past. 3. Waiting holds which a patron has requested be cancelled. (Requires that the patron and hold are allowed according to the "Cancellation allowed" setting under Administration -> Circulation and fine rules -> Default waiting hold cancellation policy. - Log in to the OPAC as a patron who has a waiting hold. On the "Your summary" page, under the "Holds" tab, click the "Request to cancel" button for at least one of the waiting holds. - In the staff interface, go to Circulation -> Holds awaiting pickup. - Under each tab, check the appearance of the "Cancel selected" buttons (and the "Cancel and transfer all" button under "Holds awaiting past..." tab). - When testing as a user with system preference privileges, and the TransferWhenCancelAllWaitingHolds preference set to "Don't transfer," the hint shown under the "Holds awaiting past..." tab should be linked to system preferences. A user without system preference privileges should not see a link. Sponsored-by: Athens County Public Libraries Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #182962|0 |1 is obsolete| | --- Comment #7 from Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> --- Created attachment 183496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=183496&action=edit Bug 39939: (follow-up) Fix terminology - syspref to system preference Spell system preference in full, instead of syspref. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Emily Lamancusa (emlam) <emily.lamancusa@montgomerycountymd.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |emily.lamancusa@montgomeryc |y.org |ountymd.gov Status|Signed Off |Passed QA CC| |emily.lamancusa@montgomeryc | |ountymd.gov -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |25.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 --- Comment #8 from Lucas Gass (lukeg) <lucas@bywatersolutions.com> --- Nice work everyone! Pushed to main for 25.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|25.11.00 |25.11.00,25.05.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 --- Comment #9 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Nice work everyone! Pushed to 25.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- Not sure this can apply on 24.11.x I dont see tab-toolbar class -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=39939 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org