[Bug 37592] New: Add created_at, updated_at fields to bookings table
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Bug ID: 37592 Summary: Add created_at, updated_at fields to bookings table Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: paul.derscheid@lmscloud.de QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #1 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170144&action=edit Bug 37592: Add created_at, updated_at fields to bookings table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #2 from Paul Derscheid <paul.derscheid@lmscloud.de> --- It would be helpful for some institutions to track when bookings were created and updated, for example when communicating with patrons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |29002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 [Bug 29002] Add ability to book items ahead of time -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Marie <marie.hedbom@musikverket.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marie.hedbom@musikverket.se -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170144|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 170161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170161&action=edit Bug 37592: Add created_at, updated_at fields to bookings table Signed-off-by: Owen Leonard <oleonard@myacpl.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37601 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37601 [Bug 37601] Add status field to bookings table -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|37601 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37601 [Bug 37601] Add status field to bookings table -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com Assignee|koha-bugs@lists.koha-commun |me@paulderscheid.xyz |ity.org | CC| |martin.renvoize@ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #4 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- I like this.. but lets make sure we have a 100% consensus on the API guidelines and have it cloned to Database guidelines before we push it: https://wiki.koha-community.org/wiki/Coding_Guidelines_-_API#REST1.3.4.1_dat... Currently the guidelines says: * Where a field contains a 'date' it should be consistently named thing_date as opposed to date_thing and it should always return a full datetime. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #5 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Good call! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Circulation| |bookings function| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|me@paulderscheid.xyz |paul.derscheid@lmscloud.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #6 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 170763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=170763&action=edit Bug 37592: (follow-up) Change created_at, updated_at to created_on, updated_on As per a discussion in the community chat, this change is more in line with the existing schema. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170763|0 |1 is obsolete| | --- Comment #7 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 171254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171254&action=edit Bug 37592: (follow-up) Change created_at, updated_at to created_on, updated_on As per a discussion in the community chat, this change is more in line with the existing schema. Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 leb <simonsen@bz-sh.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |simonsen@bz-sh.de Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #170161|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171376&action=edit Bug 37592: Add created_at, updated_at fields to bookings table Signed-off-by: Owen Leonard <oleonard@myacpl.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171254|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171377&action=edit Bug 37592: (follow-up) Change created_at, updated_at to created_on, updated_on As per a discussion in the community chat, this change is more in line with the existing schema. Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171378&action=edit Bug 37592: (QA follow-up) Add API mapping and definition Sticking to API guidelines, this adds the creation_date and modification_date fields to the api definitions and the required to_api_mappings for those fields to be properly populated. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add created_at, updated_at |Add a record of creation |fields to bookings table |and modification to | |bookings -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I don't want to block this, but forgive me this question: Independent of the general discussion on naming things, should we not try to avoid API mappings for new columns? I think if we use creation_date in the API we might also name the column that. What do you think? sub to_api_mapping { - return {}; + return { + created_on => "creation_date", + updated_on => "modification_date" + }; } Also a question for the release notes :) Signed-off-by: LEBSimonsen <simonsen@bz-sh.de> This will show as LEBSimonsen in the release notes - would you like to update to the name or another term? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #12 from Paul Derscheid <paul.derscheid@lmscloud.de> --- I'll gladly refactor it, if it's pushed immediately afterwards as these are literally just name changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #13 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Paul Derscheid from comment #12)
I'll gladly refactor it, if it's pushed immediately afterwards as these are literally just name changes.
Once the patch has reached my queue and it comes back again, it automatically goes on top of the enhancements pile. Check the dashboard :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #14 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 171524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171524&action=edit Bug 37592: (QA follow-up) Change created_on, updated_on to creation_date, modification_date It makes sense not to introduce mapping code if there's no reason for it. Accordingly the the columns are now of type DATETIME instead. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |37601 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37601 [Bug 37601] Add status field to bookings table -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #15 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #16 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 171645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171645&action=edit Bug 37592: (QA follow-up) Fetch database fields for api return Creation and Modification times are maintained by the database, but on add/update we were not fetching the updated fields from the database for the api response. This patch corrects that and also updates the api schema to reflect that these are readOnly fields. Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #17 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Follow-up pushed as RM Assistant; This gets the tests passing again and fixes a flaw in our logic. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #18 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Thanks for the assist Martin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | Text to go in the| |This enhancement adds release notes| |`created_at` and | |`updated_at` fields to the | |bookings table, providing | |institutions with the | |ability to track the | |creation and modification | |timestamps of bookings. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Paul Derscheid <paul.derscheid@lmscloud.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds |This enhancement adds release notes|`created_at` and |`created_at` and |`updated_at` fields to the |`updated_at` fields to the |bookings table, providing |bookings table, providing |institutions with the |institutions with the |ability to track the |ability to track the |creation and modification |creation and modification |timestamps of bookings. |timestamps of bookings. | | | |**Sponsored by** | |*Büchereizentrale | |Schleswig-Holstein* -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Needs documenting CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I am currently in the process of making sure that an updated installation will have the same database structure as a new installation. Here something seems to have gone wrong: +++ b/Koha/Schema/Result/Booking.pm @@ -87,7 +87,7 @@ the end date of the booking data_type: 'timestamp' datetime_undef_if_invalid: 1 default_value: current_timestamp - is_nullable: 0 + is_nullable: 1 the timestamp for when a booking was created @@ -96,7 +96,7 @@ the timestamp for when a booking was created data_type: 'timestamp' datetime_undef_if_invalid: 1 default_value: current_timestamp - is_nullable: 0 + is_nullable: 1 the timestamp for when a booking has been updated @@ -157,14 +157,14 @@ __PACKAGE__->add_columns( data_type => "timestamp", datetime_undef_if_invalid => 1, default_value => \"current_timestamp", - is_nullable => 0, + is_nullable => 1, }, "modification_date", { data_type => "timestamp", datetime_undef_if_invalid => 1, default_value => \"current_timestamp", - is_nullable => 0, + is_nullable => 1, }, "status", { @@ -257,8 +257,8 @@ __PACKAGE__->belongs_to( ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #20 from Jonathan Druart <jonathan.druart@gmail.com> --- Please also adjust the COMMENTs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #21 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174968&action=edit Bug 37592: (QA follow-up) Update db_rev to align DBIx::Class with database schema for creation_date, modification_date - DBIx::Class appears to determine column nullability based on database metadata. When columns are added via `ALTER TABLE` without explicitly specifying `NOT NULL`, the metadata may indicate `IS_NULLABLE = "YES"`, causing DBIx::Class to generate `is_nullable => 1` in the schema files. This behavior might not account for the implicit `NOT NULL` enforcement of `DEFAULT CURRENT_TIMESTAMP`. - Adding `NOT NULL` explicitly in the `ALTER TABLE` statements ensures the database metadata reflects the intended constraints, potentially resolving this issue. - Additionally, comments in the atomic update and `kohastructure.sql` are aligned for consistency and clarity. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #22 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- I believe we need to update kohastructure.sql as well: diff --git a/installer/data/mysql/kohastructure.sql b/installer/data/mysql/kohastructure.sql index f3dd950328d..e829cacc62b 100644 --- a/installer/data/mysql/kohastructure.sql +++ b/installer/data/mysql/kohastructure.sql @@ -1217,6 +1217,8 @@ CREATE TABLE `bookings` ( `pickup_library_id` varchar(10) NOT NULL COMMENT 'Identifier for booking pickup library', `start_date` datetime DEFAULT NULL COMMENT 'the start date of the booking', `end_date` datetime DEFAULT NULL COMMENT 'the end date of the booking', + `created_at` timestamp DEFAULT current_timestamp() COMMENT 'the timestamp for when a booking was created', + `updated_at` timestamp DEFAULT current_timestamp() ON UPDATE current_timestamp() COMMENT 'the timestamp for when a booking has been updated', -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #23 from Paul Derscheid <paul.derscheid@lmscloud.de> --- Created attachment 174969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174969&action=edit Bug 37592: (QA follow-up) Ensure consistent NOT NULL placement and make implicit behavior explicit - Explicitly set `NOT NULL` constraints for `creation_date` and `modification_date` in `kohastructure.sql` to clarify the implicit behavior of `DEFAULT CURRENT_TIMESTAMP`. - Adjusted the `modification_date` column definition in the atomic update file to place `NOT NULL` before `ON UPDATE` for consistency. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #24 from Jonathan Druart <jonathan.druart@gmail.com> --- playing the following commands: git checkout v24.05.00 reset_all git checkout main updatedatabase perl misc/devel/update_dbix_class_files.pl --koha-conf $KOHA_CONF git commit -a -m"test diff" dbic git diff "test diff" commit contains a diff that should not be there (datetime vs timestamp):
From f75fa56e49d62b7444926d06d351a74d33810bc9 Mon Sep 17 00:00:00 2001 From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Date: Mon, 25 Nov 2024 13:49:37 +0100 Subject: [PATCH 1/1] test diff
--- Koha/Schema/Result/Booking.pm | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/Koha/Schema/Result/Booking.pm b/Koha/Schema/Result/Booking.pm index 2231dbf19a3..6f8ec07b818 100644 --- a/Koha/Schema/Result/Booking.pm +++ b/Koha/Schema/Result/Booking.pm @@ -84,21 +84,21 @@ the end date of the booking =head2 creation_date - data_type: 'timestamp' + data_type: 'datetime' datetime_undef_if_invalid: 1 - default_value: current_timestamp + default_value: 'current_timestamp()' is_nullable: 0 -the timestamp for when a booking was created +the datetime for when a bookings was created =head2 modification_date - data_type: 'timestamp' + data_type: 'datetime' datetime_undef_if_invalid: 1 - default_value: current_timestamp + default_value: 'current_timestamp()' is_nullable: 0 -the timestamp for when a booking has been updated +the datetime for when a booking has been updated =head2 status @@ -154,16 +154,16 @@ __PACKAGE__->add_columns( }, "creation_date", { - data_type => "timestamp", + data_type => "datetime", datetime_undef_if_invalid => 1, - default_value => \"current_timestamp", + default_value => "current_timestamp()", is_nullable => 0, }, "modification_date", { - data_type => "timestamp", + data_type => "datetime", datetime_undef_if_invalid => 1, - default_value => \"current_timestamp", + default_value => "current_timestamp()", is_nullable => 0, }, "status", @@ -257,8 +257,8 @@ __PACKAGE__->belongs_to( ); -# Created by DBIx::Class::Schema::Loader v0.07051 @ 2024-10-24 16:23:05 -# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:kTR2kwiwY2PnjU1E0P+CMQ +# Created by DBIx::Class::Schema::Loader v0.07051 @ 2024-11-25 12:47:59 +# DO NOT MODIFY THIS OR ANYTHING ABOVE! md5sum:QU3grfGiob0SxIHPVbY6ZA # You can replace this text with custom code or comments, and it will be preserved on regeneration -- 2.34.1 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #25 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 174970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174970&action=edit Bug 37592: (Follow-up) Fix timestamp vs datatime in db_rev -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #26 from Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> --- Created attachment 174971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174971&action=edit Bug 37592: (Follow-up) Fix timestamp vs datetime in db_rev -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Martin Renvoize (ashimema) <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174970|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174971|0 |1 is obsolete| | --- Comment #27 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174972&action=edit Bug 37592: (follow-up) Fix timestamp vs datetime in db_rev Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #28 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174973&action=edit Bug 37592: (follow-up) Fix comments in db_rev Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Picked the last 2 follow-up patches "Fix timestamp vs. datetime.." and "Fix comments..." for main. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wainuiwitikapark@catalyst.n | |et.nz --- Comment #30 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #29)
Picked the last 2 follow-up patches "Fix timestamp vs. datetime.." and "Fix comments..." for main.
Should I do the same for 24.05? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Leaving final answer to Martin, but I think this feature is not in 24.05 yet and is part of a big tree, so I would not include in 24.05. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 --- Comment #32 from Wainui Witika-Park <wainuiwitikapark@catalyst.net.nz> --- (In reply to Katrin Fischer from comment #31)
Leaving final answer to Martin, but I think this feature is not in 24.05 yet and is part of a big tree, so I would not include in 24.05.
Thanks Katrin! Not backporting to 24.05 unless requested, or advised by Martin :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Bug 37592 depends on bug 29002, which changed state. Bug 29002 Summary: Add ability to book items ahead of time https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=29002 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37592 Aude Charillon <aude.charillon@openfifth.co.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |aude.charillon@openfifth.co | |.uk Status|Needs documenting |RESOLVED --- Comment #33 from Aude Charillon <aude.charillon@openfifth.co.uk> --- No update to the Koha Manual necessary. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org