http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 --- Comment #2 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 15236 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15236&action=edit Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Attempt to check out 1 more item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to "Don't allow" 6) Repeat step 3 7) You should be blocked from being able to issue the item -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |koha@univ-lyon3.fr -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris@bigballofwax.co.nz --- Comment #5 from Chris Cormack <chris@bigballofwax.co.nz> --- Did you miss adding your sign off to this patch? -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Koha Team Lyon 3 <koha@univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Fridolyn SOMERS <fridolyn.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Srdjan Jankovic <srdjan@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18658|0 |1 is obsolete| | --- Comment #8 from Srdjan Jankovic <srdjan@catalyst.net.nz> --- Created attachment 18722 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18722&action=edit [SIGNED-OFF] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Signed-off-by: Srdjan <srdjan@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 --- Comment #9 from Galen Charlton <gmcharlt@gmail.com> --- (In reply to comment #1)

This should be controlled via a syspref ala the Allow*Override system preferences.

This comment isn't about the proposed patch per se, just inspired by it. Doing it via syspref, while consistent with precedent (OverduesBlockCirc, AllFinesNeedOverride, AllowNotForLoanOverride, AgeRestrictionOverride, etc.), bothers me. The ability to override isn't necessarily just a matter of library policy; it also ought to be a matter of staff permission. The problem with using sysprefs is that they're too broad. As the original bug reporter implies, you don't necessarily want ordinary circ clerks to be able to override the limit, but you probably do want circ supervisors to be able to do so; consider the usual "library board member is standing in front of you wanting to check out just one more book" scenario. If we pursue creating staff user permissions for overrides, how do folks think they should work? Replace the system preference? Work in conjunction with the syspref? As I said, this comment isn't about the proposed patch, which is consistent with how things have been handled in the past. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19612&action=edit [PASSED QA] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Attempt to check out 1 more item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to "Don't allow" 6) Repeat step 3 7) You should be blocked from being able to issue the item Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The new system preference is activated by default, which mean there will be know change in behaviour on update. The system preference is correctly added to the database and .pref files. Test plan and QA script passes. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9576 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18722|0 |1 is obsolete| | Attachment #19612|0 |1 is obsolete| | --- Comment #12 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 19613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19613&action=edit [PASSED QA] Bug 9576 - Enable or disable issue limit confirmation Adds a new system preference AllowTooManyOverride to control whether a librarian can override the 'Too many checked out' message which is currently always overridable. Test Plan: 1) Apply patch 2) Run updatedatabase.pl 3) Attempt to check out 1 more item to a patron than the max issues 4) You should be allowed to override by default ( current behavior ) 5) Set AllowTooManyOverride to "Don't allow" 6) Repeat step 3 7) You should be blocked from being able to issue the item Signed-off-by: Srdjan <srdjan@catalyst.net.nz> Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> The new system preference is activated by default, which mean there will be know change in behaviour on update. The system preference is correctly added to the database and .pref files. Test plan and QA script passes. -- You are receiving this mail because: You are watching all bug changes.