[Bug 10297] New: categorycode and branchcode should be required for patrons
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Bug ID: 10297 Summary: categorycode and branchcode should be required for patrons Classification: Unclassified Change sponsored?: --- Product: Koha Version: 3.10 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nengard@gmail.com CC: drnoe@bywatersolutions.com, gmcharlt@gmail.com, kyle.m.hall@gmail.com The BorrowerMandatoryField pref should have categorycode and branchcode should be in the default values for this preference since they are required by Koha but not labeled as such on the patron add form. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- (In reply to comment #0)
The BorrowerMandatoryField pref should have categorycode and branchcode
I would think instead they should be mandatory regardless of what is in BorrowerMandatoryField. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 --- Comment #2 from Nicole C. Engard <nengard@gmail.com> --- That works for me too :) Anything that makes it clear that they're required. Nicole -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|3.10 |master Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | Summary|categorycode and branchcode |categorycode and branchcode |should be required for |should be required when |patrons |adding patrons -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 18825 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18825&action=edit Bug 10297 - categorycode and branchcode should be required when adding patrons categorycode and branchcode should show as required under all circumstances, not just when they are included in the BorrowerMandatoryField system preference. This patch adds the correct classes and hints to those fields. To test, view the patron entry form for a new or existing patron. Category and Library should show that they are required. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #18825|0 |1 is obsolete| | --- Comment #4 from David Cook <dcook@prosentient.com.au> --- Created attachment 18828 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18828&action=edit [SIGNED OFF] Bug 10297 - categorycode and branchcode should be required when adding patrons categorycode and branchcode should show as required under all circumstances, not just when they are included in the BorrowerMandatoryField system preference. This patch adds the correct classes and hints to those fields. To test, view the patron entry form for a new or existing patron. Category and Library should show that they are required. Signed-off-by: David Cook <dcook@prosentient.com.au> Works as described. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |dcook@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Jonathan Druart <jonathan.druart@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |jonathan.druart@biblibre.co | |m Patch complexity|--- |Trivial patch QA Contact| |jonathan.druart@biblibre.co | |m --- Comment #5 from Jonathan Druart <jonathan.druart@biblibre.com> --- QA comment: Logical patch, branchcode and categorycode cannot be null. Marked as Passed QA. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Owen! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #7 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks for reporting Nicole, and Owen for the fix! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.8 -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10297 Chris Hall <chrish@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz --- Comment #9 from Chris Hall <chrish@catalyst.net.nz> --- Pushed to 3.8.x, will be in 3.8.15 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org