[Bug 37945] New: Links for system preferences subsections don't work
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Bug ID: 37945 Summary: Links for system preferences subsections don't work Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org When clicking on subsections in the left-hand side menu in system preferences, the screen goes down a bit, but not to the section. To recreate: 1. Go to Administration > System preferences 2. Click Circulation in the left menu (for example) 3. Click Holds policy in the left menu (for example) --> Screen goes down a couple of lines to Article requests (?) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- If it helps, I'm using KTD with Chrome on Ubuntu 22.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Heather <flyingendpaper@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |flyingendpaper@gmail.com --- Comment #2 from Heather <flyingendpaper@gmail.com> --- I'm using Edge (because employer) and am not able to replicate this--it seems to be working for me on our 24.05.03 catalog and also on ByWater's 24.05.03 demo. So, maybe something broke after 24.05.03? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |35402 CC| |david@davidnind.com --- Comment #3 from David Nind <david@davidnind.com> --- I've tested on main with Firefox, Chromium, and Google Chrome (all on Ubuntu 22.04) - can confirm Caroline's findings in the description. Other things noted: 1. From system preference search results, the links to "View all XXX preferences" seems to work OK, but not when browsing (as per the bug description). 2. Everything works as expected in a demo 24.05.03, so definitely something added after this to main. Maybe Bug 35402 - Update the OPAC and staff interface to Bootstrap 5 (have linked in case it is related to that). Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 --- Comment #4 from David Nind <david@davidnind.com> --- Can confirm that things were working as expected before the Bootstrap 5 update, but not after: 1. Checkout before the Bootstrap 5 patches: git checkout f44d2cccc7 2. Rebuild the CSS: yarn build 3. Restart everything: restart_all 4. Check that everything works as expected - see description 5. Checkout after the Bootstrap 5 patches: git checkout 764162cd6 6. Rebuild the CSS: yarn build 7. Restart everything: restart_all 8. Check that links are not working as expected - see description -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Thanks for confirming David! I figured it was a BS5 bug (I thought it was too weird a bug to be something else), but hadn't done the in-depth research you did. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- It works if I remove: js/pages/preferences.js 211 $("table.preferences").dataTable( 212 $.extend(true, {}, dataTablesDefaults, { 213 dom: "t", 214 columnDefs: [{ targets: [-1], orderable: false, searchable: false }], 215 paging: false, 216 }) 217 ); -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 --- Comment #7 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172572&action=edit Bug 37945: Fix scroll on syspref page -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- I cannot investigate more right more, but this patch is fixing the problem. It seems good enough for now, not sure we need the other DT's defaults. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172572|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 172573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172573&action=edit Bug 37945: Remove fixedHeader for sysprefs It breaks the scroll when a subsection is clicked. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard@myacpl.org |jonathan.druart@gmail.com --- Comment #10 from Jonathan Druart <jonathan.druart@gmail.com> --- Ok found it, it's actually the fixedHeader. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172573|0 |1 is obsolete| | --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Created attachment 172576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172576&action=edit Bug 37945: Remove fixedHeader for sysprefs It breaks the scroll when a subsection is clicked. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 --- Comment #12 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- THANK YOU!!! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 --- Comment #13 from David Nind <david@davidnind.com> --- Thanks Jonathan and Caroline! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |lucas@bywatersolutions.com |y.org | Patch complexity|--- |Trivial patch CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 --- Comment #14 from Lucas Gass <lucas@bywatersolutions.com> --- Good solution, works perfectly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #172576|0 |1 is obsolete| | --- Comment #15 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 172666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=172666&action=edit Bug 37945: Remove fixedHeader for sysprefs It breaks the scroll when a subsection is clicked. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 --- Comment #16 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37945 Bug 37945 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org