[Bug 37841] New: Switch OPAC language menu alignment in header and footer
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 Bug ID: 37841 Summary: Switch OPAC language menu alignment in header and footer Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 35402 Blocks: 36337 (In reply to Jonathan Druart from Bug 36337 comment #6)
Not sure if this is this patch that needs to fix it, but I found a bad display when en and en-GB are selected: https://snipboard.io/iBNjEn.jpg (bottom left)
The OPAC language menu needs to switch it's alignment relative to the trigger button based on whether it's appearing in the header or the footer. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 [Bug 35402] Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36337 [Bug 36337] Hiding lists with OpacPublic breaks styling for language list -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171060&action=edit Bug 37841: Switch OPAC language menu alignment in header and footer The OPAC language menu is now generated by the same include file in both the header and the footer. We have a switch for the menu's direction based on this context, but we also need a switch for alignment: The menu should extend left into the page from the header, and right into the page from the footer. To test you should have at least one additional language installed and enabled. To reproduce the bug I recomment en-GB because the language description is long enough to trigger the misalignment. - Apply the patch and set the 'opaclanguagesdisplay' system preference to "Allow" and the 'OpacLangSelectorMode' preference to "both top and footer". - Go to the OPAC and test the language selector menus in the header and footer. - The expanded menu in the header should extend to the left of the "Languages" menu trigger. - The expanded menu in the footer should extend to the right of the "Languages" menu trigger. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 171158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171158&action=edit Screenshot - display issue after patch + English United Kingdom language selected The patch fixes the display if English is the language selected. However, if you select 'English United Kingdom', you get the same problem again (see the screenshot) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 --- Comment #3 from Owen Leonard <oleonard@myacpl.org> --- David did you update and install the en-GB translations after applying the patch? From the screenshot it looks like the en-GB templates don't have the patch's changes. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to Owen Leonard from comment #3)
David did you update and install the en-GB translations after applying the patch? From the screenshot it looks like the en-GB templates don't have the patch's changes.
That was indeed the problem! Sign off on the way... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171060|0 |1 is obsolete| | --- Comment #5 from David Nind <david@davidnind.com> --- Created attachment 171230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171230&action=edit Bug 37841: Switch OPAC language menu alignment in header and footer The OPAC language menu is now generated by the same include file in both the header and the footer. We have a switch for the menu's direction based on this context, but we also need a switch for alignment: The menu should extend left into the page from the header, and right into the page from the footer. To test you should have at least one additional language installed and enabled. To reproduce the bug I recomment en-GB because the language description is long enough to trigger the misalignment. - Apply the patch and set the 'opaclanguagesdisplay' system preference to "Allow" and the 'OpacLangSelectorMode' preference to "both top and footer". - Go to the OPAC and test the language selector menus in the header and footer. - The expanded menu in the header should extend to the left of the "Languages" menu trigger. - The expanded menu in the footer should extend to the right of the "Languages" menu trigger. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171158|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes the display of release notes| |the language selector in | |the footer for the OPAC. | |For longer language names | |(such as English United | |Kingdom), the name is | |misaligned and goes off the | |page to the left. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com Status|Signed Off |Patch doesn't apply --- Comment #6 from Jonathan Druart <jonathan.druart@gmail.com> --- To test bug 36337 I need to apply bug 37833 and this one, but I get a conflict: Bug 36337 Depends on bug 37833 (Signed Off) Follow? [(y)es, (n)o] Bug 37833 - Incorrect logic controlling display of OPAC language selection menus 171154 - Bug 37833: Incorrect logic controlling display of OPAC language selection menus Applying: Bug 37833: Incorrect logic controlling display of OPAC language selection menus Apply? [(y)es, (n)o, (i)nteractive] Bug 36337 Depends on bug 37841 (Signed Off) Follow? [(y)es, (n)o] Bug 37841 - Switch OPAC language menu alignment in header and footer 171230 - Bug 37841: Switch OPAC language menu alignment in header and footer Applying: Bug 37841: Switch OPAC language menu alignment in header and footer Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/includes/langmenu.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171230|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 171345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171345&action=edit Bug 37841: Switch OPAC language menu alignment in header and footer The OPAC language menu is now generated by the same include file in both the header and the footer. We have a switch for the menu's direction based on this context, but we also need a switch for alignment: The menu should extend left into the page from the header, and right into the page from the footer. To test you should have at least one additional language installed and enabled. To reproduce the bug I recomment en-GB because the language description is long enough to trigger the misalignment. - Apply the patch and set the 'opaclanguagesdisplay' system preference to "Allow" and the 'OpacLangSelectorMode' preference to "both top and footer". - Go to the OPAC and test the language selector menus in the header and footer. - The expanded menu in the header should extend to the left of the "Languages" menu trigger. - The expanded menu in the footer should extend to the right of the "Languages" menu trigger. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #171345|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 171356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=171356&action=edit Bug 37841: Switch OPAC language menu alignment in header and footer The OPAC language menu is now generated by the same include file in both the header and the footer. We have a switch for the menu's direction based on this context, but we also need a switch for alignment: The menu should extend left into the page from the header, and right into the page from the footer. To test you should have at least one additional language installed and enabled. To reproduce the bug I recomment en-GB because the language description is long enough to trigger the misalignment. - Apply the patch and set the 'opaclanguagesdisplay' system preference to "Allow" and the 'OpacLangSelectorMode' preference to "both top and footer". - Go to the OPAC and test the language selector menus in the header and footer. - The expanded menu in the header should extend to the left of the "Languages" menu trigger. - The expanded menu in the footer should extend to the right of the "Languages" menu trigger. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |24.11.00 released in| | Status|Passed QA |Pushed to main -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37841 Bug 37841 depends on bug 35402, which changed state. Bug 35402 Summary: Update the OPAC and staff interface to Bootstrap 5 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35402 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org