[Bug 38424] New: Upgrade redocly/cli to the latest release
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 Bug ID: 38424 Summary: Upgrade redocly/cli to the latest release Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs@lists.koha-community.org Reporter: tomascohen@gmail.com QA Contact: testopia@bugs.koha-community.org While not critical, our used version is dated and we keep getting warnings about it when `reset_all` is run or at `KTD` startup time. https://github.com/Redocly/redocly-cli/releases -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |tomascohen@gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 --- Comment #1 from Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> --- Created attachment 174414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174414&action=edit Bug 38424: Upgrade redoclyly/cli version to latest stable This patch updates the used version of redocly/cli to the latest stable. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle => FAIL: You get ``` yarn run v1.22.22 $ redocly bundle --ext json api/v1/swagger/swagger.yaml --output api/v1/swagger/swagger_bundle.json ╔════════════════════════════════════════════════════════╗ ║ ║ ║ A new version of Redocly CLI (1.25.11) is available. ║ ║ Update now: `npm i -g @redocly/cli@latest`. ║ ║ Changelog: https://redocly.com/docs/cli/changelog/ ║ ║ ║ ╚════════════════════════════════════════════════════════╝ bundling api/v1/swagger/swagger.yaml... 📦 Created a bundle for api/v1/swagger/swagger.yaml at api/v1/swagger/swagger_bundle.json 207ms. Done in 1.34s. ``` 3. Apply this patch 4. Run: k$ sudo yarn install --modules-folder /kohadevbox/node_modules 5. Repeat 2: => SUCCESS: You get ``` yarn run v1.22.22 $ redocly bundle --ext json api/v1/swagger/swagger.yaml --output api/v1/swagger/swagger_bundle.json bundling api/v1/swagger/swagger.yaml... 📦 Created a bundle for api/v1/swagger/swagger.yaml at api/v1/swagger/swagger_bundle.json 200ms. Done in 1.29s. ``` 6. Restart plack and check the API loads without issues: k$ koha-plack --restart kohadev; tail -f /var/log/koha/kohadev/*.log 7. Run the tests: k$ prove -r t/db_dependent/api/ => SUCCESS: No failures 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 Tomás Cohen Arazi (tcohen) <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 --- Comment #2 from Jonathan Druart <jonathan.druart@gmail.com> --- yarn.lock should be generated by RM. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #174414|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart@gmail.com> --- Created attachment 174789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=174789&action=edit Bug 38424: Upgrade redoclyly/cli version to latest stable This patch updates the used version of redocly/cli to the latest stable. To test: 1. Apply this patch 2. Run: $ ktd --shell k$ yarn api:bundle => FAIL: You get ``` yarn run v1.22.22 $ redocly bundle --ext json api/v1/swagger/swagger.yaml --output api/v1/swagger/swagger_bundle.json ╔════════════════════════════════════════════════════════╗ ║ ║ ║ A new version of Redocly CLI (1.25.11) is available. ║ ║ Update now: `npm i -g @redocly/cli@latest`. ║ ║ Changelog: https://redocly.com/docs/cli/changelog/ ║ ║ ║ ╚════════════════════════════════════════════════════════╝ bundling api/v1/swagger/swagger.yaml... 📦 Created a bundle for api/v1/swagger/swagger.yaml at api/v1/swagger/swagger_bundle.json 207ms. Done in 1.34s. ``` 3. Apply this patch 4. Run: k$ sudo yarn install --modules-folder /kohadevbox/node_modules 5. Repeat 2: => SUCCESS: You get ``` yarn run v1.22.22 $ redocly bundle --ext json api/v1/swagger/swagger.yaml --output api/v1/swagger/swagger_bundle.json bundling api/v1/swagger/swagger.yaml... 📦 Created a bundle for api/v1/swagger/swagger.yaml at api/v1/swagger/swagger_bundle.json 200ms. Done in 1.29s. ``` 6. Restart plack and check the API loads without issues: k$ koha-plack --restart kohadev; tail -f /var/log/koha/kohadev/*.log 7. Run the tests: k$ prove -r t/db_dependent/api/ => SUCCESS: No failures 8. Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 --- Comment #4 from Jonathan Druart <jonathan.druart@gmail.com> --- RM: generate yarn.lock and ask for ktd rebuild when this is pushed. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 Jonathan Druart <jonathan.druart@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to Jonathan Druart from comment #4)
RM: generate yarn.lock and ask for ktd rebuild when this is pushed.
OK, I need a little help here as I didn't find it in documentation: https://wiki.koha-community.org/wiki/Release_management#Yarn How do I rebuild the yarn.lock? * Tried yarn build with no result. * Tried yarn install, which created a yarn.lock file. Is this the correct way? Please catch me on Mattermost so we can schedule push/ktd rebuild. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to main |Needs documenting -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=38424 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED CC| |caroline.cyr-la-rose@inlibr | |o.com --- Comment #7 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org