[Bug 37186] New: Cannot delete a rotating collection
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Bug ID: 37186 Summary: Cannot delete a rotating collection Change sponsored?: --- Product: Koha Version: Main Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs@lists.koha-community.org Reporter: cubingguy714@gmail.com QA Contact: testopia@bugs.koha-community.org To recreate: 1. Tools -> Rotating collections 2. Create a rotating collection 3. From rotating collections Action -> Delete 4. Collection is not deleted -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Depends on| |37190 --- Comment #1 from Lucas Gass <lucas@bywatersolutions.com> --- To make this form work as a link we need the fix from Bug 37190. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37190 [Bug 37190] form-submit.js data- attributes should use lowercase attribute names -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |cubingguy714@gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass from comment #1)
To make this form work as a link we need the fix from Bug 37190.
This form has already been revised to convert it to a POSTed operation, but the submit button wasn't converted from an <a>. If we replace the "confirmdelete" link with a button it will work: <button type="submit" class="btn btn-default confirmdelete"><i class="fa fa-trash-can"></i> Delete</button> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 --- Comment #3 from Lucas Gass <lucas@bywatersolutions.com> --- (In reply to Owen Leonard from comment #2)
(In reply to Lucas Gass from comment #1)
To make this form work as a link we need the fix from Bug 37190.
This form has already been revised to convert it to a POSTed operation, but the submit button wasn't converted from an <a>. If we replace the "confirmdelete" link with a button it will work:
<button type="submit" class="btn btn-default confirmdelete"><i class="fa fa-trash-can"></i> Delete</button>
Do you think that would be better than adopting Nick's new for as a link? Bug 36246 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 --- Comment #4 from Owen Leonard <oleonard@myacpl.org> --- (In reply to Lucas Gass from comment #3)
Do you think that would be better than adopting Nick's new for as a link? Bug 36246
I guess it doesn't really matter one way or the other. If you wanted to submit a fix which uses form-submit.js it would at least be a good way to test Bug 37190! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Bug 37186 depends on bug 37190, which changed state. Bug 37190 Summary: form-submit.js data- attributes should use lowercase attribute names https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37190 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|37190 |3719 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3719 [Bug 3719] Create syspref to allow sites to rename OPAC Cart https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37190 [Bug 37190] form-submit.js data- attributes should use lowercase attribute names -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|3719 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3719 [Bug 3719] Create syspref to allow sites to rename OPAC Cart -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Eric Garcia <cubingguy714@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 --- Comment #5 from Eric Garcia <cubingguy714@gmail.com> --- Created attachment 168610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168610&action=edit Bug 37186: Fixed deletion of rotating collections To test: 1. Tools -> Rotating collections 2. Create a rotating collection 3. In new collection Actions -> Delete 4. Notice collection is not deleted 5. Apply patch 6. In new collection Actions -> Delete 7. Notice collection is deleted -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Roman Dolny <roman.dolny@jezuici.pl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168610|0 |1 is obsolete| | --- Comment #6 from Roman Dolny <roman.dolny@jezuici.pl> --- Created attachment 168611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168611&action=edit Bug 37186: Fixed deletion of rotating collections To test: 1. Tools -> Rotating collections 2. Create a rotating collection 3. In new collection Actions -> Delete 4. Notice collection is not deleted 5. Apply patch 6. In new collection Actions -> Delete 7. Notice collection is deleted Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #168611|0 |1 is obsolete| | --- Comment #7 from Lucas Gass <lucas@bywatersolutions.com> --- Created attachment 168612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=168612&action=edit Bug 37186: Fixed deletion of rotating collections To test: 1. Tools -> Rotating collections 2. Create a rotating collection 3. In new collection Actions -> Delete 4. Notice collection is not deleted 5. Apply patch 6. In new collection Actions -> Delete 7. Notice collection is deleted Signed-off-by: Roman Dolny <roman.dolny@jezuici.pl> Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to main Version(s)| |24.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.11! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Phil Ringnalda <phil@chetcolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |phil@chetcolibrary.org Keywords| |rel_24_05_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to main |Pushed to stable Version(s)|24.11.00 |24.11.00,24.05.04 released in| | --- Comment #9 from Lucas Gass <lucas@bywatersolutions.com> --- Backported to 24.05.x for upcoming 24.05.04 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_24_05_candidate | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Needs documenting CC| |fridolin.somers@biblibre.co | |m --- Comment #10 from Fridolin Somers <fridolin.somers@biblibre.com> --- cud-delete not for 23.11.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=37186 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Status|Needs documenting |RESOLVED --- Comment #11 from Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> --- Bug fix, nothing to add/edit in the manual. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org