[Bug 32445] New: Status display of 'not for loan' items is broken in OPAC/staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Bug ID: 32445 Summary: Status display of 'not for loan' items is broken in OPAC/staff Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: OPAC Assignee: oleonard@myacpl.org Reporter: katrin.fischer@bsz-bw.de QA Contact: testopia@bugs.koha-community.org This is a display issue, but marking as major since it affects a basic functionality in the OPAC: 1) Edit any item, item type should be for loan, so not set to reference. 2) Set Not for loan status to "not for loan". 3) Go to the staff detail page: 4) Verify it displays as: Not for loan (Not For Loan) Available The available should not be there! 5) Go to the OPAC detail page: 6) Verifiy the status displays as: Available This should display the not for loan status! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Depends on| |31321 --- Comment #1 from Fridolin Somers <fridolin.somers@biblibre.com> --- Looks like it is caused by Bug 31321 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #2 from Fridolin Somers <fridolin.somers@biblibre.com> --- Created attachment 144542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144542&action=edit Bug 32445: Fix display of 'not for loan' items in staff test plan : 1) Edit any item, item type should be for loan, so not set to reference. 2) Set Not for loan status to "not for loan". 3) Go to the staff detail page: => Without patch it displays as: Not for loan (Not For Loan) Available => With patch it displays as: Not for loan (Not For Loan) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Frido, did you see the bug in OPAC is worse? Not displaying at all. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #4 from Fridolin Somers <fridolin.somers@biblibre.com> --- For OPAC, I tried to fix : koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status-schema-org.inc You see there : item.itemnotforloan and item.notforloanvalueopac But I get lost with : NOT ( item.isa('Koha::Item') ) Is is still valid ? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31321 |27272 --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Ah its more a dependency on Bug 27272 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27272 [Bug 27272] Move C4::Items::GetItemsInfo to Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31321 [Bug 31321] Remove GetItemsInfo from catalogue/detail.pl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #6 from Lucas Gass <lucas@bywatersolutions.com> --- Does Bug 29198 seem like a duplicate of this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #7 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Fridolin Somers from comment #4)
For OPAC, I tried to fix : koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status.inc koha-tmpl/opac-tmpl/bootstrap/en/includes/item-status-schema-org.inc
You see there : item.itemnotforloan and item.notforloanvalueopac
But I get lost with : NOT ( item.isa('Koha::Item') ) Is is still valid ?
Yes, it's definitely valid. We don't always send a Koha::Item For instance in opac/opac-basket.pl 97 my $items = $biblio->items->filter_by_visible_in_opac({ patron => $logged_in_user })->unblessed; 137 $dat->{ITEM_RESULTS} = $items; -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #8 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to Lucas Gass from comment #6)
Does Bug 29198 seem like a duplicate of this one?
I don't think so. Here it's a regression from bug 27272. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com, tomascohen@gmail.com --- Comment #9 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is a real bad bug - no chance to fix for 22.11.01? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #10 from David Cook <dcook@prosentient.com.au> --- Yikes, where are we at with this one? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #11 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- (In reply to David Cook from comment #10)
Yikes, where are we at with this one?
Needing someone to assign the bug and write patches. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|oleonard@myacpl.org |jonathan.druart+koha@gmail. | |com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #12 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144926&action=edit Bug 32445: Fix availability display on opac-course-details -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #13 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144927&action=edit Bug 32445: Fix availability display on opac-basket Also fix holding branch Will display an empty span if no location, big deal? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #14 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144928&action=edit Bug 32445: Fix notforloan display -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #15 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144929&action=edit Bug 32445: Remove non-Koha::Item support from item-status.inc -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #16 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144930&action=edit Bug 32445: include item-status-schema-org.inc Can be discussed, but it will prevent to fetch several times the same related objects -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #17 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- This patch set suggests to remove the non-Koha::Item support from item-status.inc in order to make it more reliable. We are removing some specific code from pl scripts (opac-basket.pl, opac-course-details.pl) and pass a Koha::Item to item-status.inc where it was not the case already. It's hard to provide a full test plan. You should mostly focus on item availability in opac-detail, opac-basket and opac-course-details. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_22_11_candidate -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #18 from David Nind <david@davidnind.com> --- I've tested, and this now fixes the display for: - the record in the staff interface and OPAC - the cart in the OPAC For course reserves, the status is shown as: - OPAC: Programming error, item-status.inc must be called with a Koha::Item object. - Staff interface: Available How I tested (using KTD): 1. Replicated the issue (as per the bug description), and in addition I added a record/item to a course reserve and the cart (for both the OPAC and staff interface). 2. Applied the patch, flush_memcached, restart_all and cleared the browser cache. 3. Refreshed the pages. 4. Results: - this worked fine for the record/item in the staff interface and OPAC; and the cart in the OPAC - Didn't work for course reserves: the status in the staff interface shows as 'Available' (I guess this is right as it is available but can't be borrowed?), and in the OPAC shows as 'Programming error, item-status.inc must be called with a Koha::Item object.' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #19 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144971&action=edit Bug 32445: (follow-up) Fix availability display on opac-course-details This is reverting a change made by commit 52b5cdf79b53eb29173e92a7dfe0f76df135e7d9 Bug 19532: Recalls on OPAC Is it correct? I let a comment on bug 19532 comment 928 to ask for clarification. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19532 --- Comment #20 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- The changes made to opac-course-details seem to fix the availability there, that could have been broken by bug 19532. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #21 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Hi David, I fixed the "programming error", and the availability display at the OPAC for course reserves. But I think we need a separate bug to deal with it properly (as it exists in 22.05). -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha@catalyst.net.nz, | |m.de.rooy@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #22 from David Nind <david@davidnind.com> --- (In reply to Jonathan Druart from comment #21)
Hi David, I fixed the "programming error", and the availability display at the OPAC for course reserves. But I think we need a separate bug to deal with it properly (as it exists in 22.05).
Thanks Jonathan! An additional nuance for course reserves: - If I add an item to course reserves using an item barcode, everything works fine and there is no error displayed. - However, if I add it using the bibliographic number (such as 262), then I get the same error message as before. - In addition, if I add more items to course reserves after adding one using the biblio number, they are displayed on the staff interface list, but don't display in the OPAC list (hope this makes sense). David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #23 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 144978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144978&action=edit Bug 32445: Deal with biblio course reserve -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #24 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- (In reply to David Nind from comment #22) Should be fixed now! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144542|0 |1 is obsolete| | --- Comment #25 from David Nind <david@davidnind.com> --- Created attachment 144987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144987&action=edit Bug 32445: Fix display of 'not for loan' items in staff test plan : 1) Edit any item, item type should be for loan, so not set to reference. 2) Set Not for loan status to "not for loan". 3) Go to the staff detail page: => Without patch it displays as: Not for loan (Not For Loan) Available => With patch it displays as: Not for loan (Not For Loan) Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144926|0 |1 is obsolete| | --- Comment #26 from David Nind <david@davidnind.com> --- Created attachment 144988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144988&action=edit Bug 32445: Fix availability display on opac-course-details Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144927|0 |1 is obsolete| | --- Comment #27 from David Nind <david@davidnind.com> --- Created attachment 144989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144989&action=edit Bug 32445: Fix availability display on opac-basket Also fix holding branch Will display an empty span if no location, big deal? Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144928|0 |1 is obsolete| | --- Comment #28 from David Nind <david@davidnind.com> --- Created attachment 144990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144990&action=edit Bug 32445: Fix notforloan display Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144929|0 |1 is obsolete| | --- Comment #29 from David Nind <david@davidnind.com> --- Created attachment 144991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144991&action=edit Bug 32445: Remove non-Koha::Item support from item-status.inc Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144930|0 |1 is obsolete| | --- Comment #30 from David Nind <david@davidnind.com> --- Created attachment 144992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144992&action=edit Bug 32445: include item-status-schema-org.inc Can be discussed, but it will prevent to fetch several times the same related objects Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144971|0 |1 is obsolete| | --- Comment #31 from David Nind <david@davidnind.com> --- Created attachment 144993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144993&action=edit Bug 32445: (follow-up) Fix availability display on opac-course-details This is reverting a change made by commit 52b5cdf79b53eb29173e92a7dfe0f76df135e7d9 Bug 19532: Recalls on OPAC Is it correct? I let a comment on bug 19532 comment 928 to ask for clarification. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144978|0 |1 is obsolete| | --- Comment #32 from David Nind <david@davidnind.com> --- Created attachment 144994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=144994&action=edit Bug 32445: Deal with biblio course reserve Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144987|0 |1 is obsolete| | --- Comment #33 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145004&action=edit Bug 32445: Fix display of 'not for loan' items in staff test plan : 1) Edit any item, item type should be for loan, so not set to reference. 2) Set Not for loan status to "not for loan". 3) Go to the staff detail page: => Without patch it displays as: Not for loan (Not For Loan) Available => With patch it displays as: Not for loan (Not For Loan) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144988|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145005&action=edit Bug 32445: Fix availability display on opac-course-details Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144989|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145006&action=edit Bug 32445: Fix availability display on opac-basket Also fix holding branch Will display an empty span if no location, big deal? Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144990|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145007&action=edit Bug 32445: Fix notforloan display Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144991|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145008&action=edit Bug 32445: Remove non-Koha::Item support from item-status.inc Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144992|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145009&action=edit Bug 32445: include item-status-schema-org.inc Can be discussed, but it will prevent to fetch several times the same related objects Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144993|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145010&action=edit Bug 32445: (follow-up) Fix availability display on opac-course-details This is reverting a change made by commit 52b5cdf79b53eb29173e92a7dfe0f76df135e7d9 Bug 19532: Recalls on OPAC Is it correct? I let a comment on bug 19532 comment 928 to ask for clarification. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #144994|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Created attachment 145011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145011&action=edit Bug 32445: Deal with biblio course reserve Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #41 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice cleanup here Jonathan. All working as expected, no regressions found in testing. QA scripts happy too.. Passing QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC| |nick@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145004|0 |1 is obsolete| | --- Comment #42 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145014&action=edit Bug 32445: Fix display of 'not for loan' items in staff test plan : 1) Edit any item, item type should be for loan, so not set to reference. 2) Set Not for loan status to "not for loan". 3) Go to the staff detail page: => Without patch it displays as: Not for loan (Not For Loan) Available => With patch it displays as: Not for loan (Not For Loan) Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145005|0 |1 is obsolete| | --- Comment #43 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145015&action=edit Bug 32445: Fix availability display on opac-course-details Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145006|0 |1 is obsolete| | --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145016&action=edit Bug 32445: Fix availability display on opac-basket Also fix holding branch Will display an empty span if no location, big deal? Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145007|0 |1 is obsolete| | --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145017&action=edit Bug 32445: Fix notforloan display Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145008|0 |1 is obsolete| | --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145018&action=edit Bug 32445: Remove non-Koha::Item support from item-status.inc Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145009|0 |1 is obsolete| | --- Comment #47 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145019&action=edit Bug 32445: include item-status-schema-org.inc Can be discussed, but it will prevent to fetch several times the same related objects Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145010|0 |1 is obsolete| | --- Comment #48 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145020&action=edit Bug 32445: (follow-up) Fix availability display on opac-course-details This is reverting a change made by commit 52b5cdf79b53eb29173e92a7dfe0f76df135e7d9 Bug 19532: Recalls on OPAC Is it correct? I let a comment on bug 19532 comment 928 to ask for clarification. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #145011|0 |1 is obsolete| | --- Comment #49 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 145021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=145021&action=edit Bug 32445: Deal with biblio course reserve Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #50 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Thanks, Jonathan. This ended up being a nice cleanup along with the fix! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #51 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Jacob O'Mara <jacob.omara@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|23.05.00 |23.05.00,22.11.02 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #52 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 --- Comment #53 from Lucas Gass <lucas@bywatersolutions.com> --- Doesn't apply cleanly to 22.05.x, no backport. If needed please rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Frédéric Demians <frederic@tamil.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |33101 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33101 [Bug 33101] Basket More details view doesn't work -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=32611 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36281 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36281 [Bug 36281] Restricted info is displayed even if item is not restricted (OPAC details) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32445 Bug 32445 depends on bug 19532, which changed state. Bug 19532 Summary: Recalls for Koha https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org