https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32967 Aleisha Amohia <aleisha@catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19532 [Bug 19532] Recalls for Koha -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32967 --- Comment #1 from Aleisha Amohia <aleisha@catalyst.net.nz> --- Created attachment 146657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146657&action=edit Bug 32967: Fix PICKUP_RECALLED_ITEM and RECALL_REQUESTER_DET notices This patch fixes two recalls notices which are referencing old column names, so they leave empty fields when the notices are generated. To test: 1) Apply database updates and restart services 2) Go to Tools -> Notices 3) Find the RECALL_REQUESTER_DET notice, open the Print tab 4) Confirm there are no references to recalls.waitingdate or recalls.recallnotes. Confirm the reference is fixed to recalls.waiting_date and recalls.notes 5) Find the PICKUP_RECALLED_ITEM notice, open the Email tab 6) Confirm there are no references to recalls.branchcode or recalls.expirationdate. Confirm the reference is fixed to recalls.pickup_library_id and recalls.expiration_date Sponsored-by: Catalyst IT https://bugs.koha-community.org/show_bug.cgi?id=32697 -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32967 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146657|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 146699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=146699&action=edit Bug 32967: Fix PICKUP_RECALLED_ITEM and RECALL_REQUESTER_DET notices This patch fixes two recalls notices which are referencing old column names, so they leave empty fields when the notices are generated. To test: 1) Apply database updates and restart services 2) Go to Tools -> Notices 3) Find the RECALL_REQUESTER_DET notice, open the Print tab 4) Confirm there are no references to recalls.waitingdate or recalls.recallnotes. Confirm the reference is fixed to recalls.waiting_date and recalls.notes 5) Find the PICKUP_RECALLED_ITEM notice, open the Email tab 6) Confirm there are no references to recalls.branchcode or recalls.expirationdate. Confirm the reference is fixed to recalls.pickup_library_id and recalls.expiration_date Sponsored-by: Catalyst IT https://bugs.koha-community.org/show_bug.cgi?id=32697 Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32967 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32967 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #146699|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 147339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=147339&action=edit Bug 32967: Fix PICKUP_RECALLED_ITEM and RECALL_REQUESTER_DET notices This patch fixes two recalls notices which are referencing old column names, so they leave empty fields when the notices are generated. To test: 1) Apply database updates and restart services 2) Go to Tools -> Notices 3) Find the RECALL_REQUESTER_DET notice, open the Print tab 4) Confirm there are no references to recalls.waitingdate or recalls.recallnotes. Confirm the reference is fixed to recalls.waiting_date and recalls.notes 5) Find the PICKUP_RECALLED_ITEM notice, open the Email tab 6) Confirm there are no references to recalls.branchcode or recalls.expirationdate. Confirm the reference is fixed to recalls.pickup_library_id and recalls.expiration_date Sponsored-by: Catalyst IT https://bugs.koha-community.org/show_bug.cgi?id=32697 Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32967 --- Comment #4 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.05. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32967 --- Comment #5 from Jacob O'Mara <jacob.omara@ptfs-europe.com> --- Nice work, thanks everyone! Pushed to 22.11.x for the next release. -- You are receiving this mail because: You are watching all bug changes.