[Bug 34398] New: Inconsistencies in Record matching rules page titles, breadcrumbs, and header
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Bug ID: 34398 Summary: Inconsistencies in Record matching rules page titles, breadcrumbs, and header Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: caroline.cyr-la-rose@inlibro.com QA Contact: testopia@bugs.koha-community.org While testing bug 33909, I had to look at all the pages in the administration module. In doing so, I found some inconsistencies between the various pages. For the Record matching rules page, here is what should be changed to make it consistent with the other pages in the module: Page title - Change 'Add record matching rule' to 'New record matching rule' - Add rule code in single quotes to 'Modify record matching rule' Breadcrumb - Change 'Add record matching rule' to 'New record matching rule' - Add rule code in single quotes to 'Modify record matching rule' Page header - Change 'Add record matching rule' to 'New record matching rule' - Add rule code in single quotes to 'Modify record matching rule' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |34396 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34396 [Bug 34396] [OMNIBUS] Inconsistencies in page titles, breadcrumbs, and page headers -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 156509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156509&action=edit Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the record matching rules administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Some controls on this page have been updated to use Bootstrap link style with Font Awesome icons added. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Record matching rules - New record matching rule - Edit record matching rule - Delete record matching rule - Test the process of adding new match points and new match checks, and removing match points and match checks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Keywords| |Sandbox -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Katy Maydon <maydonk@regents.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maydonk@regents.ac.uk --- Comment #2 from Katy Maydon <maydonk@regents.ac.uk> --- Testing on 02/11/23: - Administration -> Record matching rules - New record matching rule Title - good Heading - good Breadcrumbs - good - Edit record matching rule Heading - good Breadcrumbs - good - Delete record matching rule Heading - good Breadcrumbs - good - Test the process of adding new match points and new match checks, and removing match points and match checks. I don't know if this is an issue, but when you add a new match check or point, remove it and then add another it adds "2" then when you remove 2, it adds "3" instead of another 2, even though you didn't save the original "2". -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #156509|0 |1 is obsolete| | --- Comment #3 from David Nind <david@davidnind.com> --- Created attachment 159505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159505&action=edit Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the record matching rules administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Some controls on this page have been updated to use Bootstrap link style with Font Awesome icons added. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Record matching rules - New record matching rule - Edit record matching rule - Delete record matching rule - Test the process of adding new match points and new match checks, and removing match points and match checks. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david@davidnind.com --- Comment #4 from David Nind <david@davidnind.com> --- (In reply to Katy Maydon from comment #2)
Testing on 02/11/23:
...
I don't know if this is an issue, but when you add a new match check or point, remove it and then add another it adds "2" then when you remove 2, it adds "3" instead of another 2, even though you didn't save the original "2".
Hi Katy. It does this before the patch, so I think that would be a separate bug. David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #159505|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159692&action=edit Bug 34398: Fix inconsistencies in Record matching rules page titles, breadcrumbs, and headers This patch fixes some inconsistencies in the record matching rules administration page, making sure the page title, breadcrumb navigation, and page headers are consistent with each other. Some controls on this page have been updated to use Bootstrap link style with Font Awesome icons added. Test each page to confirm that page title, heading, and breadcrumbs are consistent: - Administration -> Record matching rules - New record matching rule - Edit record matching rule - Delete record matching rule - Test the process of adding new match points and new match checks, and removing match points and match checks. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 --- Comment #6 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Created attachment 159693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=159693&action=edit Bug 34398: (QA follow-up): add missing | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Victor Grousset/tuxayo <victor@tuxayo.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |victor@tuxayo.net QA Contact|testopia@bugs.koha-communit |victor@tuxayo.net |y.org | --- Comment #7 from Victor Grousset/tuxayo <victor@tuxayo.net> --- Much cleaner, looks great :) Works, makes sense, QA script happy, code looks good, passing QA :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m Version(s)|24.05.00 |24.05.00,23.11.01 released in| | --- Comment #9 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.01 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com --- Comment #10 from Lucas Gass <lucas@bywatersolutions.com> --- Merge conflicts with 23.05.x, no backport. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|martin.renvoize@ptfs-europe | |.com | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34398 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org