[Bug 35395] New: Update description of DefaultPatronSearchMethod
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Bug ID: 35395 Summary: Update description of DefaultPatronSearchMethod Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: System Administration Assignee: koha-bugs@lists.koha-community.org Reporter: magnus@libriotech.no QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com DefaultPatronSearchMethod was added in bug 33117. The description is: - pref: DefaultPatronSearchMethod choices: starts_with: "Starts with" contains: "Contains" - Enable this search method to determine whether to use Starts with or Contains for autocomplete patron searches. The original name of the syspref was PatronAutoCompleteSearchMethod, but this was changed in attachment 152564, with this comment: "As it's been requested that we keep the search defaults consistent, I think this preference is better names DefaultPatronSearchMethod and appear next to DefaultPatronSearchFields. This patch makes that change, though actually applying it to the other search area's (outside of autocomplete) has been left for another bug." I *think* the "another bug" is bug 35127, but at least testing shows that DefaultPatronSearchMethod now applies to the actual search as well as the autocomplete. So the description of DefaultPatronSearchMethod should be updated so it is clear that it applies both to autocomplete and the actual search. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 160604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160604&action=edit Bug 35395: Update DefaultPatronSearchMethod system preference description This updates the system preference description of DefaultPatronSearchMethod so that it's clear that the preference applies to all patron searches, including patron module search and auto-completes. To test: * Search for DefaultPatronSearchMethod system preference in administration * Verify the setting is reflected in the filters of the patron search * Apply patch * Verify that the description now is now improved. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160604|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 160611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160611&action=edit Bug 35395: Update DefaultPatronSearchMethod system preference description This updates the system preference description of DefaultPatronSearchMethod so that it's clear that the preference applies to all patron searches, including patron module search and auto-completes. To test: * Search for DefaultPatronSearchMethod system preference in administration * Verify the setting is reflected in the filters of the patron search * Apply patch * Verify that the description now is now improved. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #160611|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 160624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=160624&action=edit Bug 35395: Update DefaultPatronSearchMethod system preference description This updates the system preference description of DefaultPatronSearchMethod so that it's clear that the preference applies to all patron searches, including patron module search and auto-completes. To test: * Search for DefaultPatronSearchMethod system preference in administration * Verify the setting is reflected in the filters of the patron search * Apply patch * Verify that the description now is now improved. Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Nick Clemens <nick@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |24.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Pushed for 24.05! Well done everyone, thank you! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|24.05.00 |24.05.00,23.11.02 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers@biblibre.co | |m --- Comment #5 from Fridolin Somers <fridolin.somers@biblibre.com> --- Pushed to 23.11.x for 23.11.02 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35395 Lucas Gass (lukeg) <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org