[Bug 16420] New: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Bug ID: 16420 Summary: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs@lists.koha-community.org Reporter: jweaver@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com "Hold found": "Confirm hold", "Print slip and confirm" and "Ignore" "Hold found (item is already waiting)": "Confirm", "Cancel hold", "Print and confirm" We should settle on one ordering and wording; the current approach is both bad for translators and confusing for librarians. It's all too easy to reach for the middle button out of muscle memory and cancel a hold! I would argue that the wording and ordering of the "Hold found" dialog is more natural, so the waiting dialog should be changed to the following: "Confirm hold", "Print slip and confirm", "Cancel hold" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 80144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80144&action=edit Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin This patch makes minor changes to the text of hold confirmation buttons in the checkin process in order to make them more consistent. Also changed: Removed the "danger" class from the "Ignore" button for readability and consistency's sake. To test, apply the patch and check in an item which is on hold for a patron at your logged-in library. The hold confirmation dialog's buttons should read "Confirm hold," "Print slip and confirm," and "Ignore." Confirm the hold, then check in the same item again. In the dialog, the buttons should read "Confirm hold," "Print slip and confirm," and "Cancel hold." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Michal Denar <black23@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80144|0 |1 is obsolete| | --- Comment #2 from Michal Denar <black23@gmail.com> --- Created attachment 80145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80145&action=edit Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin This patch makes minor changes to the text of hold confirmation buttons in the checkin process in order to make them more consistent. Also changed: Removed the "danger" class from the "Ignore" button for readability and consistency's sake. To test, apply the patch and check in an item which is on hold for a patron at your logged-in library. The hold confirmation dialog's buttons should read "Confirm hold," "Print slip and confirm," and "Ignore." Confirm the hold, then check in the same item again. In the dialog, the buttons should read "Confirm hold," "Print slip and confirm," and "Cancel hold." Signed-off-by: Michal Denar <black23@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80145|0 |1 is obsolete| | --- Comment #3 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 80242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80242&action=edit Bug 16420: Buttons inconsistent between "Hold found" and "Hold found (waiting)" dialogs in checkin This patch makes minor changes to the text of hold confirmation buttons in the checkin process in order to make them more consistent. Also changed: Removed the "danger" class from the "Ignore" button for readability and consistency's sake. To test, apply the patch and check in an item which is on hold for a patron at your logged-in library. The hold confirmation dialog's buttons should read "Confirm hold," "Print slip and confirm," and "Ignore." Confirm the hold, then check in the same item again. In the dialog, the buttons should read "Confirm hold," "Print slip and confirm," and "Cancel hold." Signed-off-by: Michal Denar <black23@gmail.com> Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 18.05.x for 18.05.05 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16420 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Pushed to 17.11.x for 17.11.12 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org