[Bug 20941] New: Displaying requests does not display request material type
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Bug ID: 20941 Summary: Displaying requests does not display request material type Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs@lists.koha-community.org Reporter: andrew.isherwood@ptfs-europe.com I'm not sure when this crept in. At some point we switched from storing material type in illrequests.medium to an arbitrary attribute in illrequestattributes. However, the display end of things wasn't updated accordingly. As such, material type doesn't display in any of the UIs, it should! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |andrew.isherwood@ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #1 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 76052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=76052&action=edit Bug 20941: Add Illrequest->getType method This patch adds a method to the Illrequest object enabling it to return its type, which is stored as an Illrequestattribute object To observe broken state: - Do not apply patch - Ensure you have at least one Interlibrary loan created - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column is not populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row is not populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row is not populated To Test: - Apply patch - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column IS populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row IS populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row IS populated -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |7317 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Bug 20941 depends on bug 7317, which changed state. Bug 7317 Summary: Add an Interlibrary Loan Module to Circulation and OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76052|0 |1 is obsolete| | --- Comment #2 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 79577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79577&action=edit Bug 20941: Add Illrequest->getType method This patch adds a method to the Illrequest object enabling it to return its type, which is stored as an Illrequestattribute object To observe broken state: - Do not apply patch - Ensure you have at least one Interlibrary loan created - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column is not populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row is not populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row is not populated To Test: - Apply patch - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column IS populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row IS populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row IS populated Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #3 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 79825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79825&action=edit Bug 20941: Add unit tests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #4 from Josef Moravec <josef.moravec@gmail.com> --- Comment on attachment 79577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79577 Bug 20941: Add Illrequest->getType method Review of attachment 79577: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20941&attachment=79577) ----------------------------------------------------------------- ::: Koha/Illrequest.pm @@ +724,4 @@
|| ""; # "the empty prefix" }
+=head3 getType
should be get_type, or maybe better get_material_type, please rename the method @@ +734,5 @@
+ +sub getType { + my ($self) = @_; + my $attr = $self->illrequestattributes->find({ type => 'type'}); + return $attr ? $attr->value : '<span>N/A</span>';
We should return implicit undef if no type is set and then handle it in templates. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact| |josef.moravec@gmail.com CC| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #5 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 79865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79865&action=edit Bug 20941: (follow-up) Carry out comment #4 advice - Switch getType -> get_type - get_type now returns a type or undef - Ternary now performed in template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #6 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Thanks for the review Joseph, all great points, much appreciated. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #7 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- s/ph$/f/ (sorry!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79577|0 |1 is obsolete| | Attachment #79825|0 |1 is obsolete| | Attachment #79865|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79918&action=edit Bug 20941: Add Illrequest->getType method This patch adds a method to the Illrequest object enabling it to return its type, which is stored as an Illrequestattribute object To observe broken state: - Do not apply patch - Ensure you have at least one Interlibrary loan created - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column is not populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row is not populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row is not populated To Test: - Apply patch - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column IS populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row IS populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row IS populated Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #9 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79919&action=edit Bug 20941: Add unit tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #10 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79920&action=edit Bug 20941: (follow-up) Carry out comment #4 advice - Switch getType -> get_type - get_type now returns a type or undef - Ternary now performed in template Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #11 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 79921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79921&action=edit Bug 20941: (QA follow-up) Fix return value of get_type, make templates more consistant Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Josef Moravec <josef.moravec@gmail.com> --- I added a follow-up: - in get_type the return could be explicit undef, which is wrong - the test needed to adjust to test for undef when no type is set - in templates I changed ?: to || for consistancy - in opac templates I removed span tag I've also added filters during rebase -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #13 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Thanks for that Josef, much better! The inclusion of the span was based on advice I've been given in the past that wrapping strings with a span aids with translation, though I'm not clear how. Anyway, many thanks for your work on this, it's much appreciated! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #14 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Andrew Isherwood from comment #13)
Thanks for that Josef, much better! The inclusion of the span was based on advice I've been given in the past that wrapping strings with a span aids with translation, though I'm not clear how. Anyway, many thanks for your work on this, it's much appreciated!
Yes it is right, I saw you done that on other patches... so maybe we should do it here right now... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #15 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 79945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79945&action=edit Bug 20941: (follow-up) Wrap N/A strings in <span> All N/A strings in ILL templates wrapped in <span> to aid translation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #16 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Hi Josef, I've now wrapped all N/A in <span> tags, so this should be correct and consistent now. Many thanks. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de --- Comment #17 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- It would be good to test that this construct actually gets picked up. I am not sure if our script look for HTML inside the TT constructs... I think it would be safer not to take shortcuts here: [% request.cost || '<span>N/A</span>' | html %] Could also be: [% IF ( request.cost ) %][%request.cost%][% ELSE %]<span>N/A</span>[% END %] To test, in koha-shell you can do: cd misc/translator perl translate update de-DE (or any other language) Then check the updated po files for N/A. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #18 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- ... also... should the html filter not escape that? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #19 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- [% request.cost | html %] of course (update your QA script!) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #20 from Josef Moravec <josef.moravec@gmail.com> --- (In reply to Katrin Fischer from comment #17)
It would be good to test that this construct actually gets picked up. I am not sure if our script look for HTML inside the TT constructs... I think it would be safer not to take shortcuts here:
[% request.cost || '<span>N/A</span>' | html %]
True, this also has problem, that html tags are escaped an showed to user...
Could also be:
[% IF ( request.cost ) %][%request.cost%][% ELSE %]<span>N/A</span>[% END %]
Thanks Katrin, that's the way it should be done...
To test, in koha-shell you can do:
cd misc/translator perl translate update de-DE (or any other language)
Then check the updated po files for N/A.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #21 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Thanks very much for that Katrin. I'll create a follow up for these today. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #22 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 79999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79999&action=edit Bug 20941: (follow-up) Update N/A handling Modify the conditional display of N/A in accordance with comment #17 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 [Bug 18591] Allow an arbitrary number of comments on ILLs -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79918|0 |1 is obsolete| | --- Comment #23 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80112&action=edit Bug 20941: Add Illrequest->getType method This patch adds a method to the Illrequest object enabling it to return its type, which is stored as an Illrequestattribute object To observe broken state: - Do not apply patch - Ensure you have at least one Interlibrary loan created - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column is not populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row is not populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row is not populated To Test: - Apply patch - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column IS populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row IS populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row IS populated Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79919|0 |1 is obsolete| | --- Comment #24 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80113&action=edit Bug 20941: Add unit tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79920|0 |1 is obsolete| | --- Comment #25 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80114&action=edit Bug 20941: (follow-up) Carry out comment #4 advice - Switch getType -> get_type - get_type now returns a type or undef - Ternary now performed in template Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79921|0 |1 is obsolete| | --- Comment #26 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80115&action=edit Bug 20941: (QA follow-up) Fix return value of get_type, make templates more consistant Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79945|0 |1 is obsolete| | --- Comment #27 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80116&action=edit Bug 20941: (follow-up) Wrap N/A strings in <span> All N/A strings in ILL templates wrapped in <span> to aid translation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79999|0 |1 is obsolete| | --- Comment #28 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80117&action=edit Bug 20941: (follow-up) Update N/A handling Modify the conditional display of N/A in accordance with comment #17 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off QA Contact|josef.moravec@gmail.com |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80112|0 |1 is obsolete| | Attachment #80113|0 |1 is obsolete| | Attachment #80114|0 |1 is obsolete| | Attachment #80115|0 |1 is obsolete| | Attachment #80116|0 |1 is obsolete| | Attachment #80117|0 |1 is obsolete| | --- Comment #29 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80127&action=edit Bug 20941: Add Illrequest->getType method This patch adds a method to the Illrequest object enabling it to return its type, which is stored as an Illrequestattribute object To observe broken state: - Do not apply patch - Ensure you have at least one Interlibrary loan created - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column is not populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row is not populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row is not populated To Test: - Apply patch - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column IS populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row IS populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row IS populated Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #30 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80128&action=edit Bug 20941: Add unit tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #31 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80129&action=edit Bug 20941: (follow-up) Carry out comment #4 advice - Switch getType -> get_type - get_type now returns a type or undef - Ternary now performed in template Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #32 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80130&action=edit Bug 20941: (QA follow-up) Fix return value of get_type, make templates more consistant Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80131&action=edit Bug 20941: (follow-up) Wrap N/A strings in <span> All N/A strings in ILL templates wrapped in <span> to aid translation -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 80132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80132&action=edit Bug 20941: (follow-up) Update N/A handling Modify the conditional display of N/A in accordance with comment #17 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- There are some weird things going on: - Add a new requst with free form - Edit item metadata - The Type pull down is empty This seems to be a spelling mismatch. The type for new requests saves with the first letter being lower case (article) while the the pull downs look for (Article) I am also not clear on the switch from medium to type, there are still lines like these in the code: media => [ "Book", "Article", "Journal" ], (ill-requests.pl) Can we clear this up? It's also a little odd that the rquest type shows in 2 places, in the "Request details" and the "Details from supplier" sections. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #36 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Created attachment 80212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80212&action=edit Bug 20941: (follow-up) Switch 'media' -> 'types' Clearing up the inconsistency mentioned in comment #35. There is one place where we use the term 'media' for a template variable, everywhere we refer to material types as 'types'. NOTE: This is a breaking change for existing backends that still use 'media'. Of the PTFS Europe backends, only the Koha backend uses it, this will be modified as necessary. Generally backends will supply this variable themselves, so the breaking-ness of this change should be minimal. No test plan as it's backend dependent. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #37 from Andrew Isherwood <andrew.isherwood@ptfs-europe.com> --- Responses to comment #35:
This seems to be a spelling mismatch. The type for new requests saves with the first letter being lower case (article) while the the pull downs look for (Article) This was a bug in the FreeForm backend and has now been fixed. Details: https://github.com/PTFS-Europe/koha-ill-freeform/commit/ddff82bc9adc4bd72051...
I am also not clear on the switch from medium to type, there are still lines like these in the code: media => [ "Book", "Article", "Journal" ], (ill-requests.pl) This has been fixed, see comment #36
It's also a little odd that the rquest type shows in 2 places, in the "Request details" and the "Details from supplier" sections. The details listed here are all metadata relating to the request and will be dependent on the backend from which the request was made, some backends (BLDSS for example) won't even include "type". Whether this display is even necessary is debatable, since bug 20561 added a modal that displays all this information, it just formats it a bit less nicely. I think there's room for improvement in this area, but would suggest it as a future enhancement rather than addressing it here.
-- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize@ptfs-europe | |.com Depends on|7317 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7317 [Bug 7317] Add an Interlibrary Loan Module to Circulation and OPAC -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer@bsz-bw.de | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20548 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20548 [Bug 20548] Remove copyright clearance workflow from staff created ILL requests -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Andrew Isherwood <andrew.isherwood@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|18589 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Hi Andrew, switching back to signed-off with your follow-up -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Paul Thornton <paul.thornton@educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.thornton@educampus.ie -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80127|0 |1 is obsolete| | Attachment #80128|0 |1 is obsolete| | Attachment #80129|0 |1 is obsolete| | Attachment #80130|0 |1 is obsolete| | Attachment #80131|0 |1 is obsolete| | Attachment #80132|0 |1 is obsolete| | Attachment #80212|0 |1 is obsolete| | --- Comment #39 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81688&action=edit Bug 20941: Add Illrequest->getType method This patch adds a method to the Illrequest object enabling it to return its type, which is stored as an Illrequestattribute object To observe broken state: - Do not apply patch - Ensure you have at least one Interlibrary loan created - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column is not populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row is not populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row is not populated To Test: - Apply patch - In OPAC view, go to "your interlibrary loan requests" - => TEST: Observe that the "Request type" column IS populated - Click on "View" for one of the requests - => TEST: Observer that the "Request type" row IS populated - In Staff view, go to "ILL requests" - Click on "Manage request" on a request - => TEST: Observer that the "Request type" row IS populated Signed-off-by: Niamh.Walker-Headon@it-tallaght.ie Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #40 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81689&action=edit Bug 20941: Add unit tests Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #41 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81690&action=edit Bug 20941: (follow-up) Carry out comment #4 advice - Switch getType -> get_type - get_type now returns a type or undef - Ternary now performed in template Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #42 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81691&action=edit Bug 20941: (QA follow-up) Fix return value of get_type, make templates more consistant Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #43 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81692&action=edit Bug 20941: (follow-up) Wrap N/A strings in <span> All N/A strings in ILL templates wrapped in <span> to aid translation Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #44 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81693&action=edit Bug 20941: (follow-up) Update N/A handling Modify the conditional display of N/A in accordance with comment #17 Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 --- Comment #45 from Josef Moravec <josef.moravec@gmail.com> --- Created attachment 81694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81694&action=edit Bug 20941: (follow-up) Switch 'media' -> 'types' Clearing up the inconsistency mentioned in comment #35. There is one place where we use the term 'media' for a template variable, everywhere we refer to material types as 'types'. NOTE: This is a breaking change for existing backends that still use 'media'. Of the PTFS Europe backends, only the Koha backend uses it, this will be modified as necessary. Generally backends will supply this variable themselves, so the breaking-ness of this change should be minimal. No test plan as it's backend dependent. Signed-off-by: Josef Moravec <josef.moravec@gmail.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Josef Moravec <josef.moravec@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec@gmail.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick@bywatersolutions.com --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- Awesome work all! Pushed to master for 18.11 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Bug 20941 depends on bug 18591, which changed state. Bug 18591 Summary: Allow an arbitrary number of comments on ILLs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18591 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20941 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |fridolin.somers@biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org