[Bug 34517] New: Add option to search patron attribute in standard search
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Bug ID: 34517 Summary: Add option to search patron attribute in standard search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs@lists.koha-community.org Reporter: nick@bywatersolutions.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com, kyle.m.hall@gmail.com Currently if a patron attribute is marked 'staff_searchable' it is always searched when using a 'standard search' It should be possible to make attributes searchable without searching them by default -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |34519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #1 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154389&action=edit Bug 34517: DB updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #2 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154390&action=edit Bug 34517: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #3 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154391&action=edit Bug 34517: Add boolean to search columns for schema -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #4 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154392&action=edit Bug 34517: Add option search patron attributes by default This patch moves form any staff_searchable attribute being automatically included in the the Standard patron serch, to allowing the librarian to choose. Current searchable attributes will be marked as 'searched_by_default' To test: 1 - Add a searchable patron attribute type 2 - Add some values 3 - Confirm they are searched in a 'Standard' patron search 4 - Apply patch 5 - Go to admin - >patron attribute types 6 - Note new 'Searching' column 7 - Confirm attribute is 'Searched by default' 8 - Confirm searches work as before 9 - Edit the attribute type 10 - Uncheck 'searched_by_default' 11 - Save 12 - Confirm attribute not searched in 'Standard' search 13 - Select the attribute in patron search dropdowns 14 - Confirm it is correctly searched -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com Assignee|koha-bugs@lists.koha-commun |nick@bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |inkeri.hakulinen+bugz@helsi | |nki.fi --- Comment #5 from Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> --- At the test phase step 13 the new patron attribute does not appear in any dropdown menus, so I cannot test if it's searchable or not. Other steps until that work as planned. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Inkeri Hakulinen <inkeri.hakulinen+bugz@helsinki.fi> --- I tested this but I couldn't get it working. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Kelly McElligott <kelly@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly@bywatersolutions.com --- Comment #7 from Kelly McElligott <kelly@bywatersolutions.com> --- REVISED test plan- removing step 13 from previous test plan. This option view is another bug! Created attachment 154392 [details] [review] Bug 34517: Add option search patron attributes by default This patch moves form any staff_searchable attribute being automatically included in the the Standard patron serch, to allowing the librarian to choose. Current searchable attributes will be marked as 'searched_by_default' To test: 1 - Add a searchable patron attribute type 2 - Add some values 3 - Confirm they are searched in a 'Standard' patron search 4 - Apply patch 5 - Go to admin - >patron attribute types 6 - Note new 'Searching' column 7 - Confirm attribute is 'Searched by default' 8 - Confirm searches work as before 9 - Edit the attribute type 10 - Uncheck 'searched_by_default' 11 - Save 12 - Confirm attribute not searched in 'Standard' search 13 - Confirm it is correctly searched -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.auld@ptfs-europe.com --- Comment #8 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Something broke when I applied the patch on the sandbox and went back to Patron Attributes in admin -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|34519 |26916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 [Bug 26916] Show searchable patron attributes in patron search dropdown https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34519 [Bug 34519] Add a template plugin for ExtendedAttributeTypes to fetch searchable patron attributes -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154389|0 |1 is obsolete| | Attachment #154390|0 |1 is obsolete| | Attachment #154391|0 |1 is obsolete| | Attachment #154392|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154575&action=edit Bug 34517: DB updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #10 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154576&action=edit Bug 34517: DO NOT PUSH - Schema Updates -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #11 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154577&action=edit Bug 34517: Add boolean to search columns for schema -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #12 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 154578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154578&action=edit Bug 34517: Add option search patron attributes by default This patch moves form any staff_searchable attribute being automatically included in the the Standard patron serch, to allowing the librarian to choose. Current searchable attributes will be marked as 'searched_by_default' To test: 1 - Add a searchable patron attribute type 2 - Add some values 3 - Confirm they are searched in a 'Standard' patron search 4 - Apply patch 5 - Go to admin - >patron attribute types 6 - Note new 'Searching' column 7 - Confirm attribute is 'Searched by default' 8 - Confirm searches work as before 9 - Edit the attribute type 10 - Uncheck 'searched_by_default' 11 - Save 12 - Confirm attribute not searched in 'Standard' search 13 - Select the attribute in patron search dropdowns 14 - Confirm it is correctly searched -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #13 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Andrew Auld from comment #8)
Something broke when I applied the patch on the sandbox and went back to Patron Attributes in admin
Dependencies reordered and rebased, should work now -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154575|0 |1 is obsolete| | --- Comment #14 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154608&action=edit Bug 34517: DB updates Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154576|0 |1 is obsolete| | --- Comment #15 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154610&action=edit Bug 34517: DO NOT PUSH - Schema Updates Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154577|0 |1 is obsolete| | --- Comment #16 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154611&action=edit Bug 34517: Add boolean to search columns for schema Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154578|0 |1 is obsolete| | --- Comment #17 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154612&action=edit Bug 34517: Add option search patron attributes by default This patch moves form any staff_searchable attribute being automatically included in the the Standard patron serch, to allowing the librarian to choose. Current searchable attributes will be marked as 'searched_by_default' To test: 1 - Add a searchable patron attribute type 2 - Add some values 3 - Confirm they are searched in a 'Standard' patron search 4 - Apply patch 5 - Go to admin - >patron attribute types 6 - Note new 'Searching' column 7 - Confirm attribute is 'Searched by default' 8 - Confirm searches work as before 9 - Edit the attribute type 10 - Uncheck 'searched_by_default' 11 - Save 12 - Confirm attribute not searched in 'Standard' search 13 - Select the attribute in patron search dropdowns 14 - Confirm it is correctly searched Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154608|0 |1 is obsolete| | --- Comment #18 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154613&action=edit Bug 34517: DB updates Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154610|0 |1 is obsolete| | --- Comment #19 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154614&action=edit Bug 34517: DO NOT PUSH - Schema Updates Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154611|0 |1 is obsolete| | --- Comment #20 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154615&action=edit Bug 34517: Add boolean to search columns for schema Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154612|0 |1 is obsolete| | --- Comment #21 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154616&action=edit Bug 34517: Add option search patron attributes by default This patch moves form any staff_searchable attribute being automatically included in the the Standard patron serch, to allowing the librarian to choose. Current searchable attributes will be marked as 'searched_by_default' To test: 1 - Add a searchable patron attribute type 2 - Add some values 3 - Confirm they are searched in a 'Standard' patron search 4 - Apply patch 5 - Go to admin - >patron attribute types 6 - Note new 'Searching' column 7 - Confirm attribute is 'Searched by default' 8 - Confirm searches work as before 9 - Edit the attribute type 10 - Uncheck 'searched_by_default' 11 - Save 12 - Confirm attribute not searched in 'Standard' search 13 - Select the attribute in patron search dropdowns 14 - Confirm it is correctly searched Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154613|0 |1 is obsolete| | --- Comment #22 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154617&action=edit Bug 34517: DB updates Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154614|0 |1 is obsolete| | --- Comment #23 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154618&action=edit Bug 34517: DO NOT PUSH - Schema Updates Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154615|0 |1 is obsolete| | --- Comment #24 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154619&action=edit Bug 34517: Add boolean to search columns for schema Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154616|0 |1 is obsolete| | --- Comment #25 from PTFS Europe Sandboxes <sandboxes@ptfs-europe.com> --- Created attachment 154620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154620&action=edit Bug 34517: Add option search patron attributes by default This patch moves form any staff_searchable attribute being automatically included in the the Standard patron serch, to allowing the librarian to choose. Current searchable attributes will be marked as 'searched_by_default' To test: 1 - Add a searchable patron attribute type 2 - Add some values 3 - Confirm they are searched in a 'Standard' patron search 4 - Apply patch 5 - Go to admin - >patron attribute types 6 - Note new 'Searching' column 7 - Confirm attribute is 'Searched by default' 8 - Confirm searches work as before 9 - Edit the attribute type 10 - Uncheck 'searched_by_default' 11 - Save 12 - Confirm attribute not searched in 'Standard' search 13 - Select the attribute in patron search dropdowns 14 - Confirm it is correctly searched Signed-off-by: Andrew <andrew.auld@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Andrew Auld <andrew.auld@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #26 from Andrew Auld <andrew.auld@ptfs-europe.com> --- Sorry for multiple Sandbox sign-offs...something was glitchy in the connection and it kept failing, but obviously it wasn't! Great patches, thanks Nick! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154617|0 |1 is obsolete| | --- Comment #27 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 154622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154622&action=edit Bug 34517: DB updates Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154618|0 |1 is obsolete| | --- Comment #28 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 154623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154623&action=edit Bug 34517: DO NOT PUSH - Schema Updates Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154619|0 |1 is obsolete| | --- Comment #29 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 154624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154624&action=edit Bug 34517: Add boolean to search columns for schema Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 ByWater Sandboxes <bws.sandboxes@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154620|0 |1 is obsolete| | --- Comment #30 from ByWater Sandboxes <bws.sandboxes@gmail.com> --- Created attachment 154625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=154625&action=edit Bug 34517: Add option search patron attributes by default This patch moves form any staff_searchable attribute being automatically included in the the Standard patron serch, to allowing the librarian to choose. Current searchable attributes will be marked as 'searched_by_default' To test: 1 - Add a searchable patron attribute type 2 - Add some values 3 - Confirm they are searched in a 'Standard' patron search 4 - Apply patch 5 - Go to admin - >patron attribute types 6 - Note new 'Searching' column 7 - Confirm attribute is 'Searched by default' 8 - Confirm searches work as before 9 - Edit the attribute type 10 - Uncheck 'searched_by_default' 11 - Save 12 - Confirm attribute not searched in 'Standard' search 13 - Select the attribute in patron search dropdowns 14 - Confirm it is correctly searched Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=31867 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=33554 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart+koha@gmail. | |com --- Comment #31 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- What's the use case? What are you trying to solve here? -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #32 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #31)
What's the use case? What are you trying to solve here?
Not every attribute that a library wants to search needs to be searched every time. Libraries may have alternate IDs or other fields that they wish to search on their own, and not as part of the standard search. The dependency adds those to the search options, so this then allows removing from standard search -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #33 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Currently blocked by depending patch not applying. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Nick Clemens <nick@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154622|0 |1 is obsolete| | --- Comment #34 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158429&action=edit Bug 34517: DB updates Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154623|0 |1 is obsolete| | --- Comment #35 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158430&action=edit Bug 34517: DO NOT PUSH - Schema Updates Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154624|0 |1 is obsolete| | --- Comment #36 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158431&action=edit Bug 34517: Add boolean to search columns for schema Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #154625|0 |1 is obsolete| | --- Comment #37 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158432&action=edit Bug 34517: Add option search patron attributes by default This patch moves form any staff_searchable attribute being automatically included in the the Standard patron serch, to allowing the librarian to choose. Current searchable attributes will be marked as 'searched_by_default' To test: 1 - Add a searchable patron attribute type 2 - Add some values 3 - Confirm they are searched in a 'Standard' patron search 4 - Apply patch 5 - Go to admin - >patron attribute types 6 - Note new 'Searching' column 7 - Confirm attribute is 'Searched by default' 8 - Confirm searches work as before 9 - Edit the attribute type 10 - Uncheck 'searched_by_default' 11 - Save 12 - Confirm attribute not searched in 'Standard' search 13 - Select the attribute in patron search dropdowns 14 - Confirm it is correctly searched Signed-off-by: Kelly McElligott <kelly@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #38 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 158433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158433&action=edit Bug 34517: (QA follow-up) Perltidy and fix column check Without the fix a second run of the database update would fail. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #39 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- IMO selenium tests are required for any changes to patron search. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #40 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 David Cook <dcook@prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook@prosentient.com.au --- Comment #41 from David Cook <dcook@prosentient.com.au> --- (In reply to Jonathan Druart from comment #39)
IMO selenium tests are required for any changes to patron search.
It looks like a recent change (possibly this one) has broken ./t/db_dependent/selenium/patrons_search.t Taking a look now... -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #42 from David Cook <dcook@prosentient.com.au> --- (In reply to David Cook from comment #41)
(In reply to Jonathan Druart from comment #39)
IMO selenium tests are required for any changes to patron search.
It looks like a recent change (possibly this one) has broken ./t/db_dependent/selenium/patrons_search.t
Taking a look now...
Yep, this is the change that broke subtests 22, 23, and 24 in ./t/db_dependent/selenium/patrons_search.t not ok 22 - Searching on a searchable attribute returns correct results # Failed test 'Searching on a searchable attribute returns correct results' # at ./t/db_dependent/selenium/patrons_search.t line 277. # got: 'No entries to show (filtered from 80 total entries)' # expected: 'Showing 1 to 2 of 2 entries (filtered from 80 total entries)' not ok 23 - Refining with DataTables search works to further filter the original query # Failed test 'Refining with DataTables search works to further filter the original query' # at ./t/db_dependent/selenium/patrons_search.t line 283. # got: 'No entries to show (filtered from 80 total entries)' # expected: 'Showing 1 to 2 of 2 entries (filtered from 80 total entries)' not ok 24 - Refining with header filters works to further filter the original query # Failed test 'Refining with header filters works to further filter the original query' # at ./t/db_dependent/selenium/patrons_search.t line 289. # got: 'No entries to show (filtered from 80 total entries)' # expected: 'Showing 1 to 1 of 1 entries (filtered from 80 total entries)' -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers@biblibre.co | |m Status|Pushed to master |Needs documenting --- Comment #43 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26916 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #44 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158876&action=edit Bug 34517: (follow-up) Mark test attribute as searched_by_default -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #45 from Nick Clemens <nick@bywatersolutions.com> --- Created attachment 158878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158878&action=edit Bug 34517: (follow-up) Add test for attribute search field and make cleanup more robust This patch adds a test to cover the new functionality of searching an attribute not searched by default. It also moves the addition of objects to the cleanup array right after they are created. Patrons are added to the front of the array to ensure no constraints are violated when deleting. This change ensures that if the tests die before reachign the end, the data generated is still cleaned up. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 --- Comment #46 from Nick Clemens <nick@bywatersolutions.com> --- (In reply to Jonathan Druart from comment #39)
IMO selenium tests are required for any changes to patron search.
Tests added, with a slight adjustment to improve cleanup -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | --- Comment #47 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Last two patches pushed to master. Thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |36301 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36301 [Bug 36301] Patron search is searching on attribute types even if a specific non attribute type search field is selected -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=36301 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Caroline Cyr La Rose <caroline.cyr-la-rose@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose@inlibr | |o.com Resolution|--- |FIXED Documentation| |https://gitlab.com/koha-com submission| |munity/koha-manual/-/merge_ | |requests/927 Status|Needs documenting |RESOLVED Documentation| |Caroline Cyr La Rose contact| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34517 Bug 34517 depends on bug 26916, which changed state. Bug 26916 Summary: Show searchable patron attributes in patron search dropdown https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org