[Bug 35303] New: Staff interface header - patron search autocomplete no longer works (Uncaught TypeError: search_fields.forEach is not a function)
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 Bug ID: 35303 Summary: Staff interface header - patron search autocomplete no longer works (Uncaught TypeError: search_fields.forEach is not a function) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff interface Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org CC: gmcharlt@gmail.com The patron search autocomplete is no longer working in master (it was working yesterday, it wasn't after I did a git pull for Koha). To replicate: 1. In the staff interface, start a search for a patron in the header (with check out selected), for example: mary 2. Notice that the autocomplete results are not displayed, and that there is a spinner going round just before the search button. 3. Under web developer tools note that there is a JavaScript error in the console: Uncaught TypeError: search_fields.forEach is not a function buildPatronSearchQuery http://127.0.0.1:8081/intranet-tmpl/prog/js/staff-global_23.0600073.js:615 buildPatronSearchQuery http://127.0.0.1:8081/intranet-tmpl/prog/js/staff-global_23.0600073.js:613 source http://127.0.0.1:8081/intranet-tmpl/prog/js/staff-global_23.0600073.js:453 jQuery 6 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |26916 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 [Bug 26916] Show searchable patron attributes in patron search dropdown -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs@lists.koha-commun |oleonard@myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 Jonathan Druart <jonathan.druart+koha@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 --- Comment #1 from Jonathan Druart <jonathan.druart+koha@gmail.com> --- Created attachment 158717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158717&action=edit Bug 35303: (bug 26916 follow-up) Fix paton autocomplete Fix the following JS error: Uncaught TypeError: search_fields.forEach is not a function -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158717|0 |1 is obsolete| | --- Comment #2 from David Nind <david@davidnind.com> --- Created attachment 158721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158721&action=edit Bug 35303: (bug 26916 follow-up) Fix paton autocomplete Fix the following JS error: Uncaught TypeError: search_fields.forEach is not a function Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 --- Comment #3 from David Nind <david@davidnind.com> --- Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 Pedro Amorim <pedro.amorim@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #158721|0 |1 is obsolete| | --- Comment #4 from Pedro Amorim <pedro.amorim@ptfs-europe.com> --- Created attachment 158742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=158742&action=edit Bug 35303: (bug 26916 follow-up) Fix paton autocomplete Fix the following JS error: Uncaught TypeError: search_fields.forEach is not a function Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 Fridolin Somers <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #6 from Fridolin Somers <fridolin.somers@biblibre.com> --- Depends on Bug 26916 not in 23.05.x -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35303 Bug 35303 depends on bug 26916, which changed state. Bug 26916 Summary: Show searchable patron attributes in patron search dropdown https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26916 What |Removed |Added ---------------------------------------------------------------------------- Status|Needs documenting |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org