[Bug 32126] New: Adding item search fields is broken - can't add more than one field
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Bug ID: 32126 Summary: Adding item search fields is broken - can't add more than one field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs@lists.koha-community.org Reporter: david@davidnind.com QA Contact: testopia@bugs.koha-community.org When adding item search fields (Administration > Catalog > Item search fields) in current master, you can only add one new field. If you try and add another one, the body of the page is blank (navigation, etc is still in place). I also checked this on the latest 22.05, and this problem doesn't occur - I can successfully add multiple item search fields. So something has broken this in master. I have also tried in different browsers (Firefox and Google Chrome). To replicate: 1. Go to Administration > Catalog > Item search fields. 2. Click on 'New search field'. 3. Enter required details and submit: ==> table with the item search field added displayed. 4. Repeat step 2: ==> You now get a blank page (navigation, etc is still in place) and no add new item search field form. Identified when testing bug 31406. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |31406 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31406 [Bug 31406] Set focus for cursor to Name input when adding a new item search field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 --- Comment #1 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Confirmed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major Keywords| |rel_22_11_candidate --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- This is related to our changes on the page, but I haven't quite figured out yet what's going on. The visibility of the form on the page is managed with Javascript: $(document).ready(function(){ $("#add_field_form").hide(); $("#new_search_field").on("click",function(e){ e.preventDefault(); $("#add_field_form").show(); $(".dialog").hide(); $("#search_fields_list").hide(); }); $(".hide_form").on("click",function(e){ e.preventDefault(); $("#add_field_form").hide(); $(".dialog").show(); $("#search_fields_list,#toolbar").show(); }); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs@lists.koha-commun |katrin.fischer@bsz-bw.de |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |31886 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 [Bug 31886] No side menu when searching for syspref -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|31886 |31986 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31886 [Bug 31886] No side menu when searching for syspref https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 [Bug 31986] Add page-section to various administration pages -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 143917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143917&action=edit Bug 32126: Fix missing div breaking the form for adding more search fields The missing div caused a problem with the JS that controls visibility of the list of search fields, the form and the toolbar. With the div added, everything should now work as expected. To test: * Add a item search field, everything should work. * Add a second item search field - intead of the form, you'll see an empty page. * Apply patch. * Add second and more search fields, all should work. * Edit search fields. * Delete search fields. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |32213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32213 [Bug 32213] Reindent item search fields template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 David Nind <david@davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #143917|0 |1 is obsolete| | --- Comment #4 from David Nind <david@davidnind.com> --- Created attachment 143923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=143923&action=edit Bug 32126: Fix missing div breaking the form for adding more search fields The missing div caused a problem with the JS that controls visibility of the list of search fields, the form and the toolbar. With the div added, everything should now work as expected. To test: * Add a item search field, everything should work. * Add a second item search field - intead of the form, you'll see an empty page. * Apply patch. * Add second and more search fields, all should work. * Edit search fields. * Delete search fields. Signed-off-by: David Nind <david@davidnind.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 --- Comment #5 from David Nind <david@davidnind.com> --- Thanks Katrin for fixing! I did note (and it was doing it before this patch) that the form very briefly appears then disappears when there are no item search fields, or when going to Administration > Item search fields. Another bug, or just the way this one works? David -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Just the way this works - elements get hidden/unhidden with Javascript, that's the flickering you see. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 --- Comment #7 from David Nind <david@davidnind.com> --- (In reply to Katrin Fischer from comment #6)
Just the way this works - elements get hidden/unhidden with Javascript, that's the flickering you see.
Thanks Katrin! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- A major bug, a silly easy fix, but noone to QA? :( -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |23.05.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 --- Comment #9 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|23.05.00 |23.05.00, 22.11.01 released in| | Status|Pushed to master |Pushed to stable CC| |martin.renvoize@ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Pushed to 22.11.x for 22.11.01 release. Thanks everyone. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32126 Bug 32126 depends on bug 31986, which changed state. Bug 31986 Summary: Add page-section to various administration pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31986 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org