[Bug 31996] New: Make note-style messages consistent with dialogs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 Bug ID: 31996 Summary: Make note-style messages consistent with dialogs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org CC: testopia@bugs.koha-community.org Depends on: 31973 In a few places we use <div class="note"> which is an alternative to <div class="dialog message">, displaying at full width of the container and often prepended by an icon. The style of this message has not been updated as part of the redesign. It should be made to match the .dialog.message style. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 [Bug 31973] Restore background color to message-style alerts -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 142680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142680&action=edit Bug 31996: Make note-style messages consistent with dialogs This patch modifies the style of divs with the class "note," making them have the same background color as message dialogs as proposed in Bug 31973. To test, apply the patch and rebuild the staff interface CSS. Confirm that the updated style looks good. Some pages where you can find examples: - Administration -> Authorized values -> View a categories values. - Administration -> Search engine cofiguration (with Elasticsearch enabled). - Cataloging -> Batch record deletion -> Submit a list of biblionumbers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia@bugs.koha-communit |katrin.fischer@bsz-bw.de |y.org | --- Comment #2 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Stlye guilde material? :) -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142680|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142687&action=edit Bug 31996: Make note-style messages consistent with dialogs This patch modifies the style of divs with the class "note," making them have the same background color as message dialogs as proposed in Bug 31973. To test, apply the patch and rebuild the staff interface CSS. Confirm that the updated style looks good. Some pages where you can find examples: - Administration -> Authorized values -> View a categories values. - Administration -> Search engine cofiguration (with Elasticsearch enabled). - Cataloging -> Batch record deletion -> Submit a list of biblionumbers. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #142687|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 142688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=142688&action=edit Bug 31996: Make note-style messages consistent with dialogs This patch modifies the style of divs with the class "note," making them have the same background color as message dialogs as proposed in Bug 31973. To test, apply the patch and rebuild the staff interface CSS. Confirm that the updated style looks good. Some pages where you can find examples: - Administration -> Authorized values -> View a categories values. - Administration -> Search engine cofiguration (with Elasticsearch enabled). - Cataloging -> Batch record deletion -> Submit a list of biblionumbers. Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Simple CSS change, makes this fit in much better. Straight to PQA. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |22.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Pushed to master for 22.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 Bug 31996 depends on bug 31973, which changed state. Bug 31973 Summary: Restore background color to message-style alerts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31973 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31996 Lucas Gass <lucas@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |lucas@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org