http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880 --- Comment #1 from tmcmahon@wlpl.org --- *** Bug 14860 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880 --- Comment #2 from Lari Taskula <larit@student.uef.fi> --- Created attachment 42879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42879&action=edit Bug 14880: Keyboard shortcuts don't work after setting CircAutocompl to "Don't try" The issue is that CircAutocompl loads a script element under #header_search element. When this element is missing, it also messes up the indexing, because we were calculating the indexing of the found element by subtracting one from the found element's index (to eliminate the <script> element). Thats why the shortcut key problem in this bug takes you one too to the left, because we are still subtracting one from the index even though there is no <script> element anymore. This patches selects only the div elements and gets the index from them. No subtractions needed. To test keys: 1. Set CircAutocompl system preference to Don't try. 2. Try the shortcut keys. They will work incorrectly like this: Alt+U = Search catalogue Alt+R = Check out Alt+Q = Check in 3. Set CircAutocompl system preference to Try. 4. Try the shortcut keys. They will work correctly like this: Alt+U = Check out Alt+R = Check in ALt+Q = Search catalogue 5. Apply patch 6. Repeat step 1 and 4. 7. Repeat step 3 and 4. 8. Observe that regardless of CircAutocompl, shortcut keys worked correctly. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880 --- Comment #3 from Lari Taskula <larit@student.uef.fi> --- See also bug 14829 if the test plan above fails in Patrons/Cataloging modules. -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |veron@veron.ch Attachment #42879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880 Marc Véron <veron@veron.ch> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #42945|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 42982 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=42982&action=edit [PASSED QA] Bug 14880: Keyboard shortcuts don't work after setting CircAutocompl to "Don't try" The issue is that CircAutocompl loads a script element under #header_search element. When this element is missing, it also messes up the indexing, because we were calculating the indexing of the found element by subtracting one from the found element's index (to eliminate the <script> element). Thats why the shortcut key problem in this bug takes you one too to the left, because we are still subtracting one from the index even though there is no <script> element anymore. This patches selects only the div elements and gets the index from them. No subtractions needed. To test keys: 1. Set CircAutocompl system preference to Don't try. 2. Try the shortcut keys. They will work incorrectly like this: Alt+U = Search catalogue Alt+R = Check out Alt+Q = Check in 3. Set CircAutocompl system preference to Try. 4. Try the shortcut keys. They will work correctly like this: Alt+U = Check out Alt+R = Check in ALt+Q = Search catalogue 5. Apply patch 6. Repeat step 1 and 4. 7. Repeat step 3 and 4. 8. Observe that regardless of CircAutocompl, shortcut keys worked correctly. Followed test plan, works as expected. Signed-off-by: Marc Véron <veron@veron.ch> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14880 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |chris@bigballofwax.co.nz --- Comment #7 from Chris Cormack <chris@bigballofwax.co.nz> --- Pushed to 3.20.x will be in 3.20.5 -- You are receiving this mail because: You are watching all bug changes.