[Bug 13971] New: Adjusted locations in koha-rebuild-zebra for gitified instance
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 Bug ID: 13971 Summary: Adjusted locations in koha-rebuild-zebra for gitified instance Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Packaging Assignee: koha-bugs@lists.koha-community.org Reporter: m.de.rooy@rijksmuseum.nl QA Contact: testopia@bugs.koha-community.org CC: robin@catalyst.net.nz -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 --- Comment #1 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 37582 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37582&action=edit Bug 13971: Adjusted locations in koha-rebuild-zebra for gitified instance This patch adds a few lines to koha-rebuild-zebra in order to adjust the locations for PERL5LIB and rebuild_zebra.pl script. It builds on the notion that /etc/koha/sites/[instance] contains a file called gitified containing the path to the gitified instance (instead of the default /usr/share/koha or other installed default). NOTE: As long as the gitified file does not exist, behavior does not change. I will submit a separate follow-up report for creating the gitified file. Furthermore, I would like to use the Zebra setup from the gitified instance instead of the default files in /etc/koha/zebradb. Will put that in another report too. Test plan: [1] Do not have a file /etc/koha/sites/[instance]/gitified. [2] Run koha-rebuild-zebra -a -b -v [instance] [3] If you have a gitified Koha instance, put the path in that etc file. [4] Run koha-rebuild-zebra -a -b -v [instance] -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish@catalyst.net.nz Assignee|koha-bugs@lists.koha-commun |m.de.rooy@rijksmuseum.nl |ity.org | --- Comment #2 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Would be interested in feedback on this idea (including the mentioned follow-ups in the commit message) from Robin for packages or Chris for gitify! Note that I am just exploring Debian now finally :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 --- Comment #3 from Robin Sheat <robin@catalyst.net.nz> --- So, Liz and I were chatting about this just yesterday. What I was thinking was having a library file/function that all the scripts run that exports PERL5LIB into the environment, taking it from, perhaps, koha-conf.xml. Currently koha-conf.xml doesn't really have a facility for a path for this, but adding one wouldn't be a big deal. On the other hand, I like better your more general (and easier to work with programmatically) method of having a file, though I'd be not inclined to call it 'gitify' just because it's useful in other situations too, I'm sure (though I don't know what :) So yeah, like the plan and the approach, just think it should be generalised a bit more using the library stuff we have so it works for other scripts too (_especially_ koha-upgrade-schema.) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37582|0 |1 is obsolete| | --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 37616 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37616&action=edit Bug 13971: Adjusted locations in koha-rebuild-zebra for gitified instance This patch adds a few lines to koha-rebuild-zebra in order to adjust the locations for PERL5LIB and rebuild_zebra.pl script. It also adds two functions to koha-functions: is_gitified and get_perl5lib. It builds on the notion that koha-conf.xml contains a <gitified> tag for gitified installs. It also looks for a perl5lib tag in koha-conf. NOTE: If the gitified or the perl5lib tag does not exist, behavior does not change. I will submit a separate follow-up report for adding those tags. The use of function get_perl5lib can replace hardcoded paths in the other scripts too; I will also move that to a new report. Furthermore, I would like to use the Zebra setup from the gitified instance instead of the default files in /etc/koha/zebradb. Will put that in another report too. Test plan: [1] Verify that your koha-conf does not contain: <gitified>1</gitified> [2] Run koha-rebuild-zebra -a -b -v [instance] [3] If you have a gitified instance, add the gitified tag to your koha-conf and the path in a perl5lib tag. [4] Run koha-rebuild-zebra -a -b -v [instance] Verify that you run the right version of rebuild_zebra.pl. You could do that by adding a simple debug print. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 --- Comment #5 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- (In reply to Robin Sheat from comment #3)
So, Liz and I were chatting about this just yesterday. What I was thinking was having a library file/function that all the scripts run that exports PERL5LIB into the environment, taking it from, perhaps, koha-conf.xml.
Currently koha-conf.xml doesn't really have a facility for a path for this, but adding one wouldn't be a big deal.
On the other hand, I like better your more general (and easier to work with programmatically) method of having a file, though I'd be not inclined to call it 'gitify' just because it's useful in other situations too, I'm sure (though I don't know what :)
So yeah, like the plan and the approach, just think it should be generalised a bit more using the library stuff we have so it works for other scripts too (_especially_ koha-upgrade-schema.)
Thanks. Submitted an adjusted patch for those two actually separate things: 1) get a path from koha-conf with get_perl5lib 2) get gitified status from koha-conf too with is_gitified (no longer a file) So two new functions in koha-functions. Please look too at the scriptdir lines in koha-rebuild-zebra at the start. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #37616|0 |1 is obsolete| | --- Comment #6 from Mirko Tietgen <mirko@abunchofthings.net> --- Created attachment 40628 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40628&action=edit Bug 13971: Adjusted locations in koha-rebuild-zebra for gitified instance This patch adds a few lines to koha-rebuild-zebra in order to adjust the locations for PERL5LIB and rebuild_zebra.pl script. It also adds two functions to koha-functions: is_gitified and get_perl5lib. It builds on the notion that koha-conf.xml contains a <gitified> tag for gitified installs. It also looks for a perl5lib tag in koha-conf. NOTE: If the gitified or the perl5lib tag does not exist, behavior does not change. I will submit a separate follow-up report for adding those tags. The use of function get_perl5lib can replace hardcoded paths in the other scripts too; I will also move that to a new report. Furthermore, I would like to use the Zebra setup from the gitified instance instead of the default files in /etc/koha/zebradb. Will put that in another report too. Test plan: [1] Verify that your koha-conf does not contain: <gitified>1</gitified> [2] Run koha-rebuild-zebra -a -b -v [instance] [3] If you have a gitified instance, add the gitified tag to your koha-conf and the path in a perl5lib tag. [4] Run koha-rebuild-zebra -a -b -v [instance] Verify that you run the right version of rebuild_zebra.pl. You could do that by adding a simple debug print. Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 Mirko Tietgen <mirko@abunchofthings.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mirko@abunchofthings.net Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 Jonathan Druart <jonathan.druart@bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart@bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart@bugs.koha-community.org> --- Looks good to me. I would like to get a signoff from Robin or Chris Hall to be more comfortable before passing QA on it. Is there an easy way to know if an instance has been gitified? It will avoid to manually add a new entry to the koha-conf file. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13971 Marcel de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #8 from Marcel de Rooy <m.de.rooy@rijksmuseum.nl> --- Moving this one to BLOCKED May come up with a slightly adjusted approach.. -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org