[Bug 10548] New: koha_perl_deps.pl miscounts dependencies displayed
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Bug ID: 10548 Summary: koha_perl_deps.pl miscounts dependencies displayed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: gmcharlt@gmail.com Reporter: mtompset@hotmail.com $ cd kohaclone $ ./koha-perl-deps.pl -m -u Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- Data::Pagination 0 * 0.44 No Archive::Extract 0.48 * 0.60 No Test::WWW::Mechanize 1.36 * 1.44 No -------------------------------------------------------------------------------------------- Total modules reported: 3 * Module is missing or requires an upgrade. $ ./koha-perl-deps.pl -m -u -r Installed Required Module is Module Name Version Version Required -------------------------------------------------------------------------------------------- -------------------------------------------------------------------------------------------- Total modules reported: 3 * Module is missing or requires an upgrade. The second number should be 0. This tiny patch fixes it. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 M. Tompsett <mtompset@hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|gmcharlt@gmail.com |mtompset@hotmail.com --- Comment #1 from M. Tompsett <mtompset@hotmail.com> --- Created attachment 19442 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19442&action=edit Moved $count++ into if statements to fix miscount. TEST ----- $ cd kohaclone $ ./koha_perl_deps.pl -m -u if you have nothing missing, uninstall an optional component. $ ./koha_perl_deps.pl -m -u you should get a number missing of at least 1. $ ./koha_perl_deps.pl -m -u -r you should get the same number, even though the output is less. apply patch $ ./koha_perl_deps.pl -m -u same results $ ./koha_perl_deps.pl -m -u -r the number should differ. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19442|0 |1 is obsolete| | --- Comment #2 from Galen Charlton <gmcharlt@gmail.com> --- Created attachment 19524 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19524&action=edit bug 10548: fix count of missing required dependencies by koha_perl_deps.pl To test: [1] ./koha_perl_deps.pl -m -u If you have nothing missing, uninstall an optional component. [2] ./koha_perl_deps.pl -m -u You should get a number missing of at least 1. [3] ./koha_perl_deps.pl -m -u -r You should get the same number, even though the output is less. [4] Apply patch [5] ./koha_perl_deps.pl -m -u Same results as in step 2. [6] ./koha_perl_deps.pl -m -u -r The number should differ from the results in step 3. Signed-off-by: Galen Charlton <gmc@esilibrary.com> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19524|0 |1 is obsolete| | --- Comment #3 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- Created attachment 19568 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19568&action=edit bug 10548: fix count of missing required dependencies by koha_perl_deps.pl To test: [1] ./koha_perl_deps.pl -m -u If you have nothing missing, uninstall an optional component. [2] ./koha_perl_deps.pl -m -u You should get a number missing of at least 1. [3] ./koha_perl_deps.pl -m -u -r You should get the same number, even though the output is less. [4] Apply patch [5] ./koha_perl_deps.pl -m -u Same results as in step 2. [6] ./koha_perl_deps.pl -m -u -r The number should differ from the results in step 3. Signed-off-by: Galen Charlton <gmc@esilibrary.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 M. de Rooy <m.de.rooy@rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |m.de.rooy@rijksmuseum.nl --- Comment #4 from M. de Rooy <m.de.rooy@rijksmuseum.nl> --- QA Comment: Tiny patch. Looks good to me. Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |gmcharlt@gmail.com --- Comment #5 from Galen Charlton <gmcharlt@gmail.com> --- Pushed to master. Thanks, Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Galen Charlton <gmcharlt@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |tomascohen@gmail.com --- Comment #6 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Mark! -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10548 Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel@gmail.com --- Comment #7 from Bernardo Gonzalez Kriegel <bgkriegel@gmail.com> --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org