http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Colin Campbell <colin.campbell@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell <colin.campbell@ptfs-europe.com> --- Created attachment 19396 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19396&action=edit Proposed Patch My original patch, which has been tested in production used the currency symbol. However looking for a non-SIP usage of the message field to put in testplan, I realized that in the patron screens we consistently omit the currency symbol from money amounts, so this version is consistent with that practice. To test using a sip device issue a patron information request (63) for a patron owing fines. Without this patch the response will include in the screen message 'Patron owes $6.00' with this patch applied it returns 'Patron owes 6.00' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Chris Cormack <chris@bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19396|0 |1 is obsolete| | --- Comment #2 from Chris Cormack <chris@bigballofwax.co.nz> --- Created attachment 19445 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19445&action=edit Bug 10529: Remove hardcoded dollar from patron message The message fields which are returned in the SIP Screen message field in a Patron Information response had dollar hardcoded. It would be possible to get the symbol from currency but omitting any symbol would be consistent with the UI and avoid problems with devices using weird encodings for local currency symbols (e.g. the many variations of UK Pound sign) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Kyle M Hall <kyle@bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19445|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle@bywatersolutions.com> --- Created attachment 19609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19609&action=edit Bug 10529: Remove hardcoded dollar from patron message The message fields which are returned in the SIP Screen message field in a Patron Information response had dollar hardcoded. It would be possible to get the symbol from currency but omitting any symbol would be consistent with the UI and avoid problems with devices using weird encodings for local currency symbols (e.g. the many variations of UK Pound sign) Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes.

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10529 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen@gmail.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Colin! -- You are receiving this mail because: You are watching all bug changes.