[Bug 23458] New: Clean up holds template in the staff client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Bug ID: 23458 Summary: Clean up holds template in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard@myacpl.org Reporter: oleonard@myacpl.org QA Contact: testopia@bugs.koha-community.org Depends on: 17057 I would like to reindent reserve/request.tt: Remove tabs, correct indentation, add some comments to clarify the structure. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 [Bug 17057] Remove event attributes from holds template -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92242&action=edit Bug 23458: Clean up holds template in the staff client This patch reindents reserve/request.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm no diffctator. Test the process of placing a hold in the staff client: A single hold, multiple holds, etc. Everything should work correctly. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 --- Comment #2 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92243&action=edit Bug 23458: (follow-up) Add comments to markup This patch adds a few comments to the markup in order to highlight the structure of the page. -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92242|0 |1 is obsolete| | --- Comment #3 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 92295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92295&action=edit Bug 23458: Clean up holds template in the staff client This patch reindents reserve/request.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm no diffctator. Test the process of placing a hold in the staff client: A single hold, multiple holds, etc. Everything should work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92243|0 |1 is obsolete| | --- Comment #4 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 92296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92296&action=edit Bug 23458: (follow-up) Add comments to markup This patch adds a few comments to the markup in order to highlight the structure of the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92295|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92331&action=edit Bug 23458: Clean up holds template in the staff client This patch reindents reserve/request.tt to use four spaces and to eliminate tabs, following coding guidelines. Trailing white space has been removed. To test, apply the patch and use your preferred method for checking the differences between files while ignoring whitespace. I use diff with the "-w" flag, but I'm no diffctator. Test the process of placing a hold in the staff client: A single hold, multiple holds, etc. Everything should work correctly. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92296|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92332&action=edit Bug 23458: (follow-up) Add comments to markup This patch adds a few comments to the markup in order to highlight the structure of the page. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 --- Comment #7 from Martin Renvoize <martin.renvoize@ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Bug 23458 depends on bug 17057, which changed state. Bug 17057 Summary: Remove event attributes from holds template https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23458 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers@biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon@bugs.koha-community.org