https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 54055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54055&action=edit Bug 17057 - Remove event attributes from holds template This patch removes event attributes from the holds template. Events are defined instead in the JavaScript. Also changed: Move formatting of hold date to the template; Corrected a non-functional 'cancel hold' link. To test apply the patch and: - Start the process of placing a hold on a single title for a patron. - Uncheck 'Place a hold on the next available item' and try to submit the form without selecting an item. You should be prompted to select an item. - Place a hold on multiple titles at the same time. Confirm that your hold is saved correctly. - View the holds for a title which has multiple holds. - Confirm that clicking the "X" image triggers a confirmation. Test canceling and confirming. - With SuspendHoldsIntranet enabled, select a 'Suspend until' date for any hold and confirm that the corresponding 'Clear date' link works correctly. - Confirm that suspending a hold with and without an expiration date works correctly. - Place an item-level hold. - View the holds for that same title. - Submit another patron to place a new hold. - In the list of items which can be placed on hold, look for the item you place on hold previously. There should be a "Cancel hold" link in the information column. Confirm that this link correctly triggers a confirmation dialog and deletes the hold. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Claire Gravely <c.gravely@arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54055|0 |1 is obsolete| | --- Comment #2 from Claire Gravely <c.gravely@arts.ac.uk> --- Created attachment 54072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54072&action=edit Bug 17057 - Remove event attributes from holds template This patch removes event attributes from the holds template. Events are defined instead in the JavaScript. Also changed: Move formatting of hold date to the template; Corrected a non-functional 'cancel hold' link. To test apply the patch and: - Start the process of placing a hold on a single title for a patron. - Uncheck 'Place a hold on the next available item' and try to submit the form without selecting an item. You should be prompted to select an item. - Place a hold on multiple titles at the same time. Confirm that your hold is saved correctly. - View the holds for a title which has multiple holds. - Confirm that clicking the "X" image triggers a confirmation. Test canceling and confirming. - With SuspendHoldsIntranet enabled, select a 'Suspend until' date for any hold and confirm that the corresponding 'Clear date' link works correctly. - Confirm that suspending a hold with and without an expiration date works correctly. - Place an item-level hold. - View the holds for that same title. - Submit another patron to place a new hold. - In the list of items which can be placed on hold, look for the item you place on hold previously. There should be a "Cancel hold" link in the information column. Confirm that this link correctly triggers a confirmation dialog and deletes the hold. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54072|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 54109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54109&action=edit [PASSED QA] Bug 17057 - Remove event attributes from holds template This patch removes event attributes from the holds template. Events are defined instead in the JavaScript. Also changed: Move formatting of hold date to the template; Corrected a non-functional 'cancel hold' link. To test apply the patch and: - Start the process of placing a hold on a single title for a patron. - Uncheck 'Place a hold on the next available item' and try to submit the form without selecting an item. You should be prompted to select an item. - Place a hold on multiple titles at the same time. Confirm that your hold is saved correctly. - View the holds for a title which has multiple holds. - Confirm that clicking the "X" image triggers a confirmation. Test canceling and confirming. - With SuspendHoldsIntranet enabled, select a 'Suspend until' date for any hold and confirm that the corresponding 'Clear date' link works correctly. - Confirm that suspending a hold with and without an expiration date works correctly. - Place an item-level hold. - View the holds for that same title. - Submit another patron to place a new hold. - In the list of items which can be placed on hold, look for the item you place on hold previously. There should be a "Cancel hold" link in the information column. Confirm that this link correctly triggers a confirmation dialog and deletes the hold. Signed-off-by: Claire Gravely <c.gravely@arts.ac.uk> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 --- Comment #5 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 92179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92179&action=edit Bug 17057: (follow-up) Replace onsubmit attributes This patch removes the "onsubmit" attribute from the place hold form. To test, apply the patch and test placing a hold: Begin the process of placing a hold on a single title. On the place hold screen, uncheck the "Hold next available item" checkbox and click the "Place hold" button. You should be get an alert saying "Please select an item to place a hold." Select an item and click the "Place hold" button again. The hold should be placed. This patch affects the form validation for placing multiple holds, but I don't think the JavaScript ever has a chance to run: The template blocks the user from placing multiple holds if one of the titles has no items. -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92178|0 |1 is obsolete| | --- Comment #6 from Maryse Simard <maryse.simard@inlibro.com> --- Created attachment 92293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92293&action=edit Bug 17057: Remove event attributes from holds template My orginal patch for this bug contained a lot of changes made obsolete by Bug 19469, which created holds_table.inc. This new version makes one minor change only to request.tt, adding a class name and removing an onclick attribute. To test, apply the patch and place an item-level hold on a title. Start the process of placing another hold on that item. On the "place hold" screen, in the table of items, you should see a "Cancel hold" link for the item you previously placed on hold. - Click the "Cancel hold" link - Clicking "Cancel" in the confirmation dialog should cancel the operation. - Clicking "OK" should cancel the hold. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Maryse Simard <maryse.simard@inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard@inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92293|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 92329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=92329&action=edit Bug 17057: Remove event attributes from holds template My orginal patch for this bug contained a lot of changes made obsolete by Bug 19469, which created holds_table.inc. This new version makes one minor change only to request.tt, adding a class name and removing an onclick attribute. To test, apply the patch and place an item-level hold on a title. Start the process of placing another hold on that item. On the "place hold" screen, in the table of items, you should see a "Cancel hold" link for the item you previously placed on hold. - Click the "Cancel hold" link - Clicking "Cancel" in the confirmation dialog should cancel the operation. - Clicking "OK" should cancel the hold. Signed-off-by: Maryse Simard <maryse.simard@inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Martin Renvoize <martin.renvoize@ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes.

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17057 Fridolin SOMERS <fridolin.somers@biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers@biblibre.co | |m Resolution|--- |FIXED --- Comment #11 from Fridolin SOMERS <fridolin.somers@biblibre.com> --- Enhancement not pushed to 19.05.x -- You are receiving this mail because: You are watching all bug changes.