[Bug 8521] New: Error in warning message when deleting list
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 Priority: P5 - low Change sponsored?: --- Bug ID: 8521 CC: m.de.rooy@rijksmuseum.nl Assignee: gmcharlt@gmail.com Summary: Error in warning message when deleting list Severity: normal Classification: Unclassified OS: All Reporter: oleonard@myacpl.org Hardware: All Status: NEW Version: master Component: Virtual Shelves Product: Koha If you have a list containing more than 20 items and you try to delete it the warning message gives the wrong count: The list <list name> is not empty. It has 20 entries. Use the "Confirm" button below to confirm deletion. The count is always 20. The same error occurs in the staff client and OPAC. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 Owen Leonard <oleonard@myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 --- Comment #1 from Owen Leonard <oleonard@myacpl.org> --- Created attachment 29751 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29751&action=edit Bug 8521 - Error in warning message when deleting list When deleting a list the operation is blocked if there are items still on the list, and the interface shows a warning which includes a count of the items on the list. This count is broken for lists containing more items than the number specified in the numSearchResults system preference. This patch corrects the item count to use an actual count of the total number of results, not the total number of results in the first page of results. The template change to the staff client copies some language logic from the OPAC template for dealing with a single number of list entries. Test in both the OPAC and the staff client. Check the number specified in the numSearchResults system preference and locate or create a list containing more than that number of items. Try to delete the list. You should receive a warning message stating the correct total number of items on the list. Test also with a list which contains fewer than numSearchResults entries, and a list which contains zero entries. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 Ian Beardslee <ibeardslee@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #29751|0 |1 is obsolete| | Status|Needs Signoff |Signed Off CC| |ibeardslee@gmail.com Assignee|gmcharlt@gmail.com |ibeardslee@gmail.com --- Comment #2 from Ian Beardslee <ibeardslee@gmail.com> --- Created attachment 30064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30064&action=edit Signed off patch Tested Public and Private lists with 0, 5 & 25 entries, Public with 40 and Private with 45. Working as expected. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer@bsz-bw.de Assignee|ibeardslee@gmail.com |oleonard@myacpl.org -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 --- Comment #3 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Comment on attachment 30064 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30064 Signed off patch Review of attachment 30064: --> (http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=8521&attachment=30064) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/virtualshelves/shelves.tt @@ +234,5 @@
[% IF ( paramsloo.noshelfnumber ) %]<div class="dialog alert">ERROR: No list number given.</div>[% END %] [% IF ( paramsloo.need_confirm ) %] <div class="dialog alert">The list <i>[% paramsloo.need_confirm %]</i> is not empty. + [% IF ( paramsloo.single ) %] + <br />It has <b>[% paramsloo.count %]</b> entry.
The <b> will split up this sentence on translation - is it really necessary here? :) -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 Katrin Fischer <katrin.fischer@bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #30064|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer@bsz-bw.de> --- Created attachment 30523 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30523&action=edit [PASSED QA] Bug 8521 - Error in warning message when deleting list When deleting a list the operation is blocked if there are items still on the list, and the interface shows a warning which includes a count of the items on the list. This count is broken for lists containing more items than the number specified in the numSearchResults system preference. This patch corrects the item count to use an actual count of the total number of results, not the total number of results in the first page of results. The template change to the staff client copies some language logic from the OPAC template for dealing with a single number of list entries. Test in both the OPAC and the staff client. Check the number specified in the numSearchResults system preference and locate or create a list containing more than that number of items. Try to delete the list. You should receive a warning message stating the correct total number of items on the list. Test also with a list which contains fewer than numSearchResults entries, and a list which contains zero entries. Signed-off-by: Ian Beardslee <ian@catalyst.net.nz> Tested Public and Private lists with 0, 5 & 25 entries, Public with 40 and Private with 45. Working as expected. Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de> Works as described, passes tests and QA script. -- You are receiving this mail because: You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8521 Tomás Cohen Arazi <tomascohen@gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |tomascohen@gmail.com --- Comment #5 from Tomás Cohen Arazi <tomascohen@gmail.com> --- Patch pushed to master. Thanks Owen! -- You are receiving this mail because: You are watching all bug changes.
participants (1)
-
bugzilla-daemon＠bugs.koha-community.org